[jira] Created: (OFBIZ-2503) If order paid through Billing Account refund return response currently does nothing

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-2503) If order paid through Billing Account refund return response currently does nothing

Nicolas Malin (Jira)
If order paid through Billing Account refund return response currently does nothing
-----------------------------------------------------------------------------------

                 Key: OFBIZ-2503
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2503
             Project: OFBiz
          Issue Type: Improvement
          Components: order
    Affects Versions: SVN trunk
            Reporter: Santosh Malviya
            Priority: Minor
             Fix For: SVN trunk


If order paid through Billing Account refund return response currently does nothing, this happens because no payment record is created while making a sales order through the billing account, create service to automatically create a Payment and associate it with the Billing Account to cover outstanding invoices or as a balance for future orders.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-2503) If order paid through Billing Account refund return response currently does nothing

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Santosh Malviya updated OFBIZ-2503:
-----------------------------------

    Attachment: PaymentForBillingAccount.patch

Here is patch for the issue.

> If order paid through Billing Account refund return response currently does nothing
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2503
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2503
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Santosh Malviya
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: PaymentForBillingAccount.patch
>
>
> If order paid through Billing Account refund return response currently does nothing, this happens because no payment record is created while making a sales order through the billing account, create service to automatically create a Payment and associate it with the Billing Account to cover outstanding invoices or as a balance for future orders.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-2503) If order paid through Billing Account refund return response currently does nothing

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Divesh Dutta updated OFBIZ-2503:
--------------------------------

    Attachment: PaymentForBillingAccount.patch

In description it was advised to create service to automatically create a Payment and associate it with the Billing Account to cover outstanding invoices or as a balance for future orders. But here is the patch, with some below given changes

1) Existing "refundBillingAccountPayment" service, was not functional because getReceivedPaymentTotalsByPaymentMethod method of OrderReadHelper was not returning amount received from Billing Account.

2) So used getOrderPaymentPreferenceTotalByType of OrderReadHelper  which returns amount captured from Billing Account

3) Also improved getReceivedPaymentTotalsByPaymentMethod method of OrderReadHelper as it was returning refunded amount to Billing Account.

4) So added conditions, now getReceivedPaymentTotalsByPaymentMethod will return received payment totals.

Eventually, if user choosed return of type refund in case of Billing Account  then refunded amount will be credited in Billing Account

Lots of thanks to Mr. Mridul Pathak for discussing the Business scenarios


> If order paid through Billing Account refund return response currently does nothing
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2503
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2503
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Santosh Malviya
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: PaymentForBillingAccount.patch, PaymentForBillingAccount.patch
>
>
> If order paid through Billing Account refund return response currently does nothing, this happens because no payment record is created while making a sales order through the billing account, create service to automatically create a Payment and associate it with the Billing Account to cover outstanding invoices or as a balance for future orders.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-2503) If order paid through Billing Account refund return response currently does nothing

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-2503:
------------------------------------------

    Assignee: Ashish Vijaywargiya

> If order paid through Billing Account refund return response currently does nothing
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2503
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2503
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Santosh Malviya
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: PaymentForBillingAccount.patch, PaymentForBillingAccount.patch
>
>
> If order paid through Billing Account refund return response currently does nothing, this happens because no payment record is created while making a sales order through the billing account, create service to automatically create a Payment and associate it with the Billing Account to cover outstanding invoices or as a balance for future orders.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-2503) If order paid through Billing Account refund return response currently does nothing

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-2503.
--------------------------------------

    Resolution: Fixed

Thanks Santosh & Divesh.
Changes are in trunk at revision 785232.

--
Ashish

> If order paid through Billing Account refund return response currently does nothing
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2503
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2503
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Santosh Malviya
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: PaymentForBillingAccount.patch, PaymentForBillingAccount.patch
>
>
> If order paid through Billing Account refund return response currently does nothing, this happens because no payment record is created while making a sales order through the billing account, create service to automatically create a Payment and associate it with the Billing Account to cover outstanding invoices or as a balance for future orders.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.