[jira] Created: (OFBIZ-2902) ProductType hierarchy for Marketing Packages

[Nicolas Malin (Jira)]

ProductType hierarchy for Marketing Packages
--------------------------------------------

                 Key: OFBIZ-2902
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2902
             Project: OFBiz
          Issue Type: Improvement
          Components: framework, manufacturing, order, product
    Affects Versions: SVN trunk
            Reporter: Mridul Pathak
            Priority: Minor
             Fix For: SVN trunk


It should be possible to maintain hierarchy of Products of type MARKETING_PKG_PICK and MARKETING_PKG_AUTO for the custom needs.  Currently OFBiz supports such hierarchy, but the logic specific to Marketing Packages doesn't apply to its sub types.

The following can be done to add this support:
# Define a new parent ProductType MARKETING_PKG, the new hierarchy would be GOOD > MARKETING_PKG > MARKETING_PKG_AUTO and GOOD > MARKETING_PKG > MARKETING_PKG_PICK, further sub types can be added to the current leaf types.
# Change the current code specific to Marketing Packages to take into account sub types.  For this a utility method can be defined which checks for a parent type on the subtype and calls the logic.  The best would be to define a Common Utility method which takes the name of a Type entity, subtype, parent type, and then performs the check.

After above changes it would not only be possible to write code specific to a ProductType, but also for a specific level in the hierarchy so that it applies to all the sub levels.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mridul Pathak updated OFBIZ-2902:
---------------------------------

    Attachment: OFBiz_2902.patch

Here is the patch.  I didn't get a chance to test it today, just uploading it so that it can be reviewed.  I'll test the patch tomorrow.

Thanks to Jacopo for his valuable input on this feature.

> ProductType hierarchy for Marketing Packages
> --------------------------------------------
>
>                 Key: OFBIZ-2902
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2902
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, manufacturing, order, product
>    Affects Versions: SVN trunk
>            Reporter: Mridul Pathak
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBiz_2902.patch
>
>
> It should be possible to maintain hierarchy of Products of type MARKETING_PKG_PICK and MARKETING_PKG_AUTO for the custom needs.  Currently OFBiz supports such hierarchy, but the logic specific to Marketing Packages doesn't apply to its sub types.
> The following can be done to add this support:
> # Define a new parent ProductType MARKETING_PKG, the new hierarchy would be GOOD > MARKETING_PKG > MARKETING_PKG_AUTO and GOOD > MARKETING_PKG > MARKETING_PKG_PICK, further sub types can be added to the current leaf types.
> # Change the current code specific to Marketing Packages to take into account sub types.  For this a utility method can be defined which checks for a parent type on the subtype and calls the logic.  The best would be to define a Common Utility method which takes the name of a Type entity, subtype, parent type, and then performs the check.
> After above changes it would not only be possible to write code specific to a ProductType, but also for a specific level in the hierarchy so that it applies to all the sub levels.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753578#action_12753578 ]

Mridul Pathak commented on OFBIZ-2902:
--------------------------------------

I have tested this patch extensively now and changes are working fine, no issues found.

> ProductType hierarchy for Marketing Packages
> --------------------------------------------
>
>                 Key: OFBIZ-2902
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2902
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, manufacturing, order, product
>    Affects Versions: SVN trunk
>            Reporter: Mridul Pathak
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBiz_2902.patch
>
>
> It should be possible to maintain hierarchy of Products of type MARKETING_PKG_PICK and MARKETING_PKG_AUTO for the custom needs.  Currently OFBiz supports such hierarchy, but the logic specific to Marketing Packages doesn't apply to its sub types.
> The following can be done to add this support:
> # Define a new parent ProductType MARKETING_PKG, the new hierarchy would be GOOD > MARKETING_PKG > MARKETING_PKG_AUTO and GOOD > MARKETING_PKG > MARKETING_PKG_PICK, further sub types can be added to the current leaf types.
> # Change the current code specific to Marketing Packages to take into account sub types.  For this a utility method can be defined which checks for a parent type on the subtype and calls the logic.  The best would be to define a Common Utility method which takes the name of a Type entity, subtype, parent type, and then performs the check.
> After above changes it would not only be possible to write code specific to a ProductType, but also for a specific level in the hierarchy so that it applies to all the sub levels.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-2902:
----------------------------------------

    Assignee: Jacopo Cappellato

> ProductType hierarchy for Marketing Packages
> --------------------------------------------
>
>                 Key: OFBIZ-2902
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2902
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, manufacturing, order, product
>    Affects Versions: SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBiz_2902.patch
>
>
> It should be possible to maintain hierarchy of Products of type MARKETING_PKG_PICK and MARKETING_PKG_AUTO for the custom needs.  Currently OFBiz supports such hierarchy, but the logic specific to Marketing Packages doesn't apply to its sub types.
> The following can be done to add this support:
> # Define a new parent ProductType MARKETING_PKG, the new hierarchy would be GOOD > MARKETING_PKG > MARKETING_PKG_AUTO and GOOD > MARKETING_PKG > MARKETING_PKG_PICK, further sub types can be added to the current leaf types.
> # Change the current code specific to Marketing Packages to take into account sub types.  For this a utility method can be defined which checks for a parent type on the subtype and calls the logic.  The best would be to define a Common Utility method which takes the name of a Type entity, subtype, parent type, and then performs the check.
> After above changes it would not only be possible to write code specific to a ProductType, but also for a specific level in the hierarchy so that it applies to all the sub levels.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-2902.
------------------------------------

    Resolution: Fixed

Thanks Mridul, your patch is in rev. 813413

> ProductType hierarchy for Marketing Packages
> --------------------------------------------
>
>                 Key: OFBIZ-2902
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2902
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework, manufacturing, order, product
>    Affects Versions: SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBiz_2902.patch
>
>
> It should be possible to maintain hierarchy of Products of type MARKETING_PKG_PICK and MARKETING_PKG_AUTO for the custom needs.  Currently OFBiz supports such hierarchy, but the logic specific to Marketing Packages doesn't apply to its sub types.
> The following can be done to add this support:
> # Define a new parent ProductType MARKETING_PKG, the new hierarchy would be GOOD > MARKETING_PKG > MARKETING_PKG_AUTO and GOOD > MARKETING_PKG > MARKETING_PKG_PICK, further sub types can be added to the current leaf types.
> # Change the current code specific to Marketing Packages to take into account sub types.  For this a utility method can be defined which checks for a parent type on the subtype and calls the logic.  The best would be to define a Common Utility method which takes the name of a Type entity, subtype, parent type, and then performs the check.
> After above changes it would not only be possible to write code specific to a ProductType, but also for a specific level in the hierarchy so that it applies to all the sub levels.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.