[jira] Created: (OFBIZ-2923) Find tracking code page not redering

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-2923) Find tracking code page not redering

Nicolas Malin (Jira)
Find tracking code page not redering
------------------------------------

                 Key: OFBIZ-2923
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2923
             Project: OFBiz
          Issue Type: Bug
          Components: marketing
    Affects Versions: Release Branch 4.0
         Environment: Marketing application
            Reporter: Garfield Heron
             Fix For: Release Branch 4.0


the find tracking code page is not rendering.  The following patch fixes it.

Index: applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml
===================================================================
--- applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml (revision 754681)
+++ applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml (working copy)
@@ -260,7 +260,7 @@
         <alt-target use-when="trackingCodeType==null" target="createTrackingCodeType"/>
         
         <field use-when="trackingCodeType!=null" name="trackingCodeTypeId" title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}" tooltip="${uiLabelMap.CommonNotModifRecreat}" widget-style="tabletext"><display/></field>
-        <field use-when="trackingCodeType==null&amp;&amp;trackingCodeTypeId==null" name="trackingCodeTypeId" title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}"><§text/></field>
+        <field use-when="trackingCodeType==null&amp;&amp;trackingCodeTypeId==null" name="trackingCodeTypeId" title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}"><text/></field>
         <field use-when="trackingCodeType==null&amp;&amp;trackingCodeTypeId!=null" name="trackingCodeTypeId" title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}" tooltip="${uiLabelMap.CommonCannotBeFound}: [${trackingCodeTypeId}]" widget-style="tabletext"><display/></field>
 
         <field name="description" widget-style="inputBox" title="${uiLabelMap.TrackingCodeTypeDescription}"><text/></field>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2923) Find tracking code page not redering

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753228#action_12753228 ]

Garfield Heron commented on OFBIZ-2923:
---------------------------------------

Is there a list of commiters I could mail the patch to?

> Find tracking code page not redering
> ------------------------------------
>
>                 Key: OFBIZ-2923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2923
>             Project: OFBiz
>          Issue Type: Bug
>          Components: marketing
>    Affects Versions: Release Branch 4.0
>         Environment: Marketing application
>            Reporter: Garfield Heron
>             Fix For: Release Branch 4.0
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> the find tracking code page is not rendering.  The following patch fixes it.
> Index: applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml
> ===================================================================
> --- applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml (revision 754681)
> +++ applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml (working copy)
> @@ -260,7 +260,7 @@
>          <alt-target use-when="trackingCodeType==null" target="createTrackingCodeType"/>
>          
>          <field use-when="trackingCodeType!=null" name="trackingCodeTypeId" title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}" tooltip="${uiLabelMap.CommonNotModifRecreat}" widget-style="tabletext"><display/></field>
> -        <field use-when="trackingCodeType==null&amp;&amp;trackingCodeTypeId==null" name="trackingCodeTypeId" title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}"><§text/></field>
> +        <field use-when="trackingCodeType==null&amp;&amp;trackingCodeTypeId==null" name="trackingCodeTypeId" title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}"><text/></field>
>          <field use-when="trackingCodeType==null&amp;&amp;trackingCodeTypeId!=null" name="trackingCodeTypeId" title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}" tooltip="${uiLabelMap.CommonCannotBeFound}: [${trackingCodeTypeId}]" widget-style="tabletext"><display/></field>
>  
>          <field name="description" widget-style="inputBox" title="${uiLabelMap.TrackingCodeTypeDescription}"><text/></field>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-2923) Find tracking code page not redering

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753263#action_12753263 ]

Jacques Le Roux commented on OFBIZ-2923:
----------------------------------------

http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices

Your patch in comment should be ok for this though...

> Find tracking code page not redering
> ------------------------------------
>
>                 Key: OFBIZ-2923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2923
>             Project: OFBiz
>          Issue Type: Bug
>          Components: marketing
>    Affects Versions: Release Branch 4.0
>         Environment: Marketing application
>            Reporter: Garfield Heron
>             Fix For: Release Branch 4.0
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> the find tracking code page is not rendering.  The following patch fixes it.
> Index: applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml
> ===================================================================
> --- applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml (revision 754681)
> +++ applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml (working copy)
> @@ -260,7 +260,7 @@
>          <alt-target use-when="trackingCodeType==null" target="createTrackingCodeType"/>
>          
>          <field use-when="trackingCodeType!=null" name="trackingCodeTypeId" title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}" tooltip="${uiLabelMap.CommonNotModifRecreat}" widget-style="tabletext"><display/></field>
> -        <field use-when="trackingCodeType==null&amp;&amp;trackingCodeTypeId==null" name="trackingCodeTypeId" title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}"><§text/></field>
> +        <field use-when="trackingCodeType==null&amp;&amp;trackingCodeTypeId==null" name="trackingCodeTypeId" title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}"><text/></field>
>          <field use-when="trackingCodeType==null&amp;&amp;trackingCodeTypeId!=null" name="trackingCodeTypeId" title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}" tooltip="${uiLabelMap.CommonCannotBeFound}: [${trackingCodeTypeId}]" widget-style="tabletext"><display/></field>
>  
>          <field name="description" widget-style="inputBox" title="${uiLabelMap.TrackingCodeTypeDescription}"><text/></field>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-2923) Find tracking code page not redering

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-2923.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Garfield,

Fixed at r813120  


> Find tracking code page not redering
> ------------------------------------
>
>                 Key: OFBIZ-2923
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2923
>             Project: OFBiz
>          Issue Type: Bug
>          Components: marketing
>    Affects Versions: Release Branch 4.0
>         Environment: Marketing application
>            Reporter: Garfield Heron
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 4.0
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> the find tracking code page is not rendering.  The following patch fixes it.
> Index: applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml
> ===================================================================
> --- applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml (revision 754681)
> +++ applications/marketing/webapp/marketing/trackingcode/TrackingCodeForms.xml (working copy)
> @@ -260,7 +260,7 @@
>          <alt-target use-when="trackingCodeType==null" target="createTrackingCodeType"/>
>          
>          <field use-when="trackingCodeType!=null" name="trackingCodeTypeId" title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}" tooltip="${uiLabelMap.CommonNotModifRecreat}" widget-style="tabletext"><display/></field>
> -        <field use-when="trackingCodeType==null&amp;&amp;trackingCodeTypeId==null" name="trackingCodeTypeId" title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}"><§text/></field>
> +        <field use-when="trackingCodeType==null&amp;&amp;trackingCodeTypeId==null" name="trackingCodeTypeId" title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}"><text/></field>
>          <field use-when="trackingCodeType==null&amp;&amp;trackingCodeTypeId!=null" name="trackingCodeTypeId" title="${uiLabelMap.TrackingCodeTrackingCodeTypeId}" tooltip="${uiLabelMap.CommonCannotBeFound}: [${trackingCodeTypeId}]" widget-style="tabletext"><display/></field>
>  
>          <field name="description" widget-style="inputBox" title="${uiLabelMap.TrackingCodeTypeDescription}"><text/></field>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.