[jira] Created: (OFBIZ-3011) getPartyNameForDate do not specify the type when comparing timestamps

[Nicolas Malin (Jira)]

getPartyNameForDate do not specify the type when comparing timestamps
---------------------------------------------------------------------

                 Key: OFBIZ-3011
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3011
             Project: OFBiz
          Issue Type: Bug
          Components: party
    Affects Versions: Release Branch 9.04, SVN trunk
            Reporter: Wickersheimer Jeremy
            Priority: Minor
             Fix For: Release Branch 9.04, SVN trunk


The getPartyNameForDate do not specify the type when comparing timestamps, the code is then falling back to their string conversion which may not work when using localized date string representations.
In general, other timestamp compare do specify the type so it is also for consistency.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-3011:
----------------------------------------

    Attachment: getPartyNameForDate.patch

> getPartyNameForDate do not specify the type when comparing timestamps
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3011
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3011
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: getPartyNameForDate.patch
>
>
> The getPartyNameForDate do not specify the type when comparing timestamps, the code is then falling back to their string conversion which may not work when using localized date string representations.
> In general, other timestamp compare do specify the type so it is also for consistency.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reassigned OFBIZ-3011:
---------------------------------

    Assignee: Scott Gray

> getPartyNameForDate do not specify the type when comparing timestamps
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3011
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3011
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Scott Gray
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: getPartyNameForDate.patch
>
>
> The getPartyNameForDate do not specify the type when comparing timestamps, the code is then falling back to their string conversion which may not work when using localized date string representations.
> In general, other timestamp compare do specify the type so it is also for consistency.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray closed OFBIZ-3011.
-----------------------------

    Resolution: Fixed

Thanks Jeremy, fixed in trunk r823406 and 9.04 r823407

> getPartyNameForDate do not specify the type when comparing timestamps
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3011
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3011
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Scott Gray
>            Priority: Minor
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: getPartyNameForDate.patch
>
>
> The getPartyNameForDate do not specify the type when comparing timestamps, the code is then falling back to their string conversion which may not work when using localized date string representations.
> In general, other timestamp compare do specify the type so it is also for consistency.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.