[jira] Created: (OFBIZ-3247) State field is missing - Not in List or N/A

[Nicolas Malin (Jira)]

State field is missing - Not in List or N/A
-------------------------------------------

                 Key: OFBIZ-3247
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3247
             Project: OFBiz
          Issue Type: Bug
          Components: party
    Affects Versions: SVN trunk
            Reporter: Sam Hamilton
            Priority: Trivial


When you are creating an employee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sam Hamilton updated OFBIZ-3247:
--------------------------------

    Description:
When you are creating an employee on https://demo.ofbiz.org/partymgr/control/NewEmployee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time.


  was:When you are creating an employee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time.

> State field is missing - Not in List or N/A
> -------------------------------------------
>
>                 Key: OFBIZ-3247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3247
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Priority: Trivial
>
> When you are creating an employee on https://demo.ofbiz.org/partymgr/control/NewEmployee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ankit Jain updated OFBIZ-3247:
------------------------------

    Attachment: OFBIZ-3247.patch

Hello Sam,

The "Not Applicable" is present in the entity "Geo" but its not present in the State drop-down, because the fetching was done on the constraint which is  fetch all GeoIds having GeoTypeId in "STATE, PROVINCE", and the _NA_ dont have any GeoTypeId, so its not there.  

You can just add an <option> tag and give the value hard coded. So i dont think that its a bug anymore.

But here is the patch which can solve the issue.

Thanks & Regards
Ankit Jain :)

> State field is missing - Not in List or N/A
> -------------------------------------------
>
>                 Key: OFBIZ-3247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3247
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Priority: Trivial
>         Attachments: OFBIZ-3247.patch
>
>
> When you are creating an employee on https://demo.ofbiz.org/partymgr/control/NewEmployee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900628#action_12900628 ]

Jacques Le Roux commented on OFBIZ-3247:
----------------------------------------

Also you might be interested by the dependent dropdwon example I recently put in the Component Example... I hope to use it more, for instance in Price and Promo Rules ...

> State field is missing - Not in List or N/A
> -------------------------------------------
>
>                 Key: OFBIZ-3247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3247
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Priority: Trivial
>         Attachments: OFBIZ-3247.patch
>
>
> When you are creating an employee on https://demo.ofbiz.org/partymgr/control/NewEmployee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900630#action_12900630 ]

Jacques Le Roux commented on OFBIZ-3247:
----------------------------------------

Sam,

Please let us know if you agree with Ankit. We will then commit Ankit's patch (sorry too busy today to have a deeper look)

> State field is missing - Not in List or N/A
> -------------------------------------------
>
>                 Key: OFBIZ-3247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3247
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Priority: Trivial
>         Attachments: OFBIZ-3247.patch
>
>
> When you are creating an employee on https://demo.ofbiz.org/partymgr/control/NewEmployee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901682#action_12901682 ]

Sam Hamilton commented on OFBIZ-3247:
-------------------------------------

Yes the patch idea looks good - just not sure if the option should have been done there or in the geo xml?

> State field is missing - Not in List or N/A
> -------------------------------------------
>
>                 Key: OFBIZ-3247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3247
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Priority: Trivial
>         Attachments: OFBIZ-3247.patch
>
>
> When you are creating an employee on https://demo.ofbiz.org/partymgr/control/NewEmployee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3247:
-----------------------------------

    Issue Type: Improvement  (was: Bug)

> State field is missing - Not in List or N/A
> -------------------------------------------
>
>                 Key: OFBIZ-3247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3247
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Priority: Trivial
>         Attachments: OFBIZ-3247.patch
>
>
> When you are creating an employee on https://demo.ofbiz.org/partymgr/control/NewEmployee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux resolved OFBIZ-3247.
------------------------------------

         Assignee: Jacques Le Roux
    Fix Version/s: SVN trunk
       Resolution: Fixed

Thanks Sam,

As Ankit explained, as we can't have and OR constraint in entity-constraint (but using IN or BETWEEN operators) and as we have already <Geo abbreviation="_NA_" geoCode="_NA_" geoId="_NA_" geoName="Not Applicable"/> in GeoData.xml and it would not make sense to have it for countries, states, provinces, etc. So I believe Ankit's solution would the best we can have in this case.

But I finally decided to use the new Dependent Dropdowns mechanim. It's commited at r988508 in trunk. As I don't consider this a bug, I don't backported anywhere.

Also note Sam that, even if the redirect should continue to work, the real ULR is now https://demo-trunk.ofbiz.apache.org:8443/partymgr/control/NewEmployee

> State field is missing - Not in List or N/A
> -------------------------------------------
>
>                 Key: OFBIZ-3247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3247
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3247.patch
>
>
> When you are creating an employee on https://demo.ofbiz.org/partymgr/control/NewEmployee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901907#action_12901907 ]

Sam Hamilton commented on OFBIZ-3247:
-------------------------------------

Brilliant - many thanks to all!

Sam

> State field is missing - Not in List or N/A
> -------------------------------------------
>
>                 Key: OFBIZ-3247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3247
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3247.patch
>
>
> When you are creating an employee on https://demo.ofbiz.org/partymgr/control/NewEmployee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sam Hamilton closed OFBIZ-3247.
-------------------------------

> State field is missing - Not in List or N/A
> -------------------------------------------
>
>                 Key: OFBIZ-3247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3247
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3247.patch
>
>
> When you are creating an employee on https://demo.ofbiz.org/partymgr/control/NewEmployee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902939#action_12902939 ]

Jacques Le Roux commented on OFBIZ-3247:
----------------------------------------

Oops, I just fixed a pitiful bug at r989829

> State field is missing - Not in List or N/A
> -------------------------------------------
>
>                 Key: OFBIZ-3247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3247
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3247.patch
>
>
> When you are creating an employee on https://demo.ofbiz.org/partymgr/control/NewEmployee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903207#action_12903207 ]

Ankit Jain commented on OFBIZ-3247:
-----------------------------------

Hi Jacques,

I checked at the demo site the State dropdown disappears as the page loads, and no result of selecting any country too, i think dependent select is not working here or may be something else.


Ankit Jain :)

> State field is missing - Not in List or N/A
> -------------------------------------------
>
>                 Key: OFBIZ-3247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3247
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3247.patch
>
>
> When you are creating an employee on https://demo.ofbiz.org/partymgr/control/NewEmployee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903281#action_12903281 ]

Jacques Le Roux commented on OFBIZ-3247:
----------------------------------------

Hi Ankit,

Actually it works well. I fixed a silly bug yesterday evening at r989829. You certainly tested before, or did you find another issue? Could you retry, and if you can reproduce give more details?

Thanks

> State field is missing - Not in List or N/A
> -------------------------------------------
>
>                 Key: OFBIZ-3247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3247
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3247.patch
>
>
> When you are creating an employee on https://demo.ofbiz.org/partymgr/control/NewEmployee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903359#action_12903359 ]

Ankit Jain commented on OFBIZ-3247:
-----------------------------------

Hi Jacques,

I have checked it again at https://demo-trunk.ofbiz.apache.org:8443/partymgr/control/NewEmployee and i found the same behaviour as i mentioned above. Is it possible the site is not updated?


Ankit Jain :)

> State field is missing - Not in List or N/A
> -------------------------------------------
>
>                 Key: OFBIZ-3247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3247
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3247.patch
>
>
> When you are creating an employee on https://demo.ofbiz.org/partymgr/control/NewEmployee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3247:
-----------------------------------

    Attachment: Australia.jpg

Ankit,

It works on demo trunk, try Australia, USA, Canada, those who have states or provinces defined in seed. If you switch to a country w/out states it show "no states" and slowly dissapear...

> State field is missing - Not in List or N/A
> -------------------------------------------
>
>                 Key: OFBIZ-3247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3247
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: Australia.jpg, OFBIZ-3247.patch
>
>
> When you are creating an employee on https://demo.ofbiz.org/partymgr/control/NewEmployee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903372#action_12903372 ]

Ankit Jain commented on OFBIZ-3247:
-----------------------------------

Yes Jacques its working i dont know about this that it will disappear when there is no states of the country.

Thanks
Ankit Jain:)

> State field is missing - Not in List or N/A
> -------------------------------------------
>
>                 Key: OFBIZ-3247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3247
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: Australia.jpg, OFBIZ-3247.patch
>
>
> When you are creating an employee on https://demo.ofbiz.org/partymgr/control/NewEmployee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903377#action_12903377 ]

Jacques Le Roux commented on OFBIZ-3247:
----------------------------------------

That was my choice, it could be parametrized...

> State field is missing - Not in List or N/A
> -------------------------------------------
>
>                 Key: OFBIZ-3247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3247
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: Australia.jpg, OFBIZ-3247.patch
>
>
> When you are creating an employee on https://demo.ofbiz.org/partymgr/control/NewEmployee there is no field in the drop down box for Not Applicable, just in case you cant find the state you wanted, I was trying to find an English counties at the time.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.