[jira] Created: (OFBIZ-3904) Bug in calling methods defined in Usps Services

[Nicolas Malin (Jira)]

Bug in calling methods defined in Usps Services
-----------------------------------------------

                 Key: OFBIZ-3904
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3904
             Project: OFBiz
          Issue Type: Bug
          Components: product
            Reporter: Vivek Mishra
             Fix For: Release Branch 10.04, SVN trunk


Calling "getPackageSplit" & "calcPackageWeight" methods from outside of the class causes compilation error, as their access modifiers are private.
So fixing this bug, following points are covered in this commit.

1) Moving "getPackageSplit" and "calcPackageWeight" from UspsServices.java to ShipmentWorker.java. They are not Usps third party related methods.
2) Changing access modifiers of these methods to public.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vivek Mishra updated OFBIZ-3904:
--------------------------------

    Attachment: OFBIZ-3904.patch

Here is the patch for the same.

> Bug in calling methods defined in Usps Services
> -----------------------------------------------
>
>                 Key: OFBIZ-3904
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3904
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Vivek Mishra
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-3904.patch
>
>
> Calling "getPackageSplit" & "calcPackageWeight" methods from outside of the class causes compilation error, as their access modifiers are private.
> So fixing this bug, following points are covered in this commit.
> 1) Moving "getPackageSplit" and "calcPackageWeight" from UspsServices.java to ShipmentWorker.java. They are not Usps third party related methods.
> 2) Changing access modifiers of these methods to public.

... [show rest of quote]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-3904:
------------------------------------------

    Assignee: Ashish Vijaywargiya

> Bug in calling methods defined in Usps Services
> -----------------------------------------------
>
>                 Key: OFBIZ-3904
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3904
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Vivek Mishra
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-3904.patch
>
>
> Calling "getPackageSplit" & "calcPackageWeight" methods from outside of the class causes compilation error, as their access modifiers are private.
> So fixing this bug, following points are covered in this commit.
> 1) Moving "getPackageSplit" and "calcPackageWeight" from UspsServices.java to ShipmentWorker.java. They are not Usps third party related methods.
> 2) Changing access modifiers of these methods to public.

... [show rest of quote]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-3904.
--------------------------------------

    Resolution: Fixed

Thanks Vivek for the contribution - committed in trunk at r990127 & ReleaseBranch 10.04 at r990130.

--
Ashish

> Bug in calling methods defined in Usps Services
> -----------------------------------------------
>
>                 Key: OFBIZ-3904
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3904
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Vivek Mishra
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-3904.patch
>
>
> Calling "getPackageSplit" & "calcPackageWeight" methods from outside of the class causes compilation error, as their access modifiers are private.
> So fixing this bug, following points are covered in this commit.
> 1) Moving "getPackageSplit" and "calcPackageWeight" from UspsServices.java to ShipmentWorker.java. They are not Usps third party related methods.
> 2) Changing access modifiers of these methods to public.

... [show rest of quote]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903417#action_12903417 ]

Vivek Mishra commented on OFBIZ-3904:
-------------------------------------

Thanks Ashish.

> Bug in calling methods defined in Usps Services
> -----------------------------------------------
>
>                 Key: OFBIZ-3904
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3904
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Vivek Mishra
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-3904.patch
>
>
> Calling "getPackageSplit" & "calcPackageWeight" methods from outside of the class causes compilation error, as their access modifiers are private.
> So fixing this bug, following points are covered in this commit.
> 1) Moving "getPackageSplit" and "calcPackageWeight" from UspsServices.java to ShipmentWorker.java. They are not Usps third party related methods.
> 2) Changing access modifiers of these methods to public.

... [show rest of quote]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.