[jira] Created: (OFBIZ-3724) Copying WorkEffortCostCalc as part of a ProductionRun
Locked
[jira] Created: (OFBIZ-3724) Copying WorkEffortCostCalc as part of a ProductionRun
 
|
Copying WorkEffortCostCalc as part of a ProductionRun
----------------------------------------------------- Key: OFBIZ-3724 URL: https://issues.apache.org/jira/browse/OFBIZ-3724 Project: OFBiz Issue Type: Improvement Components: manufacturing Affects Versions: SVN trunk Reporter: Bob Morley Fix For: SVN trunk Attachments: OFBIZ-3724_CloneWorkEffortCostCalc.patch Currently when a ProductionRun is created the WorkEffortCostCalc relations are not cloned from the routing tasks. This results in not being able to change the CostCalc as part of a ProductionRun unless you were to change the routing task template for all production runs. As part of reviewing this patch I would like two things to be considered -- I created this patch which includes an enhancement to the production run unit tests to test for the creation of these newly cloned relationships. 1) createWorkEffortCostCalc service requires ACCOUNTING_CREATE permission; this does not feel right -- it caused me to add that permission into the sample user/security group to execute the services. I wonder if these services should be in the WorkEffort component with appropriate work effort permission. 2) migration concerns -- if people have existing production runs in place, the new createProductionRunTaskCosts will not pickup the cost calcs that were not copied. Rather than put "backwards compatible" code in, I would prefer (if we want to handle this) to create a service that performs this clone on non-completed/closed production runs that is executed as part of a migration. Would like community discussion on this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3724) Copying WorkEffortCostCalc as part of a ProductionRun
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bob Morley updated OFBIZ-3724: ------------------------------ Attachment: OFBIZ-3724_CloneWorkEffortCostCalc.patch > Copying WorkEffortCostCalc as part of a ProductionRun > ----------------------------------------------------- > > Key: OFBIZ-3724 > URL: https://issues.apache.org/jira/browse/OFBIZ-3724 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing > Affects Versions: SVN trunk > Reporter: Bob Morley > Fix For: SVN trunk > > Attachments: OFBIZ-3724_CloneWorkEffortCostCalc.patch > > > Currently when a ProductionRun is created the WorkEffortCostCalc relations are not cloned from the routing tasks. This results in not being able to change the CostCalc as part of a ProductionRun unless you were to change the routing task template for all production runs. As part of reviewing this patch I would like two things to be considered -- > I created this patch which includes an enhancement to the production run unit tests to test for the creation of these newly cloned relationships. > 1) createWorkEffortCostCalc service requires ACCOUNTING_CREATE permission; this does not feel right -- it caused me to add that permission into the sample user/security group to execute the services. I wonder if these services should be in the WorkEffort component with appropriate work effort permission. > 2) migration concerns -- if people have existing production runs in place, the new createProductionRunTaskCosts will not pickup the cost calcs that were not copied. Rather than put "backwards compatible" code in, I would prefer (if we want to handle this) to create a service that performs this clone on non-completed/closed production runs that is executed as part of a migration. Would like community discussion on this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3724) Copying WorkEffortCostCalc as part of a ProductionRun
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858640#action_12858640 ] BJ Freeman commented on OFBIZ-3724: ----------------------------------- #1` I believe Jacopo talked about changing process that did not have user interaction to system permissions. #2 I agree > Copying WorkEffortCostCalc as part of a ProductionRun > ----------------------------------------------------- > > Key: OFBIZ-3724 > URL: https://issues.apache.org/jira/browse/OFBIZ-3724 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing > Affects Versions: SVN trunk > Reporter: Bob Morley > Fix For: SVN trunk > > Attachments: OFBIZ-3724_CloneWorkEffortCostCalc.patch > > > Currently when a ProductionRun is created the WorkEffortCostCalc relations are not cloned from the routing tasks. This results in not being able to change the CostCalc as part of a ProductionRun unless you were to change the routing task template for all production runs. As part of reviewing this patch I would like two things to be considered -- > I created this patch which includes an enhancement to the production run unit tests to test for the creation of these newly cloned relationships. > 1) createWorkEffortCostCalc service requires ACCOUNTING_CREATE permission; this does not feel right -- it caused me to add that permission into the sample user/security group to execute the services. I wonder if these services should be in the WorkEffort component with appropriate work effort permission. > 2) migration concerns -- if people have existing production runs in place, the new createProductionRunTaskCosts will not pickup the cost calcs that were not copied. Rather than put "backwards compatible" code in, I would prefer (if we want to handle this) to create a service that performs this clone on non-completed/closed production runs that is executed as part of a migration. Would like community discussion on this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3724) Copying WorkEffortCostCalc as part of a ProductionRun
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858762#action_12858762 ] Jacopo Cappellato commented on OFBIZ-3724: ------------------------------------------ I am going to review (and commit) your patch today but in the meantime here are my comments for your two points: 1) the change you did is fine; btw the accounting permissions will be no more required as soon as the accounting secas will be executed using the run-as-user="system" permission (change that is in my todo list) 2) it would be ideal to write this migration script; I agree with you it is a better solution than a "backward (but awkward) compatible" solution > Copying WorkEffortCostCalc as part of a ProductionRun > ----------------------------------------------------- > > Key: OFBIZ-3724 > URL: https://issues.apache.org/jira/browse/OFBIZ-3724 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing > Affects Versions: SVN trunk > Reporter: Bob Morley > Fix For: SVN trunk > > Attachments: OFBIZ-3724_CloneWorkEffortCostCalc.patch > > > Currently when a ProductionRun is created the WorkEffortCostCalc relations are not cloned from the routing tasks. This results in not being able to change the CostCalc as part of a ProductionRun unless you were to change the routing task template for all production runs. As part of reviewing this patch I would like two things to be considered -- > I created this patch which includes an enhancement to the production run unit tests to test for the creation of these newly cloned relationships. > 1) createWorkEffortCostCalc service requires ACCOUNTING_CREATE permission; this does not feel right -- it caused me to add that permission into the sample user/security group to execute the services. I wonder if these services should be in the WorkEffort component with appropriate work effort permission. > 2) migration concerns -- if people have existing production runs in place, the new createProductionRunTaskCosts will not pickup the cost calcs that were not copied. Rather than put "backwards compatible" code in, I would prefer (if we want to handle this) to create a service that performs this clone on non-completed/closed production runs that is executed as part of a migration. Would like community discussion on this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-3724) Copying WorkEffortCostCalc as part of a ProductionRun
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-3724: ---------------------------------------- Assignee: Jacopo Cappellato > Copying WorkEffortCostCalc as part of a ProductionRun > ----------------------------------------------------- > > Key: OFBIZ-3724 > URL: https://issues.apache.org/jira/browse/OFBIZ-3724 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing > Affects Versions: SVN trunk > Reporter: Bob Morley > Assignee: Jacopo Cappellato > Fix For: SVN trunk > > Attachments: OFBIZ-3724_CloneWorkEffortCostCalc.patch > > > Currently when a ProductionRun is created the WorkEffortCostCalc relations are not cloned from the routing tasks. This results in not being able to change the CostCalc as part of a ProductionRun unless you were to change the routing task template for all production runs. As part of reviewing this patch I would like two things to be considered -- > I created this patch which includes an enhancement to the production run unit tests to test for the creation of these newly cloned relationships. > 1) createWorkEffortCostCalc service requires ACCOUNTING_CREATE permission; this does not feel right -- it caused me to add that permission into the sample user/security group to execute the services. I wonder if these services should be in the WorkEffort component with appropriate work effort permission. > 2) migration concerns -- if people have existing production runs in place, the new createProductionRunTaskCosts will not pickup the cost calcs that were not copied. Rather than put "backwards compatible" code in, I would prefer (if we want to handle this) to create a service that performs this clone on non-completed/closed production runs that is executed as part of a migration. Would like community discussion on this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3724) Copying WorkEffortCostCalc as part of a ProductionRun
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858951#action_12858951 ] Jacopo Cappellato commented on OFBIZ-3724: ------------------------------------------ Bob, your patch is in rev.935969 I have also added some comments for upgrading in https://cwiki.apache.org/confluence/display/OFBTECH/Revisions+Requiring+Data+Migration It should be enough for now, but if you will create a migration service that would be great and I will commit it as well. Thank you. > Copying WorkEffortCostCalc as part of a ProductionRun > ----------------------------------------------------- > > Key: OFBIZ-3724 > URL: https://issues.apache.org/jira/browse/OFBIZ-3724 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing > Affects Versions: SVN trunk > Reporter: Bob Morley > Assignee: Jacopo Cappellato > Fix For: SVN trunk > > Attachments: OFBIZ-3724_CloneWorkEffortCostCalc.patch > > > Currently when a ProductionRun is created the WorkEffortCostCalc relations are not cloned from the routing tasks. This results in not being able to change the CostCalc as part of a ProductionRun unless you were to change the routing task template for all production runs. As part of reviewing this patch I would like two things to be considered -- > I created this patch which includes an enhancement to the production run unit tests to test for the creation of these newly cloned relationships. > 1) createWorkEffortCostCalc service requires ACCOUNTING_CREATE permission; this does not feel right -- it caused me to add that permission into the sample user/security group to execute the services. I wonder if these services should be in the WorkEffort component with appropriate work effort permission. > 2) migration concerns -- if people have existing production runs in place, the new createProductionRunTaskCosts will not pickup the cost calcs that were not copied. Rather than put "backwards compatible" code in, I would prefer (if we want to handle this) to create a service that performs this clone on non-completed/closed production runs that is executed as part of a migration. Would like community discussion on this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3724) Copying WorkEffortCostCalc as part of a ProductionRun
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858964#action_12858964 ] Bob Morley commented on OFBIZ-3724: ----------------------------------- Will do -- I have created a new ticket that will ultimately have that patch -- OFBIZ-3727. > Copying WorkEffortCostCalc as part of a ProductionRun > ----------------------------------------------------- > > Key: OFBIZ-3724 > URL: https://issues.apache.org/jira/browse/OFBIZ-3724 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing > Affects Versions: SVN trunk > Reporter: Bob Morley > Assignee: Jacopo Cappellato > Fix For: SVN trunk > > Attachments: OFBIZ-3724_CloneWorkEffortCostCalc.patch > > > Currently when a ProductionRun is created the WorkEffortCostCalc relations are not cloned from the routing tasks. This results in not being able to change the CostCalc as part of a ProductionRun unless you were to change the routing task template for all production runs. As part of reviewing this patch I would like two things to be considered -- > I created this patch which includes an enhancement to the production run unit tests to test for the creation of these newly cloned relationships. > 1) createWorkEffortCostCalc service requires ACCOUNTING_CREATE permission; this does not feel right -- it caused me to add that permission into the sample user/security group to execute the services. I wonder if these services should be in the WorkEffort component with appropriate work effort permission. > 2) migration concerns -- if people have existing production runs in place, the new createProductionRunTaskCosts will not pickup the cost calcs that were not copied. Rather than put "backwards compatible" code in, I would prefer (if we want to handle this) to create a service that performs this clone on non-completed/closed production runs that is executed as part of a migration. Would like community discussion on this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-3724) Copying WorkEffortCostCalc as part of a ProductionRun
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-3724. ------------------------------------ Resolution: Fixed > Copying WorkEffortCostCalc as part of a ProductionRun > ----------------------------------------------------- > > Key: OFBIZ-3724 > URL: https://issues.apache.org/jira/browse/OFBIZ-3724 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing > Affects Versions: SVN trunk > Reporter: Bob Morley > Assignee: Jacopo Cappellato > Fix For: SVN trunk > > Attachments: OFBIZ-3724_CloneWorkEffortCostCalc.patch > > > Currently when a ProductionRun is created the WorkEffortCostCalc relations are not cloned from the routing tasks. This results in not being able to change the CostCalc as part of a ProductionRun unless you were to change the routing task template for all production runs. As part of reviewing this patch I would like two things to be considered -- > I created this patch which includes an enhancement to the production run unit tests to test for the creation of these newly cloned relationships. > 1) createWorkEffortCostCalc service requires ACCOUNTING_CREATE permission; this does not feel right -- it caused me to add that permission into the sample user/security group to execute the services. I wonder if these services should be in the WorkEffort component with appropriate work effort permission. > 2) migration concerns -- if people have existing production runs in place, the new createProductionRunTaskCosts will not pickup the cost calcs that were not copied. Rather than put "backwards compatible" code in, I would prefer (if we want to handle this) to create a service that performs this clone on non-completed/closed production runs that is executed as part of a migration. Would like community discussion on this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |