[jira] Created: (OFBIZ-3888) After visiting checkoutreview addcart does not work

[Nicolas Malin (Jira)]

After visiting checkoutreview addcart does not work
---------------------------------------------------

                 Key: OFBIZ-3888
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3888
             Project: OFBiz
          Issue Type: Bug
          Components: specialpurpose/ecommerce
    Affects Versions: Release Branch 10.04
         Environment: Demo Server
            Reporter: Brent Dykgraaf


I have reproduced on the demo server.
- add a few items to the cart
- proceed to checkout, go through the three screens to the checkoutreview screen.
- click on main to get out of it and try to add another item.
- screen directs to one of the checkout screens. Add cart no longer works.

I may be able to fix if someone can give me some pointers were to look.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897198#action_12897198 ]

Scott Gray commented on OFBIZ-3888:
-----------------------------------

You may have to give more detailed steps, I tried this on demo-trunk and on demo-stable and it seems to have correctly added to the cart in both cases.

> After visiting checkoutreview addcart does not work
> ---------------------------------------------------
>
>                 Key: OFBIZ-3888
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3888
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release Branch 10.04
>         Environment: Demo Server
>            Reporter: Brent Dykgraaf
>
> I have reproduced on the demo server.
> - add a few items to the cart
> - proceed to checkout, go through the three screens to the checkoutreview screen.
> - click on main to get out of it and try to add another item.
> - screen directs to one of the checkout screens. Add cart no longer works.
> I may be able to fix if someone can give me some pointers were to look.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897520#action_12897520 ]

Brent Dykgraaf commented on OFBIZ-3888:
---------------------------------------

These are the steps to reproduce on the demo-trunk. Also happens on demo-stable.
goto host/ecommerce/
click BrowseCategories/Drop Ship Products
Add 2x dropship1 with addcart button
Click Checkout in minicart
Use l: admin p:ofbiz in login screen
Click next on checkoutoptions screen
select no shipping, click next
select cod, click continue to final order
click on main from this screen
click BrowseCategories/Drop Ship Products
click addcart button

If you logout cart will work again.

> After visiting checkoutreview addcart does not work
> ---------------------------------------------------
>
>                 Key: OFBIZ-3888
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3888
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release Branch 10.04
>         Environment: Demo Server
>            Reporter: Brent Dykgraaf
>
> I have reproduced on the demo server.
> - add a few items to the cart
> - proceed to checkout, go through the three screens to the checkoutreview screen.
> - click on main to get out of it and try to add another item.
> - screen directs to one of the checkout screens. Add cart no longer works.
> I may be able to fix if someone can give me some pointers were to look.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897529#action_12897529 ]

Scott Gray commented on OFBIZ-3888:
-----------------------------------

Thanks Brent, it still works for me though.  

After leaving the final review I added an additional dropship1 to the cart which took my total to three and it landed me back on the shipping address checkout page, I went through the steps and created the order.

> After visiting checkoutreview addcart does not work
> ---------------------------------------------------
>
>                 Key: OFBIZ-3888
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3888
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release Branch 10.04
>         Environment: Demo Server
>            Reporter: Brent Dykgraaf
>
> I have reproduced on the demo server.
> - add a few items to the cart
> - proceed to checkout, go through the three screens to the checkoutreview screen.
> - click on main to get out of it and try to add another item.
> - screen directs to one of the checkout screens. Add cart no longer works.
> I may be able to fix if someone can give me some pointers were to look.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897540#action_12897540 ]

Brent Dykgraaf commented on OFBIZ-3888:
---------------------------------------

Thanks for your help Scott, much appreciated.

Sounds like that is the behaviour I am talking about.

Maybe this is intentional then. I thought the behaviour would be consistent where you need to addcart and then click checkout to get back to the shipping address.

> After visiting checkoutreview addcart does not work
> ---------------------------------------------------
>
>                 Key: OFBIZ-3888
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3888
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release Branch 10.04
>         Environment: Demo Server
>            Reporter: Brent Dykgraaf
>
> I have reproduced on the demo server.
> - add a few items to the cart
> - proceed to checkout, go through the three screens to the checkoutreview screen.
> - click on main to get out of it and try to add another item.
> - screen directs to one of the checkout screens. Add cart no longer works.
> I may be able to fix if someone can give me some pointers were to look.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897550#action_12897550 ]

Scott Gray commented on OFBIZ-3888:
-----------------------------------

Ah okay, I probably should have asked what you meant by "does not work".

Whether it is intentional or a side effect of something else is another question.  I agree that it should probably behave as though you had never gone through the checkout steps i.e. either return you to the product page or the shopping cart after the add.

Solving it would involve finding out why it's behaving differently and then finding a fix that doesn't break anything else.  Best bet would be to follow the additem execution path and figure out where the view to display is decided upon.

> After visiting checkoutreview addcart does not work
> ---------------------------------------------------
>
>                 Key: OFBIZ-3888
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3888
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release Branch 10.04
>         Environment: Demo Server
>            Reporter: Brent Dykgraaf
>
> I have reproduced on the demo server.
> - add a few items to the cart
> - proceed to checkout, go through the three screens to the checkoutreview screen.
> - click on main to get out of it and try to add another item.
> - screen directs to one of the checkout screens. Add cart no longer works.
> I may be able to fix if someone can give me some pointers were to look.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898078#action_12898078 ]

Brent Dykgraaf commented on OFBIZ-3888:
---------------------------------------

Figured it out. checkoutoptions has save-last-view

<request-map uri="checkoutoptions">
      <security https="true" auth="true"/>
      <event type="java" path="org.ofbiz.order.shoppingcart.CheckOutEvents" invoke="setCheckOutPages"/>
      <response name="shippingaddress" type="view" value="checkoutshippingaddress" save-current-view="true"/>

additem has view-last.
    <request-map uri="additem">
        <security https="false" auth="false"/>
        <event type="java" path="org.ofbiz.order.shoppingcart.ShoppingCartEvents" invoke="addToCart"/>
        <response name="success" type="view-last" value="showcart"/>

Setting save-last-view = false gets my desired behaviour.

> After visiting checkoutreview addcart does not work
> ---------------------------------------------------
>
>                 Key: OFBIZ-3888
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3888
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release Branch 10.04
>         Environment: Demo Server
>            Reporter: Brent Dykgraaf
>
> I have reproduced on the demo server.
> - add a few items to the cart
> - proceed to checkout, go through the three screens to the checkoutreview screen.
> - click on main to get out of it and try to add another item.
> - screen directs to one of the checkout screens. Add cart no longer works.
> I may be able to fix if someone can give me some pointers were to look.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brent Dykgraaf resolved OFBIZ-3888.
-----------------------------------

    Resolution: Not A Problem

> After visiting checkoutreview addcart does not work
> ---------------------------------------------------
>
>                 Key: OFBIZ-3888
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3888
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release Branch 10.04
>         Environment: Demo Server
>            Reporter: Brent Dykgraaf
>
> I have reproduced on the demo server.
> - add a few items to the cart
> - proceed to checkout, go through the three screens to the checkoutreview screen.
> - click on main to get out of it and try to add another item.
> - screen directs to one of the checkout screens. Add cart no longer works.
> I may be able to fix if someone can give me some pointers were to look.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3888.
----------------------------------

    Assignee: Scott Gray

> After visiting checkoutreview addcart does not work
> ---------------------------------------------------
>
>                 Key: OFBIZ-3888
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3888
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release Branch 10.04
>         Environment: Demo Server
>            Reporter: Brent Dykgraaf
>            Assignee: Scott Gray
>
> I have reproduced on the demo server.
> - add a few items to the cart
> - proceed to checkout, go through the three screens to the checkoutreview screen.
> - click on main to get out of it and try to add another item.
> - screen directs to one of the checkout screens. Add cart no longer works.
> I may be able to fix if someone can give me some pointers were to look.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.