When editing Portal Pages, Drag & Drop for Portlets does not work
----------------------------------------------------------------- Key: OFBIZ-3889 URL: https://issues.apache.org/jira/browse/OFBIZ-3889 Project: OFBiz Issue Type: Bug Components: framework, specialpurpose/myportal Affects Versions: Release Branch 10.04, SVN trunk Reporter: Karl Pitrich Priority: Minor Attachments: fixPortalDnD.diff When editing Portlet Pages, either in MyPortal or PortalAdm, Drag & Drop of Portlets does not work. Where are several Issues in the MyPortal, some have fixes, none is commited to trunk. Problems: - in myportal.js, function getDestinationInformationPortlets(): DOM ID's are not handled correctly - in framework/webtools/widget/PortalAdmScreens.xml: required javascript + css files are not included -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[ https://issues.apache.org/jira/browse/OFBIZ-3889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pitrich updated OFBIZ-3889: -------------------------------- Attachment: fixPortalDnD.diff Fix for described Issues. > When editing Portal Pages, Drag & Drop for Portlets does not work > ----------------------------------------------------------------- > > Key: OFBIZ-3889 > URL: https://issues.apache.org/jira/browse/OFBIZ-3889 > Project: OFBiz > Issue Type: Bug > Components: framework, specialpurpose/myportal > Affects Versions: Release Branch 10.04, SVN trunk > Reporter: Karl Pitrich > Priority: Minor > Attachments: fixPortalDnD.diff > > > When editing Portlet Pages, either in MyPortal or PortalAdm, Drag & Drop of Portlets does not work. > Where are several Issues in the MyPortal, some have fixes, none is commited to trunk. > Problems: > - in myportal.js, function getDestinationInformationPortlets(): DOM ID's are not handled correctly > - in framework/webtools/widget/PortalAdmScreens.xml: required javascript + css files are not included -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-3889: -------------------------------------- Assignee: Jacques Le Roux > When editing Portal Pages, Drag & Drop for Portlets does not work > ----------------------------------------------------------------- > > Key: OFBIZ-3889 > URL: https://issues.apache.org/jira/browse/OFBIZ-3889 > Project: OFBiz > Issue Type: Bug > Components: framework, specialpurpose/myportal > Affects Versions: Release Branch 10.04, SVN trunk > Reporter: Karl Pitrich > Assignee: Jacques Le Roux > Priority: Minor > Attachments: fixPortalDnD.diff > > > When editing Portlet Pages, either in MyPortal or PortalAdm, Drag & Drop of Portlets does not work. > Where are several Issues in the MyPortal, some have fixes, none is commited to trunk. > Problems: > - in myportal.js, function getDestinationInformationPortlets(): DOM ID's are not handled correctly > - in framework/webtools/widget/PortalAdmScreens.xml: required javascript + css files are not included -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897354#action_12897354 ] Jacques Le Roux commented on OFBIZ-3889: ---------------------------------------- Hi Karl, Looks like this patch is not working on trunk. There are certainly others reasons as I removed all "ofbiz-official/" and "dev/hg/ofbiz/" in the file but still get conflict in PortalAdmScreens.xml. I guess it has been done on R10.04 and not trunk? > When editing Portal Pages, Drag & Drop for Portlets does not work > ----------------------------------------------------------------- > > Key: OFBIZ-3889 > URL: https://issues.apache.org/jira/browse/OFBIZ-3889 > Project: OFBiz > Issue Type: Bug > Components: framework, specialpurpose/myportal > Affects Versions: Release Branch 10.04, SVN trunk > Reporter: Karl Pitrich > Assignee: Jacques Le Roux > Priority: Minor > Attachments: fixPortalDnD.diff > > > When editing Portlet Pages, either in MyPortal or PortalAdm, Drag & Drop of Portlets does not work. > Where are several Issues in the MyPortal, some have fixes, none is commited to trunk. > Problems: > - in myportal.js, function getDestinationInformationPortlets(): DOM ID's are not handled correctly > - in framework/webtools/widget/PortalAdmScreens.xml: required javascript + css files are not included -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897396#action_12897396 ] Karl Pitrich commented on OFBIZ-3889: ------------------------------------- Hi, strange. I'm certain diff'ed against the current trunk, gut co'd it ... sorry. the only change in PortalAdmScreens.xml are the addition of these tho lines marked with +: <set field="headerItem" value="PortalPageAdminItem"/> + <set field="layoutSettings.javaScripts[]" value="/images/myportal.js" global="true"/> + <set field="layoutSettings.styleSheets[+0]" value="/images/myportal.css" global="true"/> - Karl _____________________________________________ Lusini GmbH Adams-Lehmann-Straße 109, 80797 München Mobil +49 171 4970703 E-Mail [hidden email] _____________________________________________ > When editing Portal Pages, Drag & Drop for Portlets does not work > ----------------------------------------------------------------- > > Key: OFBIZ-3889 > URL: https://issues.apache.org/jira/browse/OFBIZ-3889 > Project: OFBiz > Issue Type: Bug > Components: framework, specialpurpose/myportal > Affects Versions: Release Branch 10.04, SVN trunk > Reporter: Karl Pitrich > Assignee: Jacques Le Roux > Priority: Minor > Attachments: fixPortalDnD.diff > > > When editing Portlet Pages, either in MyPortal or PortalAdm, Drag & Drop of Portlets does not work. > Where are several Issues in the MyPortal, some have fixes, none is commited to trunk. > Problems: > - in myportal.js, function getDestinationInformationPortlets(): DOM ID's are not handled correctly > - in framework/webtools/widget/PortalAdmScreens.xml: required javascript + css files are not included -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897457#action_12897457 ] Jacques Le Roux commented on OFBIZ-3889: ---------------------------------------- OK, I tried only inside Eclipse, from Tortoise it works well... Will see that later... > When editing Portal Pages, Drag & Drop for Portlets does not work > ----------------------------------------------------------------- > > Key: OFBIZ-3889 > URL: https://issues.apache.org/jira/browse/OFBIZ-3889 > Project: OFBiz > Issue Type: Bug > Components: framework, specialpurpose/myportal > Affects Versions: Release Branch 10.04, SVN trunk > Reporter: Karl Pitrich > Assignee: Jacques Le Roux > Priority: Minor > Attachments: fixPortalDnD.diff > > > When editing Portlet Pages, either in MyPortal or PortalAdm, Drag & Drop of Portlets does not work. > Where are several Issues in the MyPortal, some have fixes, none is commited to trunk. > Problems: > - in myportal.js, function getDestinationInformationPortlets(): DOM ID's are not handled correctly > - in framework/webtools/widget/PortalAdmScreens.xml: required javascript + css files are not included -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897460#action_12897460 ] Jacques Le Roux commented on OFBIZ-3889: ---------------------------------------- BTW Karl, Could you please use rather a patch format than a diff, it's easier for us to simply apply from Eclipse. More at [Contributors Best Practices|https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices#OFBizContributorsBestPractices-HowtoSendinYourContributions(orhowtocreateandapplypatches)] Thanks > When editing Portal Pages, Drag & Drop for Portlets does not work > ----------------------------------------------------------------- > > Key: OFBIZ-3889 > URL: https://issues.apache.org/jira/browse/OFBIZ-3889 > Project: OFBiz > Issue Type: Bug > Components: framework, specialpurpose/myportal > Affects Versions: Release Branch 10.04, SVN trunk > Reporter: Karl Pitrich > Assignee: Jacques Le Roux > Priority: Minor > Attachments: fixPortalDnD.diff > > > When editing Portlet Pages, either in MyPortal or PortalAdm, Drag & Drop of Portlets does not work. > Where are several Issues in the MyPortal, some have fixes, none is commited to trunk. > Problems: > - in myportal.js, function getDestinationInformationPortlets(): DOM ID's are not handled correctly > - in framework/webtools/widget/PortalAdmScreens.xml: required javascript + css files are not included -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897648#action_12897648 ] Karl Pitrich commented on OFBIZ-3889: ------------------------------------- I promise to read the doc prior my next patch :) thank you. > When editing Portal Pages, Drag & Drop for Portlets does not work > ----------------------------------------------------------------- > > Key: OFBIZ-3889 > URL: https://issues.apache.org/jira/browse/OFBIZ-3889 > Project: OFBiz > Issue Type: Bug > Components: framework, specialpurpose/myportal > Affects Versions: Release Branch 10.04, SVN trunk > Reporter: Karl Pitrich > Assignee: Jacques Le Roux > Priority: Minor > Attachments: fixPortalDnD.diff > > > When editing Portlet Pages, either in MyPortal or PortalAdm, Drag & Drop of Portlets does not work. > Where are several Issues in the MyPortal, some have fixes, none is commited to trunk. > Problems: > - in myportal.js, function getDestinationInformationPortlets(): DOM ID's are not handled correctly > - in framework/webtools/widget/PortalAdmScreens.xml: required javascript + css files are not included -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897687#action_12897687 ] Jacques Le Roux commented on OFBIZ-3889: ---------------------------------------- You are welcome Karl > When editing Portal Pages, Drag & Drop for Portlets does not work > ----------------------------------------------------------------- > > Key: OFBIZ-3889 > URL: https://issues.apache.org/jira/browse/OFBIZ-3889 > Project: OFBiz > Issue Type: Bug > Components: framework, specialpurpose/myportal > Affects Versions: Release Branch 10.04, SVN trunk > Reporter: Karl Pitrich > Assignee: Jacques Le Roux > Priority: Minor > Attachments: fixPortalDnD.diff > > > When editing Portlet Pages, either in MyPortal or PortalAdm, Drag & Drop of Portlets does not work. > Where are several Issues in the MyPortal, some have fixes, none is commited to trunk. > Problems: > - in myportal.js, function getDestinationInformationPortlets(): DOM ID's are not handled correctly > - in framework/webtools/widget/PortalAdmScreens.xml: required javascript + css files are not included -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-3889: ----------------------------------- Attachment: OFBIZ-3889 fixPortalDnD.patch Hi Karl, Could you please give me more details? Because I see it does not work on trunk demo (though moving portlets with buttons works) but it does not work either when you change are applied. Could I miss something? BTW I have created a proper patch from your changes, maybe something did not get through? > When editing Portal Pages, Drag & Drop for Portlets does not work > ----------------------------------------------------------------- > > Key: OFBIZ-3889 > URL: https://issues.apache.org/jira/browse/OFBIZ-3889 > Project: OFBiz > Issue Type: Bug > Components: framework, specialpurpose/myportal > Affects Versions: Release Branch 10.04, SVN trunk > Reporter: Karl Pitrich > Assignee: Jacques Le Roux > Priority: Minor > Attachments: fixPortalDnD.diff, OFBIZ-3889 fixPortalDnD.patch > > > When editing Portlet Pages, either in MyPortal or PortalAdm, Drag & Drop of Portlets does not work. > Where are several Issues in the MyPortal, some have fixes, none is commited to trunk. > Problems: > - in myportal.js, function getDestinationInformationPortlets(): DOM ID's are not handled correctly > - in framework/webtools/widget/PortalAdmScreens.xml: required javascript + css files are not included -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898153#action_12898153 ] Karl Pitrich commented on OFBIZ-3889: ------------------------------------- Please hang on, I will checkout the current trunk again, apply my changes and create a new patch. _____________________________________________ Lusini GmbH Adams-Lehmann-Straße 109, 80797 München Mobil +49 171 4970703 E-Mail [hidden email] _____________________________________________ > When editing Portal Pages, Drag & Drop for Portlets does not work > ----------------------------------------------------------------- > > Key: OFBIZ-3889 > URL: https://issues.apache.org/jira/browse/OFBIZ-3889 > Project: OFBiz > Issue Type: Bug > Components: framework, specialpurpose/myportal > Affects Versions: Release Branch 10.04, SVN trunk > Reporter: Karl Pitrich > Assignee: Jacques Le Roux > Priority: Minor > Attachments: fixPortalDnD.diff, OFBIZ-3889 fixPortalDnD.patch > > > When editing Portlet Pages, either in MyPortal or PortalAdm, Drag & Drop of Portlets does not work. > Where are several Issues in the MyPortal, some have fixes, none is commited to trunk. > Problems: > - in myportal.js, function getDestinationInformationPortlets(): DOM ID's are not handled correctly > - in framework/webtools/widget/PortalAdmScreens.xml: required javascript + css files are not included -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898153#action_12898153 ] Karl Pitrich edited comment on OFBIZ-3889 at 8/13/10 6:06 AM: -------------------------------------------------------------- Please hang on, I will checkout the current trunk again, apply my changes and create a new patch. was (Author: 0xpit): Please hang on, I will checkout the current trunk again, apply my changes and create a new patch. _____________________________________________ Lusini GmbH Adams-Lehmann-Straße 109, 80797 München Mobil +49 171 4970703 E-Mail [hidden email] _____________________________________________ > When editing Portal Pages, Drag & Drop for Portlets does not work > ----------------------------------------------------------------- > > Key: OFBIZ-3889 > URL: https://issues.apache.org/jira/browse/OFBIZ-3889 > Project: OFBiz > Issue Type: Bug > Components: framework, specialpurpose/myportal > Affects Versions: Release Branch 10.04, SVN trunk > Reporter: Karl Pitrich > Assignee: Jacques Le Roux > Priority: Minor > Attachments: fixPortalDnD.diff, OFBIZ-3889 fixPortalDnD.patch > > > When editing Portlet Pages, either in MyPortal or PortalAdm, Drag & Drop of Portlets does not work. > Where are several Issues in the MyPortal, some have fixes, none is commited to trunk. > Problems: > - in myportal.js, function getDestinationInformationPortlets(): DOM ID's are not handled correctly > - in framework/webtools/widget/PortalAdmScreens.xml: required javascript + css files are not included -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pitrich updated OFBIZ-3889: -------------------------------- Attachment: OFBIZ-3889_fixPortalDnD.trunk-985143.patch Attached new patch against trunk 985143. Tested with Chrome, Safari and Firefox. > When editing Portal Pages, Drag & Drop for Portlets does not work > ----------------------------------------------------------------- > > Key: OFBIZ-3889 > URL: https://issues.apache.org/jira/browse/OFBIZ-3889 > Project: OFBiz > Issue Type: Bug > Components: framework, specialpurpose/myportal > Affects Versions: Release Branch 10.04, SVN trunk > Reporter: Karl Pitrich > Assignee: Jacques Le Roux > Priority: Minor > Attachments: fixPortalDnD.diff, OFBIZ-3889 fixPortalDnD.patch, OFBIZ-3889_fixPortalDnD.trunk-985143.patch > > > When editing Portlet Pages, either in MyPortal or PortalAdm, Drag & Drop of Portlets does not work. > Where are several Issues in the MyPortal, some have fixes, none is commited to trunk. > Problems: > - in myportal.js, function getDestinationInformationPortlets(): DOM ID's are not handled correctly > - in framework/webtools/widget/PortalAdmScreens.xml: required javascript + css files are not included -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-3889. ---------------------------------- Fix Version/s: Release Branch 10.04 SVN trunk Resolution: Fixed Thanks Karl, While working on this I have found other issues: the login.ftl files used in hhfacility and myportal were not tenant enabled. They are different but by chance in myportal very close to common so I was finally able to do both along with your changes at r985163 in trunk and r985166 in R10.04 Actually I wanted to do 2 commits but forget to uncheck the files while doing a second attempt to commit. I have updated the commit log. > When editing Portal Pages, Drag & Drop for Portlets does not work > ----------------------------------------------------------------- > > Key: OFBIZ-3889 > URL: https://issues.apache.org/jira/browse/OFBIZ-3889 > Project: OFBiz > Issue Type: Bug > Components: framework, specialpurpose/myportal > Affects Versions: Release Branch 10.04, SVN trunk > Reporter: Karl Pitrich > Assignee: Jacques Le Roux > Priority: Minor > Fix For: Release Branch 10.04, SVN trunk > > Attachments: fixPortalDnD.diff, OFBIZ-3889 fixPortalDnD.patch, OFBIZ-3889_fixPortalDnD.trunk-985143.patch > > > When editing Portlet Pages, either in MyPortal or PortalAdm, Drag & Drop of Portlets does not work. > Where are several Issues in the MyPortal, some have fixes, none is commited to trunk. > Problems: > - in myportal.js, function getDestinationInformationPortlets(): DOM ID's are not handled correctly > - in framework/webtools/widget/PortalAdmScreens.xml: required javascript + css files are not included -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Free forum by Nabble | Edit this page |