[jira] Created: (OFBIZ-3956) Accounting Map Proc - CreditCard Validation

[Nicolas Malin (Jira)]

Accounting Map Proc - CreditCard Validation
-------------------------------------------

                 Key: OFBIZ-3956
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3956
             Project: OFBiz
          Issue Type: Improvement
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Sascha Rodekamp
             Fix For: SVN trunk


A small improvement in the Accounting payment map procs.
The Credit card number was only checked if it is empty. After the patch the map proc checks if it is a valid credit card number.

Notice: I created and tested the patch with tortoise (win) applying the patch with eclipse will fail, because eclipse can't find matches in the UiLabel.xml.

Cheers
Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3956:
-----------------------------------

    Attachment: OFBIZ-3956_AccountingMapProcCreditCardValidationUpdate.patch

> Accounting Map Proc - CreditCard Validation
> -------------------------------------------
>
>                 Key: OFBIZ-3956
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3956
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3956_AccountingMapProcCreditCardValidationUpdate.patch
>
>
> A small improvement in the Accounting payment map procs.
> The Credit card number was only checked if it is empty. After the patch the map proc checks if it is a valid credit card number.
> Notice: I created and tested the patch with tortoise (win) applying the patch with eclipse will fail, because eclipse can't find matches in the UiLabel.xml.
> Cheers
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3956.
----------------------------------

      Assignee: Jacques Le Roux
    Resolution: Fixed

Thanks Sascha,

Your patch is in trunk at r1001098

BTW I had any problems with Subclipse. I updated after, maybe the reason.

> Accounting Map Proc - CreditCard Validation
> -------------------------------------------
>
>                 Key: OFBIZ-3956
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3956
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3956_AccountingMapProcCreditCardValidationUpdate.patch
>
>
> A small improvement in the Accounting payment map procs.
> The Credit card number was only checked if it is empty. After the patch the map proc checks if it is a valid credit card number.
> Notice: I created and tested the patch with tortoise (win) applying the patch with eclipse will fail, because eclipse can't find matches in the UiLabel.xml.
> Cheers
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914830#action_12914830 ]

Sascha Rodekamp commented on OFBIZ-3956:
----------------------------------------

Thanks Jacques,
hm every time when i make patches for labels i have trouble with the encoding of the file. Tried to set everything to UTF-8 but don't help. I have to figure out what's going wrong :-)

Have a good day
Sascha

> Accounting Map Proc - CreditCard Validation
> -------------------------------------------
>
>                 Key: OFBIZ-3956
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3956
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3956_AccountingMapProcCreditCardValidationUpdate.patch
>
>
> A small improvement in the Accounting payment map procs.
> The Credit card number was only checked if it is empty. After the patch the map proc checks if it is a valid credit card number.
> Notice: I created and tested the patch with tortoise (win) applying the patch with eclipse will fail, because eclipse can't find matches in the UiLabel.xml.
> Cheers
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.