[jira] Created: (OFBIZ-396) Adjustments (Promotions) not shown initialy on FinalCheckoutReview

[Nicolas Malin (Jira)]

Adjustments (Promotions) not shown initialy on FinalCheckoutReview
------------------------------------------------------------------

                 Key: OFBIZ-396
                 URL: http://issues.apache.org/jira/browse/OFBIZ-396
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: ecommerce
    Affects Versions: SVN trunk
            Reporter: Markus Studer
            Priority: Minor


On the FinalCheckoutReview Screen the adjustments (promotions) are not shown initialy. Using the Browser Reload Button to reload that page (and resubmitting the formdata) then shows the adjustments.

Had a look at the applications/ecommerce/webapp/ecommerce/WEB-INF/actions/order/checkoutreview.bsh script. The script fetches first the orderAdjustments and then the orderItems. Changing this, i.e. first the orderItems  and then the orderAdjustment fixed the problem for me (see attached patch).

I'm not sure if the suggested patch is valid as I do not fully understand the interactions between OrderItems and OrderAdjustments.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-396?page=all ]

Markus Studer updated OFBIZ-396:
--------------------------------

    Attachment: ecommerce.diff

> Adjustments (Promotions) not shown initialy on FinalCheckoutReview
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-396
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-396
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Markus Studer
>            Priority: Minor
>         Attachments: ecommerce.diff
>
>
> On the FinalCheckoutReview Screen the adjustments (promotions) are not shown initialy. Using the Browser Reload Button to reload that page (and resubmitting the formdata) then shows the adjustments.
> Had a look at the applications/ecommerce/webapp/ecommerce/WEB-INF/actions/order/checkoutreview.bsh script. The script fetches first the orderAdjustments and then the orderItems. Changing this, i.e. first the orderItems  and then the orderAdjustment fixed the problem for me (see attached patch).
> I'm not sure if the suggested patch is valid as I do not fully understand the interactions between OrderItems and OrderAdjustments.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-396?page=all ]

Jacopo Cappellato reassigned OFBIZ-396:
---------------------------------------

    Assignee: Jacopo Cappellato

> Adjustments (Promotions) not shown initialy on FinalCheckoutReview
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-396
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-396
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Markus Studer
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: ecommerce.diff
>
>
> On the FinalCheckoutReview Screen the adjustments (promotions) are not shown initialy. Using the Browser Reload Button to reload that page (and resubmitting the formdata) then shows the adjustments.
> Had a look at the applications/ecommerce/webapp/ecommerce/WEB-INF/actions/order/checkoutreview.bsh script. The script fetches first the orderAdjustments and then the orderItems. Changing this, i.e. first the orderItems  and then the orderAdjustment fixed the problem for me (see attached patch).
> I'm not sure if the suggested patch is valid as I do not fully understand the interactions between OrderItems and OrderAdjustments.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-396?page=all ]

Jacopo Cappellato closed OFBIZ-396.
-----------------------------------

    Resolution: Fixed

Thanks Markus,

your patch is in rev. 471140

Jacopo

> Adjustments (Promotions) not shown initialy on FinalCheckoutReview
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-396
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-396
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Markus Studer
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: ecommerce.diff
>
>
> On the FinalCheckoutReview Screen the adjustments (promotions) are not shown initialy. Using the Browser Reload Button to reload that page (and resubmitting the formdata) then shows the adjustments.
> Had a look at the applications/ecommerce/webapp/ecommerce/WEB-INF/actions/order/checkoutreview.bsh script. The script fetches first the orderAdjustments and then the orderItems. Changing this, i.e. first the orderItems  and then the orderAdjustment fixed the problem for me (see attached patch).
> I'm not sure if the suggested patch is valid as I do not fully understand the interactions between OrderItems and OrderAdjustments.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira