OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-3988) Redirect from Http to Https causes double service call

_‹ Previous Topic Next Topic _›

Classic

List

6 messages Options

Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-3988) Redirect from Http to Https causes double service call

Redirect from Http to Https causes double service call
------------------------------------------------------

Key: OFBIZ-3988
URL: https://issues.apache.org/jira/browse/OFBIZ-3988
Project: OFBiz
Issue Type: Bug
Components: ALL COMPONENTS
Affects Versions: SVN trunk
Reporter: Sascha Rodekamp
Fix For: SVN trunk
Attachments: OFBIZ-3988_RequestHandler.java.patch

Hi guys,

little patch a big effect :)
The problem is, when you call a request over http, but the controller wants an https request, the RequestHandler make an redirect to https (which is indeed pretty cool). But this redirect causes that Events/ Services will be called twice.

This can be avoided when we return from the Service/ Event directly after doing the redirect.

Have a good day
Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3988) Redirect from Http to Https causes double service call

[ https://issues.apache.org/jira/browse/OFBIZ-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3988:
-----------------------------------

Attachment: OFBIZ-3988_RequestHandler.java.patch

> Redirect from Http to Https causes double service call
> ------------------------------------------------------
>
> Key: OFBIZ-3988
> URL: https://issues.apache.org/jira/browse/OFBIZ-3988
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3988_RequestHandler.java.patch
>
>
> Hi guys,
> little patch a big effect :)
> The problem is, when you call a request over http, but the controller wants an https request, the RequestHandler make an redirect to https (which is indeed pretty cool). But this redirect causes that Events/ Services will be called twice.
> This can be avoided when we return from the Service/ Event directly after doing the redirect.
> Have a good day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3988) Redirect from Http to Https causes double service call

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920457#action_12920457 ]

Scott Gray commented on OFBIZ-3988:
-----------------------------------

Looks good to me

> Redirect from Http to Https causes double service call
> ------------------------------------------------------
>
> Key: OFBIZ-3988
> URL: https://issues.apache.org/jira/browse/OFBIZ-3988
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3988_RequestHandler.java.patch
>
>
> Hi guys,
> little patch a big effect :)
> The problem is, when you call a request over http, but the controller wants an https request, the RequestHandler make an redirect to https (which is indeed pretty cool). But this redirect causes that Events/ Services will be called twice.
> This can be avoided when we return from the Service/ Event directly after doing the redirect.
> Have a good day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3988) Redirect from Http to Https causes double service call

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921985#action_12921985 ]

Sascha Rodekamp commented on OFBIZ-3988:
----------------------------------------

Thanks Scott, for review!

> Redirect from Http to Https causes double service call
> ------------------------------------------------------
>
> Key: OFBIZ-3988
> URL: https://issues.apache.org/jira/browse/OFBIZ-3988
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3988_RequestHandler.java.patch
>
>
> Hi guys,
> little patch a big effect :)
> The problem is, when you call a request over http, but the controller wants an https request, the RequestHandler make an redirect to https (which is indeed pretty cool). But this redirect causes that Events/ Services will be called twice.
> This can be avoided when we return from the Service/ Event directly after doing the redirect.
> Have a good day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3988) Redirect from Http to Https causes double service call

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929086#action_12929086 ]

Jacques Le Roux commented on OFBIZ-3988:
----------------------------------------

Hi Sascha,

Have you a clear OOTB use case to test quickly test the issue and the fix?

Thanks

> Redirect from Http to Https causes double service call
> ------------------------------------------------------
>
> Key: OFBIZ-3988
> URL: https://issues.apache.org/jira/browse/OFBIZ-3988
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3988_RequestHandler.java.patch
>
>
> Hi guys,
> little patch a big effect :)
> The problem is, when you call a request over http, but the controller wants an https request, the RequestHandler make an redirect to https (which is indeed pretty cool). But this redirect causes that Events/ Services will be called twice.
> This can be avoided when we return from the Service/ Event directly after doing the redirect.
> Have a good day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3988) Redirect from Http to Https causes double service call

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930151#action_12930151 ]

Sascha Rodekamp commented on OFBIZ-3988:
----------------------------------------

Hi Jacques,

here is a example on the DEMO System:

http://demo-trunk.ofbiz.apache.org:8080/ecommerce/control/setdistributor?distributor=4711

Have a look in the log file, you will find something like:

[ RequestHandler.java:694:INFO ] Sending redirect to: [https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/setdistributor?distributor=4711], sessionId=6168538EE2980500EAC52585C21EB384.jvm1
2010-11-09 14:27:33,593 (TP-Processor31) [ ThirdPartyEvents.java:175:WARN ] Cannot associate distributor since not logged in yet
2010-11-09 14:27:33,594 (TP-Processor31) [ ThirdPartyEvents.java:175:WARN ] Cannot associate distributor since not logged in yet

ThirdPartyEvents is called twice.

Cheers
Sascha

> Redirect from Http to Https causes double service call
> ------------------------------------------------------
>
> Key: OFBIZ-3988
> URL: https://issues.apache.org/jira/browse/OFBIZ-3988
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3988_RequestHandler.java.patch
>
>
> Hi guys,
> little patch a big effect :)
> The problem is, when you call a request over http, but the controller wants an https request, the RequestHandler make an redirect to https (which is indeed pretty cool). But this redirect causes that Events/ Services will be called twice.
> This can be avoided when we return from the Service/ Event directly after doing the redirect.
> Have a good day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.