[jira] Created: (OFBIZ-4076) When audit log is enabled it creates log transacations even when there's no change

[Nicolas Malin (Jira)]

When audit log is enabled it creates log transacations even when there's no change
----------------------------------------------------------------------------------

                 Key: OFBIZ-4076
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4076
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Jeroen van der Wal
             Fix For: SVN trunk


The createEntittyAuditLogSingle function creates a record in the AuditLog entity even when there's no change. This patch only logs new, changed and deleted values. Also, all changes in the same transaction will get the same change date.




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeroen van der Wal updated OFBIZ-4076:
--------------------------------------

    Attachment: OFBIZ-4076.patch

> When audit log is enabled it creates log transacations even when there's no change
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4076
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4076
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Jeroen van der Wal
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4076.patch
>
>
> The createEntittyAuditLogSingle function creates a record in the AuditLog entity even when there's no change. This patch only logs new, changed and deleted values. Also, all changes in the same transaction will get the same change date.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeroen van der Wal updated OFBIZ-4076:
--------------------------------------

    Priority: Minor  (was: Major)

> When audit log is enabled it creates log transacations even when there's no change
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4076
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4076
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Jeroen van der Wal
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4076.patch
>
>
> The createEntittyAuditLogSingle function creates a record in the AuditLog entity even when there's no change. This patch only logs new, changed and deleted values. Also, all changes in the same transaction will get the same change date.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975479#action_12975479 ]

Jacques Le Roux commented on OFBIZ-4076:
----------------------------------------

Hi Jeroen,

Sorry, your patch looks good but is outdated (Adrian moved things this weekend, maybe the reason)

> When audit log is enabled it creates log transacations even when there's no change
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4076
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4076
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Jeroen van der Wal
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4076.patch
>
>
> The createEntittyAuditLogSingle function creates a record in the AuditLog entity even when there's no change. This patch only logs new, changed and deleted values. Also, all changes in the same transaction will get the same change date.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975488#action_12975488 ]

Jeroen van der Wal commented on OFBIZ-4076:
-------------------------------------------

Thanks Jacques,

I will provide a better patch later today.

> When audit log is enabled it creates log transacations even when there's no change
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4076
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4076
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Jeroen van der Wal
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4076.patch
>
>
> The createEntittyAuditLogSingle function creates a record in the AuditLog entity even when there's no change. This patch only logs new, changed and deleted values. Also, all changes in the same transaction will get the same change date.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeroen van der Wal updated OFBIZ-4076:
--------------------------------------

    Attachment: OFBIZ-4076-v2.patch

Here's a patch based on revision 1053569 of Ofbiz trunk. After applying this patch the overhead of the AuditEntityLog is recuded from 32% to 25%.

There's even more room for performance increase: a findOne serach for the previous entity is done for every field that's enabled.

> When audit log is enabled it creates log transacations even when there's no change
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4076
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4076
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Jeroen van der Wal
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4076-v2.patch, OFBIZ-4076.patch
>
>
> The createEntittyAuditLogSingle function creates a record in the AuditLog entity even when there's no change. This patch only logs new, changed and deleted values. Also, all changes in the same transaction will get the same change date.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4076.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Jeroen,

Your patch is in trunk at r1056973.

> When audit log is enabled it creates log transacations even when there's no change
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4076
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4076
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Jeroen van der Wal
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4076-v2.patch, OFBIZ-4076.patch
>
>
> The createEntittyAuditLogSingle function creates a record in the AuditLog entity even when there's no change. This patch only logs new, changed and deleted values. Also, all changes in the same transaction will get the same change date.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.