[jira] [Created] (OFBIZ-4344) createItemIssuanceRole and deleteItemIssuanceRole require Shipment PK parameter

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (OFBIZ-4344) createItemIssuanceRole and deleteItemIssuanceRole require Shipment PK parameter

Nicolas Malin (Jira)
createItemIssuanceRole and deleteItemIssuanceRole require Shipment PK parameter
-------------------------------------------------------------------------------

                 Key: OFBIZ-4344
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4344
             Project: OFBiz
          Issue Type: Bug
          Components: product
    Affects Versions: SVN trunk
            Reporter: Paul Foxworthy
            Priority: Minor


createItemIssuanceRole and deleteItemIssuanceRole both call checkCanChangeShipmentStatusPacked, which checks the current status of a shipment to see if anything about it can be modified.
Therefore, these services require a shipmentId parameter, but at present their service definitions don't say so.
This is not a major problem at present. create... is only called in the midst of another service and the test has already been done, but a direct call to create... might cause incorrect behaviour. delete... is not called within Ofbiz at present.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-4344) createItemIssuanceRole and deleteItemIssuanceRole require Shipment PK parameter

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Foxworthy updated OFBIZ-4344:
----------------------------------

    Attachment: OFBIZ-4344_createItemIssuance_with_ShipmentId_parameter

> createItemIssuanceRole and deleteItemIssuanceRole require Shipment PK parameter
> -------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4344
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4344
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Paul Foxworthy
>            Priority: Minor
>         Attachments: OFBIZ-4344_createItemIssuance_with_ShipmentId_parameter
>
>
> createItemIssuanceRole and deleteItemIssuanceRole both call checkCanChangeShipmentStatusPacked, which checks the current status of a shipment to see if anything about it can be modified.
> Therefore, these services require a shipmentId parameter, but at present their service definitions don't say so.
> This is not a major problem at present. create... is only called in the midst of another service and the test has already been done, but a direct call to create... might cause incorrect behaviour. delete... is not called within Ofbiz at present.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-4344) createItemIssuanceRole and deleteItemIssuanceRole require Shipment PK parameter

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Foxworthy updated OFBIZ-4344:
----------------------------------

    Description:
createItemIssuanceRole and deleteItemIssuanceRole both call checkCanChangeShipmentStatusPacked, which checks the current status of a shipment to see if anything about it can be modified.
Therefore, these services require a shipmentId parameter, but at present their service definitions don't say so.
At high logging levels, this bug causes log entries to say there's a missing PK value on a FindOne.
This is not a major problem at present. create... is only called in the midst of another service and the test has already been done, but a direct call to create... might cause incorrect behaviour. delete... is not called within Ofbiz at present.

  was:
createItemIssuanceRole and deleteItemIssuanceRole both call checkCanChangeShipmentStatusPacked, which checks the current status of a shipment to see if anything about it can be modified.
Therefore, these services require a shipmentId parameter, but at present their service definitions don't say so.
This is not a major problem at present. create... is only called in the midst of another service and the test has already been done, but a direct call to create... might cause incorrect behaviour. delete... is not called within Ofbiz at present.

    Environment: rev 1147752

> createItemIssuanceRole and deleteItemIssuanceRole require Shipment PK parameter
> -------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4344
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4344
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: rev 1147752
>            Reporter: Paul Foxworthy
>            Priority: Minor
>         Attachments: OFBIZ-4344_createItemIssuance_with_ShipmentId_parameter
>
>
> createItemIssuanceRole and deleteItemIssuanceRole both call checkCanChangeShipmentStatusPacked, which checks the current status of a shipment to see if anything about it can be modified.
> Therefore, these services require a shipmentId parameter, but at present their service definitions don't say so.
> At high logging levels, this bug causes log entries to say there's a missing PK value on a FindOne.
> This is not a major problem at present. create... is only called in the midst of another service and the test has already been done, but a direct call to create... might cause incorrect behaviour. delete... is not called within Ofbiz at present.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-4344) createItemIssuanceRole and deleteItemIssuanceRole require Shipment PK parameter

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Foxworthy updated OFBIZ-4344:
----------------------------------

    Remaining Estimate: 1h
     Original Estimate: 1h

A minor problem, but easy to review and cross off the list :-)

> createItemIssuanceRole and deleteItemIssuanceRole require Shipment PK parameter
> -------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4344
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4344
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: rev 1147752
>            Reporter: Paul Foxworthy
>            Priority: Minor
>         Attachments: OFBIZ-4344_createItemIssuance_with_ShipmentId_parameter
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> createItemIssuanceRole and deleteItemIssuanceRole both call checkCanChangeShipmentStatusPacked, which checks the current status of a shipment to see if anything about it can be modified.
> Therefore, these services require a shipmentId parameter, but at present their service definitions don't say so.
> At high logging levels, this bug causes log entries to say there's a missing PK value on a FindOne.
> This is not a major problem at present. create... is only called in the midst of another service and the test has already been done, but a direct call to create... might cause incorrect behaviour. delete... is not called within Ofbiz at present.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (OFBIZ-4344) createItemIssuanceRole and deleteItemIssuanceRole require Shipment PK parameter

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4344.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
                   Release Branch 11.04
                   Release Branch 10.04
                   Release Branch 09.04
         Assignee: Jacques Le Roux

Thanks Paul,

Your patch is in
trunk r1167517
R11.04 r1167549
R10.04 r1167548
R09.04 r1167547



> createItemIssuanceRole and deleteItemIssuanceRole require Shipment PK parameter
> -------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4344
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4344
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: rev 1147752
>            Reporter: Paul Foxworthy
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
>
>         Attachments: OFBIZ-4344_createItemIssuance_with_ShipmentId_parameter
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> createItemIssuanceRole and deleteItemIssuanceRole both call checkCanChangeShipmentStatusPacked, which checks the current status of a shipment to see if anything about it can be modified.
> Therefore, these services require a shipmentId parameter, but at present their service definitions don't say so.
> At high logging levels, this bug causes log entries to say there's a missing PK value on a FindOne.
> This is not a major problem at present. create... is only called in the midst of another service and the test has already been done, but a direct call to create... might cause incorrect behaviour. delete... is not called within Ofbiz at present.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira