[jira] [Created] (OFBIZ-4391) loadCartFromQuote should put tax adjustments into the shippong group

[Nicolas Malin (Jira)]

loadCartFromQuote should put tax adjustments into the shippong group
--------------------------------------------------------------------

                 Key: OFBIZ-4391
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4391
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: SVN trunk
         Environment: rev 1164344
            Reporter: Paul Foxworthy
            Priority: Minor


loadCartFromQuote is currently copying all adjustments from a quote into the order-wide adjustments for the shopping cart. Tax adjustments should be copied into the shipping group, i.e. treated in a different way from adjustments like a discount.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Foxworthy updated OFBIZ-4391:
----------------------------------

    Attachment: OFBIZ-4391_loadCartFromQuote.patch

> loadCartFromQuote should put tax adjustments into the shippong group
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4391
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4391
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: rev 1164344
>            Reporter: Paul Foxworthy
>            Priority: Minor
>              Labels: cart, order, quote, tax
>         Attachments: OFBIZ-4391_loadCartFromQuote.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> loadCartFromQuote is currently copying all adjustments from a quote into the order-wide adjustments for the shopping cart. Tax adjustments should be copied into the shipping group, i.e. treated in a different way from adjustments like a discount.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Foxworthy updated OFBIZ-4391:
----------------------------------

    Summary: loadCartFromQuote should put tax adjustments into the shipping group  (was: loadCartFromQuote should put tax adjustments into the shippong group)

> loadCartFromQuote should put tax adjustments into the shipping group
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4391
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4391
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: rev 1164344
>            Reporter: Paul Foxworthy
>            Priority: Minor
>              Labels: cart, order, quote, tax
>         Attachments: OFBIZ-4391_loadCartFromQuote.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> loadCartFromQuote is currently copying all adjustments from a quote into the order-wide adjustments for the shopping cart. Tax adjustments should be copied into the shipping group, i.e. treated in a different way from adjustments like a discount.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Foxworthy updated OFBIZ-4391:
----------------------------------

    Attachment: OFBIZ-4391_loadCartFromQuote.patch

> loadCartFromQuote should put tax adjustments into the shipping group
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4391
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4391
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: rev 1164344
>            Reporter: Paul Foxworthy
>            Priority: Minor
>              Labels: cart, order, quote, tax
>         Attachments: OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> loadCartFromQuote is currently copying all adjustments from a quote into the order-wide adjustments for the shopping cart. Tax adjustments should be copied into the shipping group, i.e. treated in a different way from adjustments like a discount.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Foxworthy updated OFBIZ-4391:
----------------------------------

    Attachment:     (was: OFBIZ-4391_loadCartFromQuote.patch)

> loadCartFromQuote should put tax adjustments into the shipping group
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4391
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4391
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: rev 1164344
>            Reporter: Paul Foxworthy
>            Priority: Minor
>              Labels: cart, order, quote, tax
>         Attachments: OFBIZ-4391_loadCartFromQuote.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> loadCartFromQuote is currently copying all adjustments from a quote into the order-wide adjustments for the shopping cart. Tax adjustments should be copied into the shipping group, i.e. treated in a different way from adjustments like a discount.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096964#comment-13096964 ]

Jacques Le Roux commented on OFBIZ-4391:
----------------------------------------

Hi Paul,

Technically your patch looks good to me, but white spaces after (.

But could you explain why tax adjustments should be copied into *shipping groups*, whether your explanation would be technical or functional...
Also you mentionned "At this point, there is just one ship group.", do you mean only 1 ship group is handled for now?

> loadCartFromQuote should put tax adjustments into the shipping group
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4391
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4391
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: rev 1164344
>            Reporter: Paul Foxworthy
>            Priority: Minor
>              Labels: cart, order, quote, tax
>         Attachments: OFBIZ-4391_loadCartFromQuote.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> loadCartFromQuote is currently copying all adjustments from a quote into the order-wide adjustments for the shopping cart. Tax adjustments should be copied into the shipping group, i.e. treated in a different way from adjustments like a discount.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097146#comment-13097146 ]

Paul Foxworthy commented on OFBIZ-4391:
---------------------------------------

Hi Jacques,

Thanks for reviewing this.

My change is functional.

In the shopping cart, see where tax adjustments are stored : https://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java?hb=true#to4693
They're the itemTaxAdj collection in the CartShipItemInfo class. When you directly enter an order using the shopping cart, tax adjustments are handled correctly. Try adding a quote and in the quote manually add an adjustment for sales tax. When you create an order based on a quote, the adjustment for the sales tax is not put into the itemTaxAdj collection. The result is the tax does not contribute to the total tax, it's treated as a non-tax adjustment.

In my comment regarding one ship group, all I was trying to say is that the shopping cart is being created based on a quote. The user might choose to create a second or even more ship groups *after* the transfer of data from the quote has been done, but at the time we're actually doing the transfer, there can't be more than one. So, my comment is not about a limitation, but rather clarifying that there is no need to look for more than one ship group. In other words, the line

CartShipInfo shipInfo = cart.getShipInfo(0);

is fine. There will not be more than one shipInfo object.

I've stripped trailing spaces and revised the comment in my patch.

> loadCartFromQuote should put tax adjustments into the shipping group
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4391
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4391
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: rev 1164344
>            Reporter: Paul Foxworthy
>            Priority: Minor
>              Labels: cart, order, quote, tax
>         Attachments: OFBIZ-4391_loadCartFromQuote.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> loadCartFromQuote is currently copying all adjustments from a quote into the order-wide adjustments for the shopping cart. Tax adjustments should be copied into the shipping group, i.e. treated in a different way from adjustments like a discount.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Foxworthy updated OFBIZ-4391:
----------------------------------

    Attachment: OFBIZ-4391_loadCartFromQuote.patch

> loadCartFromQuote should put tax adjustments into the shipping group
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4391
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4391
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: rev 1164344
>            Reporter: Paul Foxworthy
>            Priority: Minor
>              Labels: cart, order, quote, tax
>         Attachments: OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> loadCartFromQuote is currently copying all adjustments from a quote into the order-wide adjustments for the shopping cart. Tax adjustments should be copied into the shipping group, i.e. treated in a different way from adjustments like a discount.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Foxworthy updated OFBIZ-4391:
----------------------------------

    Attachment: OFBIZ-4391_loadCartFromQuote.patch

Revised patch

> loadCartFromQuote should put tax adjustments into the shipping group
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4391
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4391
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: rev 1164344
>            Reporter: Paul Foxworthy
>            Priority: Minor
>              Labels: cart, order, quote, tax
>         Attachments: OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> loadCartFromQuote is currently copying all adjustments from a quote into the order-wide adjustments for the shopping cart. Tax adjustments should be copied into the shipping group, i.e. treated in a different way from adjustments like a discount.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Foxworthy updated OFBIZ-4391:
----------------------------------

    Attachment:     (was: OFBIZ-4391_loadCartFromQuote.patch)

> loadCartFromQuote should put tax adjustments into the shipping group
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4391
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4391
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: rev 1164344
>            Reporter: Paul Foxworthy
>            Priority: Minor
>              Labels: cart, order, quote, tax
>         Attachments: OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> loadCartFromQuote is currently copying all adjustments from a quote into the order-wide adjustments for the shopping cart. Tax adjustments should be copied into the shipping group, i.e. treated in a different way from adjustments like a discount.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097199#comment-13097199 ]

Jacques Le Roux commented on OFBIZ-4391:
----------------------------------------

Thanks Paul,

Its quite clear now, I will have a fresh look...

> loadCartFromQuote should put tax adjustments into the shipping group
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4391
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4391
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: rev 1164344
>            Reporter: Paul Foxworthy
>            Priority: Minor
>              Labels: cart, order, quote, tax
>         Attachments: OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> loadCartFromQuote is currently copying all adjustments from a quote into the order-wide adjustments for the shopping cart. Tax adjustments should be copied into the shipping group, i.e. treated in a different way from adjustments like a discount.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-4391:
--------------------------------------

    Assignee: Jacques Le Roux

> loadCartFromQuote should put tax adjustments into the shipping group
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4391
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4391
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: rev 1164344
>            Reporter: Paul Foxworthy
>            Assignee: Jacques Le Roux
>            Priority: Minor
>              Labels: cart, order, quote, tax
>         Attachments: OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> loadCartFromQuote is currently copying all adjustments from a quote into the order-wide adjustments for the shopping cart. Tax adjustments should be copied into the shipping group, i.e. treated in a different way from adjustments like a discount.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4391:
-----------------------------------

    Attachment: OFBIZ-4391_loadCartFromQuote.patch

Mmm,

I got some issues so far,
* on demo trunk (I neglicted the NPE fixed at r1165233, it will be soon updated/fixed aldo on demo), when I create the order I get
"Did not complete the order, the following occurred:ERROR: There are no items to order" which seems actualy due to "Totals do not match order total."
* locally patched, I get a NPE when creating the order
{code}
2011-09-06 07:08:17,328 (http-0.0.0.0-8443-3) [     RequestHandler.java:167:INFO ] [RequestHandler]: Chain in place: requestUri=processpayment overrideViewUri=null sessionId=B4432EB539E9CE2032AC0E9A6B6FB5
vm1
2011-09-06 07:08:17,328 (http-0.0.0.0-8443-3) [   JavaEventHandler.java:101:ERROR]
---- runtime exception report --------------------------------------------------
Problems Processing Event
Exception: java.lang.NullPointerException
Message: null
---- stack trace ---------------------------------------------------------------
java.lang.NullPointerException
org.ofbiz.order.shoppingcart.CheckOutEvents.processPayment(CheckOutEvents.java:567)
org.ofbiz.order.shoppingcart.CheckOutEvents.processPayment(CheckOutEvents.java:535)
{code}

I will check that later. For the moment here is a patch amended (formatting):

* no spaces after bracket
* when you don't use curly brackets after if/else then please put the expression on the same line than the if/else. It avoids troubles later, as it's clear the unique expression is related to the if/else

> loadCartFromQuote should put tax adjustments into the shipping group
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4391
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4391
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: rev 1164344
>            Reporter: Paul Foxworthy
>            Assignee: Jacques Le Roux
>            Priority: Minor
>              Labels: cart, order, quote, tax
>         Attachments: OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> loadCartFromQuote is currently copying all adjustments from a quote into the order-wide adjustments for the shopping cart. Tax adjustments should be copied into the shipping group, i.e. treated in a different way from adjustments like a discount.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097874#comment-13097874 ]

Paul Foxworthy commented on OFBIZ-4391:
---------------------------------------

Thanks Jacques.

I will see if I can reproduce the NPE and revise.

Cheers

Paul Foxworthy

> loadCartFromQuote should put tax adjustments into the shipping group
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4391
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4391
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: rev 1164344
>            Reporter: Paul Foxworthy
>            Assignee: Jacques Le Roux
>            Priority: Minor
>              Labels: cart, order, quote, tax
>         Attachments: OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> loadCartFromQuote is currently copying all adjustments from a quote into the order-wide adjustments for the shopping cart. Tax adjustments should be copied into the shipping group, i.e. treated in a different way from adjustments like a discount.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098222#comment-13098222 ]

Jacques Le Roux commented on OFBIZ-4391:
----------------------------------------

Paul,

I don't know if the NPE is on your side... It does not happen on truk demo but another error pops also there...

> loadCartFromQuote should put tax adjustments into the shipping group
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4391
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4391
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: rev 1164344
>            Reporter: Paul Foxworthy
>            Assignee: Jacques Le Roux
>            Priority: Minor
>              Labels: cart, order, quote, tax
>         Attachments: OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> loadCartFromQuote is currently copying all adjustments from a quote into the order-wide adjustments for the shopping cart. Tax adjustments should be copied into the shipping group, i.e. treated in a different way from adjustments like a discount.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098542#comment-13098542 ]

Paul Foxworthy commented on OFBIZ-4391:
---------------------------------------

Hi Jacques,

I think I have a fix for the NPE. I'm building a unit test to demonstrate the flaw and demonstrate it fixed after the patch is applied. I'll be uploading a new patch and the unit test in a day or two.

Feel free to work on something else in the meantime :-).

Cheers

Paul Foxworthy

> loadCartFromQuote should put tax adjustments into the shipping group
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4391
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4391
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: rev 1164344
>            Reporter: Paul Foxworthy
>            Assignee: Jacques Le Roux
>            Priority: Minor
>              Labels: cart, order, quote, tax
>         Attachments: OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> loadCartFromQuote is currently copying all adjustments from a quote into the order-wide adjustments for the shopping cart. Tax adjustments should be copied into the shipping group, i.e. treated in a different way from adjustments like a discount.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Foxworthy updated OFBIZ-4391:
----------------------------------

    Attachment: OFBIZ-4391_loadCartFromQuoteTest.patch
                OFBIZ-4391_loadCartFromQuote.patch

Test patch contains unit test to demonstrate bug in loadCartFromQuote.

> loadCartFromQuote should put tax adjustments into the shipping group
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4391
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4391
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: rev 1164344
>            Reporter: Paul Foxworthy
>            Assignee: Jacques Le Roux
>            Priority: Minor
>              Labels: cart, order, quote, tax
>         Attachments: OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuoteTest.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> loadCartFromQuote is currently copying all adjustments from a quote into the order-wide adjustments for the shopping cart. Tax adjustments should be copied into the shipping group, i.e. treated in a different way from adjustments like a discount.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102067#comment-13102067 ]

Paul Foxworthy commented on OFBIZ-4391:
---------------------------------------

Hi Jacques,

Here's an updated patch which I believe has fixed the NPE. In addition, there's now a unit test that demonstrates the bug. Apply just the test patch and you should see the problem. Apply the other patch with the change to loadCartFromQuote, and the test should pass.

Cheers

Paul Foxworthy

> loadCartFromQuote should put tax adjustments into the shipping group
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4391
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4391
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: rev 1164344
>            Reporter: Paul Foxworthy
>            Assignee: Jacques Le Roux
>            Priority: Minor
>              Labels: cart, order, quote, tax
>         Attachments: OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuoteTest.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> loadCartFromQuote is currently copying all adjustments from a quote into the order-wide adjustments for the shopping cart. Tax adjustments should be copied into the shipping group, i.e. treated in a different way from adjustments like a discount.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4391.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
                   Release Branch 11.04

Thanks Paul,

Good job, your patch is in
trunk r1167606  
R11.04 r1167613

> loadCartFromQuote should put tax adjustments into the shipping group
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-4391
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4391
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: rev 1164344
>            Reporter: Paul Foxworthy
>            Assignee: Jacques Le Roux
>            Priority: Minor
>              Labels: cart, order, quote, tax
>             Fix For: Release Branch 11.04, SVN trunk
>
>         Attachments: OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuote.patch, OFBIZ-4391_loadCartFromQuoteTest.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> loadCartFromQuote is currently copying all adjustments from a quote into the order-wide adjustments for the shopping cart. Tax adjustments should be copied into the shipping group, i.e. treated in a different way from adjustments like a discount.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira