[jira] Created: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget
Locked
12
12
[jira] Created: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget
 
|
Migrate Entity Maintenance from JSPs/region to Screen widget
------------------------------------------------------------ Key: OFBIZ-450 URL: http://issues.apache.org/jira/browse/OFBIZ-450 Project: OFBiz (The Open for Business Project) Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Marco Risaliti Priority: Minor This patch contains the migration from JSPs/region to Screen widget. I have re-applied also the changes that has been done into the issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen) recently committed. After this patch the entity maintenance has still two minor issues that they was also present into the previously version written in JSPs/region : 1- sometimes the html tables overflow the screen. 2- in case of entity that has an group by clause specified the FindGeneric page will show an error. That's all what I have done. Please give me some feedback on this issue so if everythings is ok I can continue to migrate the next part of the Webtools application (Entity Reference). Can also the committer tell me if the patch has a correct formatting and absence of tabs and correct relative paths. Thanks in advance Marco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget
|
|
[ http://issues.apache.org/jira/browse/OFBIZ-450?page=all ]
Marco Risaliti updated OFBIZ-450: --------------------------------- Attachment: entity_maint.patch > Migrate Entity Maintenance from JSPs/region to Screen widget > ------------------------------------------------------------ > > Key: OFBIZ-450 > URL: http://issues.apache.org/jira/browse/OFBIZ-450 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Minor > Attachments: entity_maint.patch > > > This patch contains the migration from JSPs/region to Screen widget. > I have re-applied also the changes that has been done into the issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen) recently committed. > After this patch the entity maintenance has still two minor issues that they was also present into the previously version written in JSPs/region : > 1- sometimes the html tables overflow the screen. > 2- in case of entity that has an group by clause specified the FindGeneric page will show an error. > That's all what I have done. > Please give me some feedback on this issue so if everythings is ok I can continue to migrate the next part of the Webtools application (Entity Reference). > Can also the committer tell me if the patch has a correct formatting and absence of tabs and correct relative paths. > Thanks in advance > Marco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12449047 ]
Jacques Le Roux commented on OFBIZ-450: --------------------------------------- Hi Marco, One think I can say : no tabs pb in this patch. > Migrate Entity Maintenance from JSPs/region to Screen widget > ------------------------------------------------------------ > > Key: OFBIZ-450 > URL: http://issues.apache.org/jira/browse/OFBIZ-450 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Minor > Attachments: entity_maint.patch > > > This patch contains the migration from JSPs/region to Screen widget. > I have re-applied also the changes that has been done into the issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen) recently committed. > After this patch the entity maintenance has still two minor issues that they was also present into the previously version written in JSPs/region : > 1- sometimes the html tables overflow the screen. > 2- in case of entity that has an group by clause specified the FindGeneric page will show an error. > That's all what I have done. > Please give me some feedback on this issue so if everythings is ok I can continue to migrate the next part of the Webtools application (Entity Reference). > Can also the committer tell me if the patch has a correct formatting and absence of tabs and correct relative paths. > Thanks in advance > Marco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12449049 ]
Jacques Le Roux commented on OFBIZ-450: --------------------------------------- Some more points : . No licence pb . Formating seems std . No path pb Did no test only reviewed patch. > Migrate Entity Maintenance from JSPs/region to Screen widget > ------------------------------------------------------------ > > Key: OFBIZ-450 > URL: http://issues.apache.org/jira/browse/OFBIZ-450 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Minor > Attachments: entity_maint.patch > > > This patch contains the migration from JSPs/region to Screen widget. > I have re-applied also the changes that has been done into the issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen) recently committed. > After this patch the entity maintenance has still two minor issues that they was also present into the previously version written in JSPs/region : > 1- sometimes the html tables overflow the screen. > 2- in case of entity that has an group by clause specified the FindGeneric page will show an error. > That's all what I have done. > Please give me some feedback on this issue so if everythings is ok I can continue to migrate the next part of the Webtools application (Entity Reference). > Can also the committer tell me if the patch has a correct formatting and absence of tabs and correct relative paths. > Thanks in advance > Marco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-450?page=all ]
Marco Risaliti updated OFBIZ-450: --------------------------------- Attachment: entity_maint2.patch Hi Jacques, thanks a lot for your promptly reply. I'm uploading a new version of the patch because I forgot to delete three simple print into bsh file for debug some values. So I have correct it and re-uploaded a new version of the patch. Could you please delete the first one entity_maint.patch Thanks Marco > Migrate Entity Maintenance from JSPs/region to Screen widget > ------------------------------------------------------------ > > Key: OFBIZ-450 > URL: http://issues.apache.org/jira/browse/OFBIZ-450 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Minor > Attachments: entity_maint.patch, entity_maint2.patch > > > This patch contains the migration from JSPs/region to Screen widget. > I have re-applied also the changes that has been done into the issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen) recently committed. > After this patch the entity maintenance has still two minor issues that they was also present into the previously version written in JSPs/region : > 1- sometimes the html tables overflow the screen. > 2- in case of entity that has an group by clause specified the FindGeneric page will show an error. > That's all what I have done. > Please give me some feedback on this issue so if everythings is ok I can continue to migrate the next part of the Webtools application (Entity Reference). > Can also the committer tell me if the patch has a correct formatting and absence of tabs and correct relative paths. > Thanks in advance > Marco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12449052 ]
Jacques Le Roux commented on OFBIZ-450: --------------------------------------- Mmm, Some if missing {} pairs in EntityMaint.bsh. I also had this "bad" habit from C/C++ experience and now my religion is to put them always as recommended by Sun (please see best practices in Confluence and specially http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html). With "new" autoformating editors it's no more a pain (specifically with azerty - ie french - keyboards). They are some also in OFBiz legacy code. > Migrate Entity Maintenance from JSPs/region to Screen widget > ------------------------------------------------------------ > > Key: OFBIZ-450 > URL: http://issues.apache.org/jira/browse/OFBIZ-450 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Minor > Attachments: entity_maint.patch, entity_maint2.patch > > > This patch contains the migration from JSPs/region to Screen widget. > I have re-applied also the changes that has been done into the issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen) recently committed. > After this patch the entity maintenance has still two minor issues that they was also present into the previously version written in JSPs/region : > 1- sometimes the html tables overflow the screen. > 2- in case of entity that has an group by clause specified the FindGeneric page will show an error. > That's all what I have done. > Please give me some feedback on this issue so if everythings is ok I can continue to migrate the next part of the Webtools application (Entity Reference). > Can also the committer tell me if the patch has a correct formatting and absence of tabs and correct relative paths. > Thanks in advance > Marco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-450?page=all ]
Jacques Le Roux updated OFBIZ-450: ---------------------------------- Attachment: (was: entity_maint.patch) > Migrate Entity Maintenance from JSPs/region to Screen widget > ------------------------------------------------------------ > > Key: OFBIZ-450 > URL: http://issues.apache.org/jira/browse/OFBIZ-450 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Minor > Attachments: entity_maint2.patch > > > This patch contains the migration from JSPs/region to Screen widget. > I have re-applied also the changes that has been done into the issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen) recently committed. > After this patch the entity maintenance has still two minor issues that they was also present into the previously version written in JSPs/region : > 1- sometimes the html tables overflow the screen. > 2- in case of entity that has an group by clause specified the FindGeneric page will show an error. > That's all what I have done. > Please give me some feedback on this issue so if everythings is ok I can continue to migrate the next part of the Webtools application (Entity Reference). > Can also the committer tell me if the patch has a correct formatting and absence of tabs and correct relative paths. > Thanks in advance > Marco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12449054 ]
Jacques Le Roux commented on OFBIZ-450: --------------------------------------- This point is in http://java.sun.com/docs/codeconv/html/CodeConventions.doc6.html#449 (see note) Future contributors will thank you (not error prone) ;o) > Migrate Entity Maintenance from JSPs/region to Screen widget > ------------------------------------------------------------ > > Key: OFBIZ-450 > URL: http://issues.apache.org/jira/browse/OFBIZ-450 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Minor > Attachments: entity_maint2.patch > > > This patch contains the migration from JSPs/region to Screen widget. > I have re-applied also the changes that has been done into the issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen) recently committed. > After this patch the entity maintenance has still two minor issues that they was also present into the previously version written in JSPs/region : > 1- sometimes the html tables overflow the screen. > 2- in case of entity that has an group by clause specified the FindGeneric page will show an error. > That's all what I have done. > Please give me some feedback on this issue so if everythings is ok I can continue to migrate the next part of the Webtools application (Entity Reference). > Can also the committer tell me if the patch has a correct formatting and absence of tabs and correct relative paths. > Thanks in advance > Marco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-450?page=all ]
Marco Risaliti updated OFBIZ-450: --------------------------------- Attachment: entity_maint3.patch Hi Jacques, I have corrected also the formatting of the if-else according to the sun code conventions. Could you please delete the patch entity_maint2.patch that has been replace completely by entity_maint3.patch Thanks a lot again for remember this to me. Marco > Migrate Entity Maintenance from JSPs/region to Screen widget > ------------------------------------------------------------ > > Key: OFBIZ-450 > URL: http://issues.apache.org/jira/browse/OFBIZ-450 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Minor > Attachments: entity_maint2.patch, entity_maint3.patch > > > This patch contains the migration from JSPs/region to Screen widget. > I have re-applied also the changes that has been done into the issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen) recently committed. > After this patch the entity maintenance has still two minor issues that they was also present into the previously version written in JSPs/region : > 1- sometimes the html tables overflow the screen. > 2- in case of entity that has an group by clause specified the FindGeneric page will show an error. > That's all what I have done. > Please give me some feedback on this issue so if everythings is ok I can continue to migrate the next part of the Webtools application (Entity Reference). > Can also the committer tell me if the patch has a correct formatting and absence of tabs and correct relative paths. > Thanks in advance > Marco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12449072 ]
Ashish Vijaywargiya commented on OFBIZ-450: ------------------------------------------- Hi Macro, I have reviewed your patch although I didn't test it. I really liked your efforts to migrate old content. Now I am going to test your patch on my development box. Thanks for such a nice contribution. Regards Ashish Vijaywargiya > Migrate Entity Maintenance from JSPs/region to Screen widget > ------------------------------------------------------------ > > Key: OFBIZ-450 > URL: http://issues.apache.org/jira/browse/OFBIZ-450 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Minor > Attachments: entity_maint2.patch, entity_maint3.patch > > > This patch contains the migration from JSPs/region to Screen widget. > I have re-applied also the changes that has been done into the issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen) recently committed. > After this patch the entity maintenance has still two minor issues that they was also present into the previously version written in JSPs/region : > 1- sometimes the html tables overflow the screen. > 2- in case of entity that has an group by clause specified the FindGeneric page will show an error. > That's all what I have done. > Please give me some feedback on this issue so if everythings is ok I can continue to migrate the next part of the Webtools application (Entity Reference). > Can also the committer tell me if the patch has a correct formatting and absence of tabs and correct relative paths. > Thanks in advance > Marco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12449079 ]
Chris Howe commented on OFBIZ-450: ---------------------------------- double plus goodness on the migration effort. one thought though. would it be possible to move one webtool's jsp/region "screen" to the example component so that the compatibility isn't lost forever (even if it breaks with a bsh upgrade). There are many good webapps that use jsps out there and a decent example might make it easier to integrate them. > Migrate Entity Maintenance from JSPs/region to Screen widget > ------------------------------------------------------------ > > Key: OFBIZ-450 > URL: http://issues.apache.org/jira/browse/OFBIZ-450 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Minor > Attachments: entity_maint2.patch, entity_maint3.patch > > > This patch contains the migration from JSPs/region to Screen widget. > I have re-applied also the changes that has been done into the issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen) recently committed. > After this patch the entity maintenance has still two minor issues that they was also present into the previously version written in JSPs/region : > 1- sometimes the html tables overflow the screen. > 2- in case of entity that has an group by clause specified the FindGeneric page will show an error. > That's all what I have done. > Please give me some feedback on this issue so if everythings is ok I can continue to migrate the next part of the Webtools application (Entity Reference). > Can also the committer tell me if the patch has a correct formatting and absence of tabs and correct relative paths. > Thanks in advance > Marco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12449096 ]
David E. Jones commented on OFBIZ-450: -------------------------------------- If people want an example they can always look at old stuff in SVN... even if they don't like that approach... ;) We could certainly do a JSP example, but it should be an example and not a huge old page that would need to be maintained in order to continue working... > Migrate Entity Maintenance from JSPs/region to Screen widget > ------------------------------------------------------------ > > Key: OFBIZ-450 > URL: http://issues.apache.org/jira/browse/OFBIZ-450 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Minor > Attachments: entity_maint2.patch, entity_maint3.patch > > > This patch contains the migration from JSPs/region to Screen widget. > I have re-applied also the changes that has been done into the issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen) recently committed. > After this patch the entity maintenance has still two minor issues that they was also present into the previously version written in JSPs/region : > 1- sometimes the html tables overflow the screen. > 2- in case of entity that has an group by clause specified the FindGeneric page will show an error. > That's all what I have done. > Please give me some feedback on this issue so if everythings is ok I can continue to migrate the next part of the Webtools application (Entity Reference). > Can also the committer tell me if the patch has a correct formatting and absence of tabs and correct relative paths. > Thanks in advance > Marco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-450?page=all ]
Jacques Le Roux updated OFBIZ-450: ---------------------------------- Attachment: (was: entity_maint2.patch) > Migrate Entity Maintenance from JSPs/region to Screen widget > ------------------------------------------------------------ > > Key: OFBIZ-450 > URL: http://issues.apache.org/jira/browse/OFBIZ-450 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Minor > Attachments: entity_maint3.patch > > > This patch contains the migration from JSPs/region to Screen widget. > I have re-applied also the changes that has been done into the issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen) recently committed. > After this patch the entity maintenance has still two minor issues that they was also present into the previously version written in JSPs/region : > 1- sometimes the html tables overflow the screen. > 2- in case of entity that has an group by clause specified the FindGeneric page will show an error. > That's all what I have done. > Please give me some feedback on this issue so if everythings is ok I can continue to migrate the next part of the Webtools application (Entity Reference). > Can also the committer tell me if the patch has a correct formatting and absence of tabs and correct relative paths. > Thanks in advance > Marco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12449098 ]
Jacopo Cappellato commented on OFBIZ-450: ----------------------------------------- I've quickly reviewed the patch file (but not applied) end it seems really good (thanks Marco); I'd love to get Ashish's feedback too. I think that, after this, one of the committer should really commit it: if no one will do it before, I'll try to do it in the next few days (or later today... but not sure). > Migrate Entity Maintenance from JSPs/region to Screen widget > ------------------------------------------------------------ > > Key: OFBIZ-450 > URL: http://issues.apache.org/jira/browse/OFBIZ-450 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Minor > Attachments: entity_maint3.patch > > > This patch contains the migration from JSPs/region to Screen widget. > I have re-applied also the changes that has been done into the issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen) recently committed. > After this patch the entity maintenance has still two minor issues that they was also present into the previously version written in JSPs/region : > 1- sometimes the html tables overflow the screen. > 2- in case of entity that has an group by clause specified the FindGeneric page will show an error. > That's all what I have done. > Please give me some feedback on this issue so if everythings is ok I can continue to migrate the next part of the Webtools application (Entity Reference). > Can also the committer tell me if the patch has a correct formatting and absence of tabs and correct relative paths. > Thanks in advance > Marco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12449147 ]
Ashish Vijaywargiya commented on OFBIZ-450: ------------------------------------------- Hi Macro,Jacques & Jacopo, Here are my comments.("Hey Macro your work was excellent") 1) Everything looks fine so this patch can be applied without any delay. 2) We should keep the "View Entity"(old one) title instead of "Entity View" for all the view entity. 3) I think we can remove the "style='FONT-SIZE: xx-small;'" from EntityMaint.ftl.If you think that the links(buttons) comes very close to table border then you can increase the "cellpadding" by one i.e increase to "3" from "2" at lines 24 and 65. 4) There are only small mistake in ftl file of the closing column position of <#if> and deviated position of <td> tag.(Please commit this patch I will take take care of all this small things and will send the patch) Rest code from bsh and ftl is excellent. Once again Thanks Macro for such a nice contribution. Regards Ashish Vijaywargiya > Migrate Entity Maintenance from JSPs/region to Screen widget > ------------------------------------------------------------ > > Key: OFBIZ-450 > URL: http://issues.apache.org/jira/browse/OFBIZ-450 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Priority: Minor > Attachments: entity_maint3.patch > > > This patch contains the migration from JSPs/region to Screen widget. > I have re-applied also the changes that has been done into the issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen) recently committed. > After this patch the entity maintenance has still two minor issues that they was also present into the previously version written in JSPs/region : > 1- sometimes the html tables overflow the screen. > 2- in case of entity that has an group by clause specified the FindGeneric page will show an error. > That's all what I have done. > Please give me some feedback on this issue so if everythings is ok I can continue to migrate the next part of the Webtools application (Entity Reference). > Can also the committer tell me if the patch has a correct formatting and absence of tabs and correct relative paths. > Thanks in advance > Marco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Closed: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-450?page=all ]
Jacques Le Roux closed OFBIZ-450. --------------------------------- Fix Version/s: SVN trunk Resolution: Fixed Assignee: Jacques Le Roux Thank you Marco for this patch, and thanks for all of you that have reviewed it. Form Ashish comment #2 I kept the "View Entity"(old one) title instead of "Entity View" for all the view entity. I let you Ashish do what remain. For me it's ok : tested in Firefox 1.5, IE 6 and Opera 9.02. In OFBiz revision: 473992 > Migrate Entity Maintenance from JSPs/region to Screen widget > ------------------------------------------------------------ > > Key: OFBIZ-450 > URL: http://issues.apache.org/jira/browse/OFBIZ-450 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: entity_maint3.patch > > > This patch contains the migration from JSPs/region to Screen widget. > I have re-applied also the changes that has been done into the issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen) recently committed. > After this patch the entity maintenance has still two minor issues that they was also present into the previously version written in JSPs/region : > 1- sometimes the html tables overflow the screen. > 2- in case of entity that has an group by clause specified the FindGeneric page will show an error. > That's all what I have done. > Please give me some feedback on this issue so if everythings is ok I can continue to migrate the next part of the Webtools application (Entity Reference). > Can also the committer tell me if the patch has a correct formatting and absence of tabs and correct relative paths. > Thanks in advance > Marco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12449156 ]
Ashish Vijaywargiya commented on OFBIZ-450: ------------------------------------------- Jacques, Can you please take a look at those files that are removed in Macro patch ?? That files still exists in the SVN repository and has no code in the files.(i.e ViewRelations.jsp,ViewGeneric.jsp,entitymaint.jsp,FindGeneric.jsp) Thanks for considering my comments. Regards Ashish Vijaywargiya > Migrate Entity Maintenance from JSPs/region to Screen widget > ------------------------------------------------------------ > > Key: OFBIZ-450 > URL: http://issues.apache.org/jira/browse/OFBIZ-450 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: entity_maint3.patch > > > This patch contains the migration from JSPs/region to Screen widget. > I have re-applied also the changes that has been done into the issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen) recently committed. > After this patch the entity maintenance has still two minor issues that they was also present into the previously version written in JSPs/region : > 1- sometimes the html tables overflow the screen. > 2- in case of entity that has an group by clause specified the FindGeneric page will show an error. > That's all what I have done. > Please give me some feedback on this issue so if everythings is ok I can continue to migrate the next part of the Webtools application (Entity Reference). > Can also the committer tell me if the patch has a correct formatting and absence of tabs and correct relative paths. > Thanks in advance > Marco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12449159 ]
Jacques Le Roux commented on OFBIZ-450: --------------------------------------- Yes you are right Ashish. I noticed it while commiting and forgot after to remove them. Done in revision 474005. Thanks for your comment. > Migrate Entity Maintenance from JSPs/region to Screen widget > ------------------------------------------------------------ > > Key: OFBIZ-450 > URL: http://issues.apache.org/jira/browse/OFBIZ-450 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: entity_maint3.patch > > > This patch contains the migration from JSPs/region to Screen widget. > I have re-applied also the changes that has been done into the issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen) recently committed. > After this patch the entity maintenance has still two minor issues that they was also present into the previously version written in JSPs/region : > 1- sometimes the html tables overflow the screen. > 2- in case of entity that has an group by clause specified the FindGeneric page will show an error. > That's all what I have done. > Please give me some feedback on this issue so if everythings is ok I can continue to migrate the next part of the Webtools application (Entity Reference). > Can also the committer tell me if the patch has a correct formatting and absence of tabs and correct relative paths. > Thanks in advance > Marco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12449260 ]
Jacopo Cappellato commented on OFBIZ-450: ----------------------------------------- Jacques, thanks for committing it. > Migrate Entity Maintenance from JSPs/region to Screen widget > ------------------------------------------------------------ > > Key: OFBIZ-450 > URL: http://issues.apache.org/jira/browse/OFBIZ-450 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: entity_maint3.patch > > > This patch contains the migration from JSPs/region to Screen widget. > I have re-applied also the changes that has been done into the issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen) recently committed. > After this patch the entity maintenance has still two minor issues that they was also present into the previously version written in JSPs/region : > 1- sometimes the html tables overflow the screen. > 2- in case of entity that has an group by clause specified the FindGeneric page will show an error. > That's all what I have done. > Please give me some feedback on this issue so if everythings is ok I can continue to migrate the next part of the Webtools application (Entity Reference). > Can also the committer tell me if the patch has a correct formatting and absence of tabs and correct relative paths. > Thanks in advance > Marco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12449261 ]
Jacques Le Roux commented on OFBIZ-450: --------------------------------------- Just one last point for Marco because I thought it was implicit in my last comment but I believe now that it's not. When you want to remove a file, don't remove its lines but delete it from your working copy. SVN will then delete it from repository. It's great to see more and more people able to do more and more sophisticaded stuffes in OFBiz (including me, still learning ;o). Really happy, thanks to all of you ! > Migrate Entity Maintenance from JSPs/region to Screen widget > ------------------------------------------------------------ > > Key: OFBIZ-450 > URL: http://issues.apache.org/jira/browse/OFBIZ-450 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Marco Risaliti > Assigned To: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: entity_maint3.patch > > > This patch contains the migration from JSPs/region to Screen widget. > I have re-applied also the changes that has been done into the issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen) recently committed. > After this patch the entity maintenance has still two minor issues that they was also present into the previously version written in JSPs/region : > 1- sometimes the html tables overflow the screen. > 2- in case of entity that has an group by clause specified the FindGeneric page will show an error. > That's all what I have done. > Please give me some feedback on this issue so if everythings is ok I can continue to migrate the next part of the Webtools application (Entity Reference). > Can also the committer tell me if the patch has a correct formatting and absence of tabs and correct relative paths. > Thanks in advance > Marco -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |