[
https://issues.apache.org/jira/browse/OFBIZ-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-4700.
----------------------------------
Resolution: Fixed
Assignee: Jacques Le Roux
Thanks Markus,
Your patch is in trunk at r1245130
Just a little remark (after some others it seems ;o). It was not difficult to modify your patch to apply it (with some Fuzz). But it was not done as we expect to apply it, please read [how to create and apply patches|
https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices#OFBizContributorsBestPractices-HowtoSendinYourContributions(orhowtocreateandapplypatches)] and for an easier way, look at the attached patch I really applied and compare with yours.
Also because sometimes committers have to wait before applying patch (conflicts, etc) we wish to have more explanations in the patch name itself. The one I attached is a good example of what we expect on this regard.
All this said, for this case it was a breeze to adapt, but sometimes it's more complicated.
Again thanks for your help!
> Add german translation to TemporalExpressionUiLabels.xml
> --------------------------------------------------------
>
> Key: OFBIZ-4700
> URL:
https://issues.apache.org/jira/browse/OFBIZ-4700> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: 0001-Add-de-locale.svn.patch, OFBIZ-4700 german translation TemporalExpression.patch
>
>
> Add a patch for the german language for the TemporalExpressionUiLabels.xml
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspaFor more information on JIRA, see:
http://www.atlassian.com/software/jira
Locked
