OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-484) Wrong total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

10 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-484) Wrong total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method

Wrong total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method
----------------------------------------------------------------------------------------------------------------------------------

Key: OFBIZ-484
URL: http://issues.apache.org/jira/browse/OFBIZ-484
Project: OFBiz (The Open for Business Project)
Issue Type: Bug
Components: order
Affects Versions: SVN trunk
Reporter: Jacopo Cappellato

It should fix an issue I've discovered in the way the total total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method.
I think that the new amount received is summed two times to the total of already received offline amounts.
For example, if the order total is $80, and you receive an offline payment of $50, due to the bad calculation, the method says 50+50 = 100 > 80 and so approves the order.
Could you please review the attached patch (that fix the issue)?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-484) Wrong total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method

[ http://issues.apache.org/jira/browse/OFBIZ-484?page=all ]

Jacopo Cappellato updated OFBIZ-484:
------------------------------------

Attachment: offline_payment.patch

> Wrong total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-484
> URL: http://issues.apache.org/jira/browse/OFBIZ-484
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jacopo Cappellato
> Attachments: offline_payment.patch
>
>
> It should fix an issue I've discovered in the way the total total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method.
> I think that the new amount received is summed two times to the total of already received offline amounts.
> For example, if the order total is $80, and you receive an offline payment of $50, due to the bad calculation, the method says 50+50 = 100 > 80 and so approves the order.
> Could you please review the attached patch (that fix the issue)?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-484) Wrong total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-484?page=all ]

Jacopo Cappellato updated OFBIZ-484:
------------------------------------

Attachment: (was: offline_payment.patch)

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-484) Wrong total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-484?page=all ]

Jacopo Cappellato updated OFBIZ-484:
------------------------------------

Attachment: offline_payment.patch

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-484) Wrong total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-484?page=comments#action_12452623 ]

Jacopo Cappellato commented on OFBIZ-484:
-----------------------------------------

Any comments/reviews on this? I think this is a big issue that we should fix soon, and the attached patch seems to work fine... but before I commit it I'd like to get more feedback (anyone using offline payments with a recent svn revision?).

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-484) Wrong total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-484?page=all ]

Jacopo Cappellato reassigned OFBIZ-484:
---------------------------------------

Assignee: Jacopo Cappellato

> Wrong total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-484
> URL: http://issues.apache.org/jira/browse/OFBIZ-484
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jacopo Cappellato
> Assigned To: Jacopo Cappellato
> Attachments: offline_payment.patch
>
>
> It should fix an issue I've discovered in the way the total total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method.
> I think that the new amount received is summed two times to the total of already received offline amounts.
> For example, if the order total is $80, and you receive an offline payment of $50, due to the bad calculation, the method says 50+50 = 100 > 80 and so approves the order.
> Could you please review the attached patch (that fix the issue)?

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-484) Wrong total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-484?page=comments#action_12453555 ]

Jacques Le Roux commented on OFBIZ-484:
---------------------------------------

Jacopo,

I tested but did not see in the payment doubled (in order view, accounting/payment and even in DB) using rev 478253.

> Wrong total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-484
> URL: http://issues.apache.org/jira/browse/OFBIZ-484
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jacopo Cappellato
> Assigned To: Jacopo Cappellato
> Attachments: offline_payment.patch
>
>
> It should fix an issue I've discovered in the way the total total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method.
> I think that the new amount received is summed two times to the total of already received offline amounts.
> For example, if the order total is $80, and you receive an offline payment of $50, due to the bad calculation, the method says 50+50 = 100 > 80 and so approves the order.
> Could you please review the attached patch (that fix the issue)?

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-484) Wrong total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-484?page=comments#action_12453559 ]

Jacopo Cappellato commented on OFBIZ-484:
-----------------------------------------

Jacques,

sorry, the issue is still there but my explanation was awful...

Can you have a look at the order:
https://demo.dejc.com:8443/ordermgr/control/orderview?orderId=WS10000

As you can see the payments received are for a total of $60, and the order amount is $62.84
However the order has been approved right after the last $10 payment: in fact the current code counts two times the last payment received when it performs the balance.
So when I have 50$ received and I issue a new $10 payment, the system performs the following calculation:
50$ + 10$
+10$ (wrong!)
and approves the order

Jacopo

> Wrong total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-484
> URL: http://issues.apache.org/jira/browse/OFBIZ-484
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jacopo Cappellato
> Assigned To: Jacopo Cappellato
> Attachments: offline_payment.patch
>
>
> It should fix an issue I've discovered in the way the total total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method.
> I think that the new amount received is summed two times to the total of already received offline amounts.
> For example, if the order total is $80, and you receive an offline payment of $50, due to the bad calculation, the method says 50+50 = 100 > 80 and so approves the order.
> Could you please review the attached patch (that fix the issue)?

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-484) Wrong total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-484?page=comments#action_12453597 ]

Jacques Le Roux commented on OFBIZ-484:
---------------------------------------

Jacopo,

Thanks for the explanation.

Strange : I tried another one with a $57 total. Received only $40 and this time the order was automatically approved. I can't see what was the difference with the 1st order but anyway yes there is something wrong there.

Somehting odd too : there is a cancel button for the payment. But if you use it after that you can't change order status (or am I missing something here ?). For what is this cancel button for ?

Working perfectly with you patch.

Thanks

> Wrong total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-484
> URL: http://issues.apache.org/jira/browse/OFBIZ-484
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jacopo Cappellato
> Assigned To: Jacopo Cappellato
> Attachments: offline_payment.patch
>
>
> It should fix an issue I've discovered in the way the total total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method.
> I think that the new amount received is summed two times to the total of already received offline amounts.
> For example, if the order total is $80, and you receive an offline payment of $50, due to the bad calculation, the method says 50+50 = 100 > 80 and so approves the order.
> Could you please review the attached patch (that fix the issue)?

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-484) Wrong total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-484?page=all ]

Jacopo Cappellato closed OFBIZ-484.
-----------------------------------

Resolution: Fixed

Jacques,

thanks for your help with this.
I've committed my patch in rev. 479750

> Wrong total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-484
> URL: http://issues.apache.org/jira/browse/OFBIZ-484
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jacopo Cappellato
> Assigned To: Jacopo Cappellato
> Attachments: offline_payment.patch
>
>
> It should fix an issue I've discovered in the way the total total of offline payments received is calculated by the org.ofbiz.order.OrderManagerEvents.receiveOfflinePayment(...) method.
> I think that the new amount received is summed two times to the total of already received offline amounts.
> For example, if the order total is $80, and you receive an offline payment of $50, due to the bad calculation, the method says 50+50 = 100 > 80 and so approves the order.
> Could you please review the attached patch (that fix the issue)?