OFBiz › OFBiz - Dev

[jira] [Created] (OFBIZ-4856) webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

34 messages Options

Pierre Smits

Re: [jira] [Commented] (OFBIZ-4856) webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup

Jacopo,

When do you stop pretending that committers like Hans work in cooperation
with the community. Recent comment in JIRA's (e.g. OFBIZ-4130) and commit
action (but not just those) clearly indicate that such committers are to
busy to be bothered to work with the community to make the project better.

You should ask yourself whether such committers are (still) a plus for the
project.

Regards,

Pierre

2012/5/7 Jacopo Cappellato <[hidden email]>

>
> On May 7, 2012, at 11:20 AM, Hans Bakker wrote:
>
> > Jacopo,
> >
> > no license issues: the file was copied over as is, including the
> header......
> >
> > the fact is: if we cannot copy code from an Apache project before
> completely investigating it...
>
> Ok, I have checked and the code that is causing the main problems is the
> one that makes use of the public static fields and that code doesn't come
> from Cocoon, so I have to assume it is your code.
>
> >
> > let me know, did you investigate the free marker code before including
> the jar?
>
> what do you mean? There is no relation between including an external jar
> file and copying some code from a source file and include it into your own
> source code without really understanding it. So please, stop here this
> attempt to attack to change topics and distract from the code in question.
>
> Jacopo
>
> >
> > Regards,
> > Hans
> >
> > P.S do not worry, apart from smaller changes I will avoid the framework
> as much as possible and always advertise that we are application
> programmers.
> >
> >
> > On 05/07/2012 03:59 PM, Jacopo Cappellato (JIRA) wrote:
> >> [
> https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269462#comment-13269462]
> >>
> >> Jacopo Cappellato commented on OFBIZ-4856:
> >> ------------------------------------------
> >>
> >> I am sorry Hans, but if you have copied code from another project we
> have to keep track of it and it is not an option to forget about this...
> this may cause license issues.
> >> We cannot commit code that is broken or only partially working and then
> pretend that others will fix it: do you and anyone else understand that
> this way of doing (at least in the last 2 years) is really unacceptable?
> >> If you do not know how to implement a thread safety class you should
> not touch the framework code.
> >> Questions to all committers: should we revert this work? or are we
> willing to refactor it to make it really usable? Volunteers?
> >>
> >>> webapp "tempfiles" is not successfully loaded because of
> java.io.FileNotFoundException during startup
> >>>
> -----------------------------------------------------------------------------------------------------
> >>>
> >>> Key: OFBIZ-4856
> >>> URL: https://issues.apache.org/jira/browse/OFBIZ-4856
> >>> Project: OFBiz
> >>> Issue Type: Bug
> >>> Components: framework
> >>> Affects Versions: SVN trunk
> >>> Reporter: Leon
> >>> Fix For: SVN trunk
> >>>
> >>> Attachments: OFBIZ-4856.patch
> >>>
> >>>
> >>> During startup, there's a "java.io.FileNotFoundException" thrown out
> when ofbiz trying to load webapp "tempfiles" which is defined by
> framework/images component.
> >>> The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file
> does not exist from the very first, catalina container will use default
> web.xml instead.
> >>> I apply a patch for this issue to catch the
> "java.io.FileNotFoundException" and bypass it.
> >> --
> >> This message is automatically generated by JIRA.
> >> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> >> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
> >>
> >>
> >
>
>

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4856) webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269569#comment-13269569 ]

Jacopo Cappellato commented on OFBIZ-4856:
------------------------------------------

Hans,

what is the purpose of the code in Captcha.deleteFile?

public static void deleteFile() {
if (CAPTCHA_FILE_PATH != null) {
File file = new File(CAPTCHA_FILE_PATH);
file.delete();
}
}

If I read it right it deletes the folder runtime/tempfiles/captcha/ rather than an individual file.

> webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup
> -----------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4856
> URL: https://issues.apache.org/jira/browse/OFBIZ-4856
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4856.patch
>
>
> During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component.
> The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead.
> I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

hans_bakker

Re: [jira] [Commented] (OFBIZ-4856) webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup

Jacopo,

i have no idea what you want to achieve with your questions. You are
talking about a commit i did more than 3 years ago which was done by one
of my people. Since 2005 i am on the project with more than 2000
commits so in average one per day. I hope you understand that i can just
guess, just as you, why this was done. Probably this was done as part of
a housekeeping job to delete all the files which were produced by
registrations.

I thought we agreed that nobody owns any code so please if you do not
like this code go ahead and change it? As I already mentioned we are
extremely busy and currently we just contribute the parts which
customers ask us to do and which do not need much extra time.

Regards,
Hans

On 05/07/2012 07:36 PM, Jacopo Cappellato (JIRA) wrote:

> [ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269569#comment-13269569 ]
>
> Jacopo Cappellato commented on OFBIZ-4856:
> ------------------------------------------
>
> Hans,
>
> what is the purpose of the code in Captcha.deleteFile?
>
>
> public static void deleteFile() {
> if (CAPTCHA_FILE_PATH != null) {
> File file = new File(CAPTCHA_FILE_PATH);
> file.delete();
> }
> }
>
>
> If I read it right it deletes the folder runtime/tempfiles/captcha/ rather than an individual file.
>
>
>
>> webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup
>> -----------------------------------------------------------------------------------------------------
>>
>> Key: OFBIZ-4856
>> URL: https://issues.apache.org/jira/browse/OFBIZ-4856
>> Project: OFBiz
>> Issue Type: Bug
>> Components: framework
>> Affects Versions: SVN trunk
>> Reporter: Leon
>> Fix For: SVN trunk
>>
>> Attachments: OFBIZ-4856.patch
>>
>>
>> During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component.
>> The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead.
>> I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it.
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4856) webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269632#comment-13269632 ]

Hans Bakker commented on OFBIZ-4856:
------------------------------------

Jacopo,

i have no idea what you want to achieve with your questions. You are
talking about a commit i did more than 3 years ago which was done by one
of my people. Since 2005 i am on the project with more than 2000
commits so in average one per day. I hope you understand that i can just
guess, just as you, why this was done. Probably this was done as part of
a housekeeping job to delete all the files which were produced by
registrations.

I thought we agreed that nobody owns any code so please if you do not
like this code go ahead and change it? As I already mentioned we are
extremely busy and currently we just contribute the parts which
customers ask us to do and which do not need much extra time.

Regards,
Hans

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4856) webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269644#comment-13269644 ]

Jacopo Cappellato commented on OFBIZ-4856:
------------------------------------------

I was simply trying to get some help as you may know better than me what this code was supposed to do; I didn't want to imply that you own the code, in fact you don't and I am already in the process of removing the problematic/dangerous code and reimplementing a part of it.
Scott is also refactoring another part of it and then we should be in a better spot.
Going back to my question and your answer:
"Probably this was done as part of
a housekeeping job to delete all the files which were produced by
registrations."

I don't think it is the case because that code is executed every time a new captcha image is created.

Nicolas Malin (Jira)

[jira] [Assigned] (OFBIZ-4856) webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-4856:
----------------------------------------

Assignee: Jacopo Cappellato

> webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup
> -----------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4856
> URL: https://issues.apache.org/jira/browse/OFBIZ-4856
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
> Assignee: Jacopo Cappellato
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4856.patch
>
>
> During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component.
> The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead.
> I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4856) webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273340#comment-13273340 ]

Jacopo Cappellato commented on OFBIZ-4856:
------------------------------------------

Fixed in rev. 1337202

> webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup
> -----------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4856
> URL: https://issues.apache.org/jira/browse/OFBIZ-4856
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
> Assignee: Jacopo Cappellato
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4856.patch
>
>
> During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component.
> The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead.
> I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it.

Nicolas Malin (Jira)

[jira] [Closed] (OFBIZ-4856) webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-4856.
------------------------------------

> webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup
> -----------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4856
> URL: https://issues.apache.org/jira/browse/OFBIZ-4856
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
> Assignee: Jacopo Cappellato
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4856.patch
>
>
> During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component.
> The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead.
> I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4856) webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273622#comment-13273622 ]

Jacques Le Roux commented on OFBIZ-4856:
----------------------------------------

Jacopo,

If you get a chance, please mention where it has been backported (and revisions if possible)

> webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup
> -----------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4856
> URL: https://issues.apache.org/jira/browse/OFBIZ-4856
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
> Assignee: Jacopo Cappellato
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4856.patch
>
>
> During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component.
> The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead.
> I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4856) webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273854#comment-13273854 ]

Jacopo Cappellato commented on OFBIZ-4856:
------------------------------------------

Full set of revisions for trunk: 1335047, 1337057, 1337058, 1337059, 1337202
Backported to 12.04 with revisions: 1337259, 1337264, 1337266, 1337267, 1337269
Backported to 11.04 with revisions: 1337335, 1337337, 1337338, 1337341, 1337345

> webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup
> -----------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4856
> URL: https://issues.apache.org/jira/browse/OFBIZ-4856
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
> Assignee: Jacopo Cappellato
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4856.patch
>
>
> During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component.
> The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead.
> I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4856) webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273867#comment-13273867 ]

Jacques Le Roux commented on OFBIZ-4856:
----------------------------------------

Thanks :)

> webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup
> -----------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4856
> URL: https://issues.apache.org/jira/browse/OFBIZ-4856
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
> Assignee: Jacopo Cappellato
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4856.patch
>
>
> During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component.
> The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead.
> I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it.

hans_bakker

Re: [jira] [Commented] (OFBIZ-4856) webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup

In reply to this post by Nicolas Malin (Jira)

Thank you Jacopo solving this problem.

Regards,
Hans

On 05/12/2012 01:09 PM, Jacopo Cappellato (JIRA) wrote:

> [ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273854#comment-13273854 ]
>
> Jacopo Cappellato commented on OFBIZ-4856:
> ------------------------------------------
>
> Full set of revisions for trunk: 1335047, 1337057, 1337058, 1337059, 1337202
> Backported to 12.04 with revisions: 1337259, 1337264, 1337266, 1337267, 1337269
> Backported to 11.04 with revisions: 1337335, 1337337, 1337338, 1337341, 1337345
>
>
>> webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup
>> -----------------------------------------------------------------------------------------------------
>>
>> Key: OFBIZ-4856
>> URL: https://issues.apache.org/jira/browse/OFBIZ-4856
>> Project: OFBiz
>> Issue Type: Bug
>> Components: framework
>> Affects Versions: SVN trunk
>> Reporter: Leon
>> Assignee: Jacopo Cappellato
>> Fix For: SVN trunk
>>
>> Attachments: OFBIZ-4856.patch
>>
>>
>> During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component.
>> The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead.
>> I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it.
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4856) webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273891#comment-13273891 ]

Hans Bakker commented on OFBIZ-4856:
------------------------------------

Thank you Jacopo solving this problem.

Regards,
Hans

> webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup
> -----------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4856
> URL: https://issues.apache.org/jira/browse/OFBIZ-4856
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
> Assignee: Jacopo Cappellato
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4856.patch
>
>
> During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component.
> The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead.
> I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4856) webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274668#comment-13274668 ]

Jacopo Cappellato commented on OFBIZ-4856:
------------------------------------------

You are welcome Hans; however most of the work was actually done by Scott.

> webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup
> -----------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4856
> URL: https://issues.apache.org/jira/browse/OFBIZ-4856
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
> Assignee: Jacopo Cappellato
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4856.patch
>
>
> During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component.
> The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead.
> I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it.