Leon created OFBIZ-4856:
--------------------------- Summary: webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup Key: OFBIZ-4856 URL: https://issues.apache.org/jira/browse/OFBIZ-4856 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Fix For: SVN trunk Attachments: OFBIZ-4856.patch During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4856: ------------------------ Attachment: OFBIZ-4856.patch > webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup > ----------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4856 > URL: https://issues.apache.org/jira/browse/OFBIZ-4856 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Fix For: SVN trunk > > Attachments: OFBIZ-4856.patch > > > During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. > The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. > I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269241#comment-13269241 ] Jacopo Cappellato commented on OFBIZ-4856: ------------------------------------------ Unfortunately I didn't have time to review all the work around the "tempfiles" application but I have some doubts about the way it is implemented... in my opinion it should be reviewed carefully. > webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup > ----------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4856 > URL: https://issues.apache.org/jira/browse/OFBIZ-4856 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Fix For: SVN trunk > > Attachments: OFBIZ-4856.patch > > > During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. > The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. > I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269370#comment-13269370 ] Jacques Le Roux commented on OFBIZ-4856: ---------------------------------------- ANyway Jacopo, this patch can't hurt. I propose to commit it, OK? > webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup > ----------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4856 > URL: https://issues.apache.org/jira/browse/OFBIZ-4856 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Fix For: SVN trunk > > Attachments: OFBIZ-4856.patch > > > During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. > The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. > I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269374#comment-13269374 ] Jacques Le Roux commented on OFBIZ-4856: ---------------------------------------- Initial commit for the tempfiles stuff was http://svn.apache.org/viewvc?view=revision&revision=736896 > webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup > ----------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4856 > URL: https://issues.apache.org/jira/browse/OFBIZ-4856 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Fix For: SVN trunk > > Attachments: OFBIZ-4856.patch > > > During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. > The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. > I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269416#comment-13269416 ] Jacopo Cappellato commented on OFBIZ-4856: ------------------------------------------ What I don't like about committing this fix is that it will fix the error and hide the bad design that was causing it. I had a quick look at the revision that Jacques mentioned (thank you) and I have noticed some very bad code: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/src/org/ofbiz/common/Captcha.java?view=markup&pathrev=736896 this class is not thread safe and if fact I already encountered a bad bug in production because of this; there are also some formatting issues... I understand that this class has been copied from another project (did we mention this in our notice file? I don't remember if it is mandatory but we should check) but rev. 736896 is a perfect example of code that should have never been committed in this way because it is dangerous, it doesn't meet minimal quality requirements. > webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup > ----------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4856 > URL: https://issues.apache.org/jira/browse/OFBIZ-4856 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Fix For: SVN trunk > > Attachments: OFBIZ-4856.patch > > > During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. > The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. > I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
This is a pretty strong statement about another Apache project....
Regards, Hans On 05/07/2012 02:06 PM, Jacopo Cappellato (JIRA) wrote: > [ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269416#comment-13269416 ] > > Jacopo Cappellato commented on OFBIZ-4856: > ------------------------------------------ > > What I don't like about committing this fix is that it will fix the error and hide the bad design that was causing it. > I had a quick look at the revision that Jacques mentioned (thank you) and I have noticed some very bad code: > > http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/src/org/ofbiz/common/Captcha.java?view=markup&pathrev=736896 > > this class is not thread safe and if fact I already encountered a bad bug in production because of this; there are also some formatting issues... I understand that this class has been copied from another project (did we mention this in our notice file? I don't remember if it is mandatory but we should check) but rev. 736896 is a perfect example of code that should have never been committed in this way because it is dangerous, it doesn't meet minimal quality requirements. > > > > >> webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup >> ----------------------------------------------------------------------------------------------------- >> >> Key: OFBIZ-4856 >> URL: https://issues.apache.org/jira/browse/OFBIZ-4856 >> Project: OFBiz >> Issue Type: Bug >> Components: framework >> Affects Versions: SVN trunk >> Reporter: Leon >> Fix For: SVN trunk >> >> Attachments: OFBIZ-4856.patch >> >> >> During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. >> The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. >> I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it. > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa > For more information on JIRA, see: http://www.atlassian.com/software/jira > > |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269431#comment-13269431 ] Hans Bakker commented on OFBIZ-4856: ------------------------------------ This is a pretty strong statement about another Apache project.... Regards, Hans > webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup > ----------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4856 > URL: https://issues.apache.org/jira/browse/OFBIZ-4856 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Fix For: SVN trunk > > Attachments: OFBIZ-4856.patch > > > During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. > The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. > I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269439#comment-13269439 ] Jacopo Cappellato commented on OFBIZ-4856: ------------------------------------------ Yep, that code is really awful; I had a look at the source files referenced in Captcha.java: http://cocoon.apache.org/2.2/blocks/captcha/1.0/1436_1_1.html but I couldn't find that class... is the reference the right one? By the way, there are two possibilities: * the Cocoon code you have copied is really bad written * the Cocoon code was not intended to be used in a multi threaded environment like OFBiz is doing In both ways the code as is should have never been committed. Hans, apart from commenting my statements, do you have anything to say to the thread unsafety of this class? > webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup > ----------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4856 > URL: https://issues.apache.org/jira/browse/OFBIZ-4856 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Fix For: SVN trunk > > Attachments: OFBIZ-4856.patch > > > During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. > The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. > I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
Jacopo,
In general when we need an important function in OFBiz which is missing like Captcha, we look in an existing Apache project first. If we find it, we use it without much checking. I personally do not have enough knowledge to provide you with a comment on thread "unsafety." Regards, Hans On 05/07/2012 02:55 PM, Jacopo Cappellato (JIRA) wrote: > [ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269439#comment-13269439 ] > > Jacopo Cappellato commented on OFBIZ-4856: > ------------------------------------------ > > Yep, that code is really awful; I had a look at the source files referenced in Captcha.java: > > http://cocoon.apache.org/2.2/blocks/captcha/1.0/1436_1_1.html > > but I couldn't find that class... is the reference the right one? > By the way, there are two possibilities: > * the Cocoon code you have copied is really bad written > * the Cocoon code was not intended to be used in a multi threaded environment like OFBiz is doing > > In both ways the code as is should have never been committed. > Hans, apart from commenting my statements, do you have anything to say to the thread unsafety of this class? > >> webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup >> ----------------------------------------------------------------------------------------------------- >> >> Key: OFBIZ-4856 >> URL: https://issues.apache.org/jira/browse/OFBIZ-4856 >> Project: OFBiz >> Issue Type: Bug >> Components: framework >> Affects Versions: SVN trunk >> Reporter: Leon >> Fix For: SVN trunk >> >> Attachments: OFBIZ-4856.patch >> >> >> During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. >> The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. >> I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it. > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa > For more information on JIRA, see: http://www.atlassian.com/software/jira > > |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269443#comment-13269443 ] Hans Bakker commented on OFBIZ-4856: ------------------------------------ Jacopo, In general when we need an important function in OFBiz which is missing like Captcha, we look in an existing Apache project first. If we find it, we use it without much checking. I personally do not have enough knowledge to provide you with a comment on thread "unsafety." Regards, Hans > webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup > ----------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4856 > URL: https://issues.apache.org/jira/browse/OFBIZ-4856 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Fix For: SVN trunk > > Attachments: OFBIZ-4856.patch > > > During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. > The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. > I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269444#comment-13269444 ] Jacques Le Roux commented on OFBIZ-4856: ---------------------------------------- Jacopo, Just curious, what is the relation between a missing web.xml file an not being thread safe? > webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup > ----------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4856 > URL: https://issues.apache.org/jira/browse/OFBIZ-4856 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Fix For: SVN trunk > > Attachments: OFBIZ-4856.patch > > > During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. > The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. > I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269448#comment-13269448 ] Jacopo Cappellato commented on OFBIZ-4856: ------------------------------------------ Hans: could you please send me a reference (a URL to the source file in svn would be great) to the Cocoon file that you copied? I would like to review it before taking a decision about Captcha.java. Jacques: there is no relation between the patch and the bad code that I am concerned about; the whole design is wrong and we could decide to fix it by refactoring it... at that point the webapp mounted from the runtime folder (?!) may go away, suppressing the error at the root. > webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup > ----------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4856 > URL: https://issues.apache.org/jira/browse/OFBIZ-4856 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Fix For: SVN trunk > > Attachments: OFBIZ-4856.patch > > > During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. > The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. > I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269449#comment-13269449 ] Jacques Le Roux commented on OFBIZ-4856: ---------------------------------------- Makes sense, thank you > webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup > ----------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4856 > URL: https://issues.apache.org/jira/browse/OFBIZ-4856 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Fix For: SVN trunk > > Attachments: OFBIZ-4856.patch > > > During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. > The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. > I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
Sorry Jacopo, that is too far back to know exactly where, at that time
we got it from, but sure it was an apache project. Since you did not agree to it anyway, replace it with whatever you want? Regards, Hans On 05/07/2012 03:15 PM, Jacopo Cappellato (JIRA) wrote: > [ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269448#comment-13269448 ] > > Jacopo Cappellato commented on OFBIZ-4856: > ------------------------------------------ > > Hans: could you please send me a reference (a URL to the source file in svn would be great) to the Cocoon file that you copied? I would like to review it before taking a decision about Captcha.java. > > Jacques: there is no relation between the patch and the bad code that I am concerned about; the whole design is wrong and we could decide to fix it by refactoring it... at that point the webapp mounted from the runtime folder (?!) may go away, suppressing the error at the root. > >> webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup >> ----------------------------------------------------------------------------------------------------- >> >> Key: OFBIZ-4856 >> URL: https://issues.apache.org/jira/browse/OFBIZ-4856 >> Project: OFBiz >> Issue Type: Bug >> Components: framework >> Affects Versions: SVN trunk >> Reporter: Leon >> Fix For: SVN trunk >> >> Attachments: OFBIZ-4856.patch >> >> >> During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. >> The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. >> I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it. > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa > For more information on JIRA, see: http://www.atlassian.com/software/jira > > |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269456#comment-13269456 ] Hans Bakker commented on OFBIZ-4856: ------------------------------------ Sorry Jacopo, that is too far back to know exactly where, at that time we got it from, but sure it was an apache project. Since you did not agree to it anyway, replace it with whatever you want? Regards, Hans > webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup > ----------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4856 > URL: https://issues.apache.org/jira/browse/OFBIZ-4856 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Fix For: SVN trunk > > Attachments: OFBIZ-4856.patch > > > During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. > The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. > I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269462#comment-13269462 ] Jacopo Cappellato commented on OFBIZ-4856: ------------------------------------------ I am sorry Hans, but if you have copied code from another project we have to keep track of it and it is not an option to forget about this... this may cause license issues. We cannot commit code that is broken or only partially working and then pretend that others will fix it: do you and anyone else understand that this way of doing (at least in the last 2 years) is really unacceptable? If you do not know how to implement a thread safety class you should not touch the framework code. Questions to all committers: should we revert this work? or are we willing to refactor it to make it really usable? Volunteers? > webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup > ----------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4856 > URL: https://issues.apache.org/jira/browse/OFBIZ-4856 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Fix For: SVN trunk > > Attachments: OFBIZ-4856.patch > > > During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. > The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. > I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
Jacopo,
no license issues: the file was copied over as is, including the header...... the fact is: if we cannot copy code from an Apache project before completely investigating it... let me know, did you investigate the free marker code before including the jar? Regards, Hans P.S do not worry, apart from smaller changes I will avoid the framework as much as possible and always advertise that we are application programmers. On 05/07/2012 03:59 PM, Jacopo Cappellato (JIRA) wrote: > [ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269462#comment-13269462 ] > > Jacopo Cappellato commented on OFBIZ-4856: > ------------------------------------------ > > I am sorry Hans, but if you have copied code from another project we have to keep track of it and it is not an option to forget about this... this may cause license issues. > We cannot commit code that is broken or only partially working and then pretend that others will fix it: do you and anyone else understand that this way of doing (at least in the last 2 years) is really unacceptable? > If you do not know how to implement a thread safety class you should not touch the framework code. > Questions to all committers: should we revert this work? or are we willing to refactor it to make it really usable? Volunteers? > >> webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup >> ----------------------------------------------------------------------------------------------------- >> >> Key: OFBIZ-4856 >> URL: https://issues.apache.org/jira/browse/OFBIZ-4856 >> Project: OFBiz >> Issue Type: Bug >> Components: framework >> Affects Versions: SVN trunk >> Reporter: Leon >> Fix For: SVN trunk >> >> Attachments: OFBIZ-4856.patch >> >> >> During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. >> The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. >> I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it. > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa > For more information on JIRA, see: http://www.atlassian.com/software/jira > > |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269473#comment-13269473 ] Hans Bakker commented on OFBIZ-4856: ------------------------------------ Jacopo, no license issues: the file was copied over as is, including the header...... the fact is: if we cannot copy code from an Apache project before completely investigating it... let me know, did you investigate the free marker code before including the jar? Regards, Hans P.S do not worry, apart from smaller changes I will avoid the framework as much as possible and always advertise that we are application programmers. > webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup > ----------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4856 > URL: https://issues.apache.org/jira/browse/OFBIZ-4856 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Leon > Fix For: SVN trunk > > Attachments: OFBIZ-4856.patch > > > During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. > The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. > I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by hans_bakker
On May 7, 2012, at 11:20 AM, Hans Bakker wrote: > Jacopo, > > no license issues: the file was copied over as is, including the header...... > > the fact is: if we cannot copy code from an Apache project before completely investigating it... Ok, I have checked and the code that is causing the main problems is the one that makes use of the public static fields and that code doesn't come from Cocoon, so I have to assume it is your code. > > let me know, did you investigate the free marker code before including the jar? what do you mean? There is no relation between including an external jar file and copying some code from a source file and include it into your own source code without really understanding it. So please, stop here this attempt to attack to change topics and distract from the code in question. Jacopo > > Regards, > Hans > > P.S do not worry, apart from smaller changes I will avoid the framework as much as possible and always advertise that we are application programmers. > > > On 05/07/2012 03:59 PM, Jacopo Cappellato (JIRA) wrote: >> [ https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269462#comment-13269462 ] >> >> Jacopo Cappellato commented on OFBIZ-4856: >> ------------------------------------------ >> >> I am sorry Hans, but if you have copied code from another project we have to keep track of it and it is not an option to forget about this... this may cause license issues. >> We cannot commit code that is broken or only partially working and then pretend that others will fix it: do you and anyone else understand that this way of doing (at least in the last 2 years) is really unacceptable? >> If you do not know how to implement a thread safety class you should not touch the framework code. >> Questions to all committers: should we revert this work? or are we willing to refactor it to make it really usable? Volunteers? >> >>> webapp "tempfiles" is not successfully loaded because of java.io.FileNotFoundException during startup >>> ----------------------------------------------------------------------------------------------------- >>> >>> Key: OFBIZ-4856 >>> URL: https://issues.apache.org/jira/browse/OFBIZ-4856 >>> Project: OFBiz >>> Issue Type: Bug >>> Components: framework >>> Affects Versions: SVN trunk >>> Reporter: Leon >>> Fix For: SVN trunk >>> >>> Attachments: OFBIZ-4856.patch >>> >>> >>> During startup, there's a "java.io.FileNotFoundException" thrown out when ofbiz trying to load webapp "tempfiles" which is defined by framework/images component. >>> The file not found is "runtime/tempfiles/WEB-INF/web.xml". This file does not exist from the very first, catalina container will use default web.xml instead. >>> I apply a patch for this issue to catch the "java.io.FileNotFoundException" and bypass it. >> -- >> This message is automatically generated by JIRA. >> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa >> For more information on JIRA, see: http://www.atlassian.com/software/jira >> >> > |
Free forum by Nabble | Edit this page |