[jira] [Created] (OFBIZ-4955) Add rtl layouts to the pos application

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (OFBIZ-4955) Add rtl layouts to the pos application

Nicolas Malin (Jira)
Mohamed Amine AZZI created OFBIZ-4955:
-----------------------------------------

             Summary: Add rtl layouts to the pos application
                 Key: OFBIZ-4955
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4955
             Project: OFBiz
          Issue Type: New Feature
          Components: specialpurpose/pos
    Affects Versions: SVN trunk
            Reporter: Mohamed Amine AZZI
            Priority: Minor
             Fix For: SVN trunk


Add new screens layouts for right to left languages (arabic).
- Added some code to ensure that elements are added from right to left in the Journal table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-4955) Add rtl layouts to the pos application

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mohamed Amine AZZI updated OFBIZ-4955:
--------------------------------------

    Attachment: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch
   

> Add rtl layouts to the pos application
> --------------------------------------
>
>                 Key: OFBIZ-4955
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4955
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>            Reporter: Mohamed Amine AZZI
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch
>
>
> Add new screens layouts for right to left languages (arabic).
> - Added some code to ensure that elements are added from right to left in the Journal table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-4955) Add rtl layouts to the pos application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mohamed Amine AZZI updated OFBIZ-4955:
--------------------------------------

    Attachment:     (was: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch)
   

> Add rtl layouts to the pos application
> --------------------------------------
>
>                 Key: OFBIZ-4955
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4955
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>            Reporter: Mohamed Amine AZZI
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch
>
>
> Add new screens layouts for right to left languages (arabic).
> - Added some code to ensure that elements are added from right to left in the Journal table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-4955) Add rtl layouts to the pos application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mohamed Amine AZZI updated OFBIZ-4955:
--------------------------------------

    Attachment: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch
   

> Add rtl layouts to the pos application
> --------------------------------------
>
>                 Key: OFBIZ-4955
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4955
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>            Reporter: Mohamed Amine AZZI
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch
>
>
> Add new screens layouts for right to left languages (arabic).
> - Added some code to ensure that elements are added from right to left in the Journal table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Assigned] (OFBIZ-4955) Add rtl layouts to the pos application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-4955:
--------------------------------------

    Assignee: Jacques Le Roux
   

> Add rtl layouts to the pos application
> --------------------------------------
>
>                 Key: OFBIZ-4955
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4955
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>            Reporter: Mohamed Amine AZZI
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch
>
>
> Add new screens layouts for right to left languages (arabic).
> - Added some code to ensure that elements are added from right to left in the Journal table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-4955) Add rtl layouts to the pos application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408384#comment-13408384 ]

Jacques Le Roux commented on OFBIZ-4955:
----------------------------------------

1st quick review
* Please create your patch from root folder and not specialpurpose/pos folder
* It seems a lof ot PosTransaction.java changes are not intended... Check also your other files...
               

> Add rtl layouts to the pos application
> --------------------------------------
>
>                 Key: OFBIZ-4955
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4955
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>            Reporter: Mohamed Amine AZZI
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch
>
>
> Add new screens layouts for right to left languages (arabic).
> - Added some code to ensure that elements are added from right to left in the Journal table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-4955) Add rtl layouts to the pos application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408642#comment-13408642 ]

Mohamed Amine AZZI commented on OFBIZ-4955:
-------------------------------------------

Ok i will check and recreate the patch.
               

> Add rtl layouts to the pos application
> --------------------------------------
>
>                 Key: OFBIZ-4955
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4955
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>            Reporter: Mohamed Amine AZZI
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch
>
>
> Add new screens layouts for right to left languages (arabic).
> - Added some code to ensure that elements are added from right to left in the Journal table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-4955) Add rtl layouts to the pos application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mohamed Amine AZZI updated OFBIZ-4955:
--------------------------------------

    Attachment:     (was: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch)
   

> Add rtl layouts to the pos application
> --------------------------------------
>
>                 Key: OFBIZ-4955
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4955
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>            Reporter: Mohamed Amine AZZI
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch
>
>
> Add new screens layouts for right to left languages (arabic).
> - Added some code to ensure that elements are added from right to left in the Journal table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-4955) Add rtl layouts to the pos application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mohamed Amine AZZI updated OFBIZ-4955:
--------------------------------------

    Attachment: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch
   

> Add rtl layouts to the pos application
> --------------------------------------
>
>                 Key: OFBIZ-4955
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4955
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>            Reporter: Mohamed Amine AZZI
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch
>
>
> Add new screens layouts for right to left languages (arabic).
> - Added some code to ensure that elements are added from right to left in the Journal table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (OFBIZ-4955) Add rtl layouts to the pos application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408642#comment-13408642 ]

Mohamed Amine AZZI edited comment on OFBIZ-4955 at 7/7/12 7:27 PM:
-------------------------------------------------------------------

Actually I was working on a different branch, and the merge tool did merge the space differences which i did not want to do. I redid the merge and the build seems ok, i even started the pos and it seems working fine.
the patch is recreated from the ofbiz project root.
               
      was (Author: bakhtout):
    Ok i will check and recreate the patch.
                 

> Add rtl layouts to the pos application
> --------------------------------------
>
>                 Key: OFBIZ-4955
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4955
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>            Reporter: Mohamed Amine AZZI
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch
>
>
> Add new screens layouts for right to left languages (arabic).
> - Added some code to ensure that elements are added from right to left in the Journal table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-4955) Add rtl layouts to the pos application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408868#comment-13408868 ]

Jacques Le Roux commented on OFBIZ-4955:
----------------------------------------

Mohamed,

2nd incomplete review and not tested yet, almost ready, few simple issues
* PosTransaction.java: you saved with tabs instead of 4 spaces. Journal.java is OK so maybe not your EDI (Eclipse?) configiguration. In case (re-)read [General Formatting Conventions|https://cwiki.apache.org/confluence/display/OFBADMIN/Coding+Conventions]
* JournalLineParams.java misses a license header
* Trivial: you missed to check the ASL granted license when attaching your patch. PLease (re-)read [How to create a Jira issue|https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices]
{quote}
Don't forget to grant the license to Apache. If not, your patch can't be included in OFBiz. There is a radio button to select when you're choosing your patch (Grant license to ASF for inclusion in ASF works (as per the Apache License §5)). Then a small feather will appear next to your patch.
{quote}

               

> Add rtl layouts to the pos application
> --------------------------------------
>
>                 Key: OFBIZ-4955
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4955
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>            Reporter: Mohamed Amine AZZI
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch
>
>
> Add new screens layouts for right to left languages (arabic).
> - Added some code to ensure that elements are added from right to left in the Journal table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-4955) Add rtl layouts to the pos application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409064#comment-13409064 ]

Mohamed Amine AZZI commented on OFBIZ-4955:
-------------------------------------------

Jaques,

Indeed I used Idea Interllij and did not sustain myself from pressing the shortcut to reindent everything. I will reinsert the code using eclipse after proper configurations according to convention. sorry for the miss.
As for grating the ASL to the attachment patch I did not forget it, but it doens't matter as I need to remake ut ;)

               

> Add rtl layouts to the pos application
> --------------------------------------
>
>                 Key: OFBIZ-4955
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4955
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>            Reporter: Mohamed Amine AZZI
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch
>
>
> Add new screens layouts for right to left languages (arabic).
> - Added some code to ensure that elements are added from right to left in the Journal table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-4955) Add rtl layouts to the pos application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mohamed Amine AZZI updated OFBIZ-4955:
--------------------------------------

    Attachment:     (was: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch)
   

> Add rtl layouts to the pos application
> --------------------------------------
>
>                 Key: OFBIZ-4955
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4955
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>            Reporter: Mohamed Amine AZZI
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> Add new screens layouts for right to left languages (arabic).
> - Added some code to ensure that elements are added from right to left in the Journal table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Comment Edited] (OFBIZ-4955) Add rtl layouts to the pos application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409064#comment-13409064 ]

Mohamed Amine AZZI edited comment on OFBIZ-4955 at 7/9/12 8:13 AM:
-------------------------------------------------------------------

Jaques,

Indeed I used Idea Interllij and did not sustain myself from pressing the shortcut to reindent everything. I will reinsert the code using eclipse after proper configurations according to convention. sorry for the miss.
As for granting the ASL to the attachment patch I did not forget it, but it doens't matter as I need to remake it ;)

               
      was (Author: bakhtout):
    Jaques,

Indeed I used Idea Interllij and did not sustain myself from pressing the shortcut to reindent everything. I will reinsert the code using eclipse after proper configurations according to convention. sorry for the miss.
As for grating the ASL to the attachment patch I did not forget it, but it doens't matter as I need to remake ut ;)

                 

> Add rtl layouts to the pos application
> --------------------------------------
>
>                 Key: OFBIZ-4955
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4955
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>            Reporter: Mohamed Amine AZZI
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> Add new screens layouts for right to left languages (arabic).
> - Added some code to ensure that elements are added from right to left in the Journal table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-4955) Add rtl layouts to the pos application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mohamed Amine AZZI updated OFBIZ-4955:
--------------------------------------

    Attachment: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch

PosTransation class reverted to trunk last revision and the modified lines were added again line by line by hand instead of the merge tool. the patch seems ok concerning the tabs now.
I added the apache license header to the new class.
I checked the ASF licence checkbox for patch attachment.
               

> Add rtl layouts to the pos application
> --------------------------------------
>
>                 Key: OFBIZ-4955
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4955
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>            Reporter: Mohamed Amine AZZI
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch
>
>
> Add new screens layouts for right to left languages (arabic).
> - Added some code to ensure that elements are added from right to left in the Journal table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-4955) Add rtl layouts to the pos application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4955:
-----------------------------------

    Attachment: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch

Ha sorry, I spotted it but did not look in it closer enough. I will not apply your change for xpos.properties which has been unintentionally committed at [r1328727|http://svn.apache.org/viewvc?view=revision&revision=1328727]

So please find attached a replacement patch that I already applied on my testing worky copy instance but did not test yet. Only change from yours should be: xpos.properties reverted to pre r1328727. Please double-check

Thanks
               

> Add rtl layouts to the pos application
> --------------------------------------
>
>                 Key: OFBIZ-4955
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4955
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>            Reporter: Mohamed Amine AZZI
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch, OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch
>
>
> Add new screens layouts for right to left languages (arabic).
> - Added some code to ensure that elements are added from right to left in the Journal table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-4955) Add rtl layouts to the pos application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410199#comment-13410199 ]

Mohamed Amine AZZI commented on OFBIZ-4955:
-------------------------------------------

Yes seems containing all my changes. you can apply it and test.

Regards.
               

> Add rtl layouts to the pos application
> --------------------------------------
>
>                 Key: OFBIZ-4955
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4955
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>            Reporter: Mohamed Amine AZZI
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch, OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch
>
>
> Add new screens layouts for right to left languages (arabic).
> - Added some code to ensure that elements are added from right to left in the Journal table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (OFBIZ-4955) Add rtl layouts to the pos application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4955.
----------------------------------

    Resolution: Fixed

Thanks Mohamed,

Your patch is in trunk at revision: 1360930

BTW you did not need to add any posstyles, like it was done for Chinese?
See XuiContainer.java[160]

               

> Add rtl layouts to the pos application
> --------------------------------------
>
>                 Key: OFBIZ-4955
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4955
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>            Reporter: Mohamed Amine AZZI
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch, OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch
>
>
> Add new screens layouts for right to left languages (arabic).
> - Added some code to ensure that elements are added from right to left in the Journal table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-4955) Add rtl layouts to the pos application

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415045#comment-13415045 ]

Mohamed Amine AZZI commented on OFBIZ-4955:
-------------------------------------------

Jaques,

Thanks, for commiting my work. As for the style; the default one suits me, the font seems ok on my dev machine. If ever some future customers won't like it, i would have to add a style for arabic.
               

> Add rtl layouts to the pos application
> --------------------------------------
>
>                 Key: OFBIZ-4955
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4955
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: specialpurpose/pos
>    Affects Versions: SVN trunk
>            Reporter: Mohamed Amine AZZI
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch, OFBIZ-4955_Add_rtl_layouts_to_pos_application.patch
>
>
> Add new screens layouts for right to left languages (arabic).
> - Added some code to ensure that elements are added from right to left in the Journal table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira