[
https://issues.apache.org/jira/browse/OFBIZ-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414325#comment-13414325 ]
Adrian Crum edited comment on OFBIZ-4967 at 7/14/12 9:41 AM:
-------------------------------------------------------------
Line 254: A semaphore lock is acquired outside of a try-catch block, so if any exceptions are thrown the lock will not be released.
Line 564: A semaphore is unlocked outside of a try-catch block, so if any exceptions are thrown, the transaction is not resumed. This may be intentional - it depends on whether or not a failed unlock attempt should abort everything.
Line 360, 556: Concrete class GenericDelegator is referenced, should reference the Delegator interface instead.
Line 548: Thrown exception will prevent Delegator state restoration on line 556.
was (Author:
[hidden email]):
Line 254: A semaphore lock is acquired outside of a try-catch block, so if any exceptions are thrown the lock will not be released.
> Multiple Issues In ServiceDispatcher.runSync Method
> ---------------------------------------------------
>
> Key: OFBIZ-4967
> URL:
https://issues.apache.org/jira/browse/OFBIZ-4967> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Adrian Crum
> Priority: Minor
>
> There are multiple problems with the runSync method in ServiceDispatcher.java. Details in comments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspaFor more information on JIRA, see:
http://www.atlassian.com/software/jira
Locked
