|
Tom Burns created OFBIZ-4960:
-------------------------------- Summary: Example Application Issues Key: OFBIZ-4960 URL: https://issues.apache.org/jira/browse/OFBIZ-4960 Project: OFBiz Issue Type: Bug Affects Versions: Release 10.04, SVN trunk Environment: SVN Trunk Reporter: Tom Burns Priority: Minor Attachments: OFBIZ-4960 Example.patch There are several defects in the Example application under the Example and Feature menus. Problem path 1: Find Example > Find Example Select EX01 Click Items Tab (or Features) Click Example Tab Expected: Example Details form in the context of the Example menus Actual: New Example Form under Example Application menus Problem path 2: Example > click New Example Enter a new example Expected: Example Details form to add Items and Features to the New Example Actual: Example page filtered on newly created example (this is a problem for a new user who will not know how to clear the Example Id from the Search Options form. A better path would be to go to the edit forms where the user can add additional information on the example i.e. Items and Features) Problem path 3: Features > New Example Features Enter a Description > Click Create Click Examples Expected: Examples to appear under the Examples menu. Actual: New Example Feature opens under the Example Application menu. Problem 3 Cont: Enter a Type and Sequence Num Click Add Expected: Create a new Example Feature Appl Actual: Error Problem 3: Error missing exampleFeatureId -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
[ https://issues.apache.org/jira/browse/OFBIZ-4960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Burns updated OFBIZ-4960: ----------------------------- Attachment: OFBIZ-4960 Example.patch > Example Application Issues > -------------------------- > > Key: OFBIZ-4960 > URL: https://issues.apache.org/jira/browse/OFBIZ-4960 > Project: OFBiz > Issue Type: Bug > Affects Versions: Release 10.04, SVN trunk > Environment: SVN Trunk > Reporter: Tom Burns > Priority: Minor > Attachments: OFBIZ-4960 Example.patch > > > There are several defects in the Example application under the Example and Feature menus. > Problem path 1: > Find Example > Find Example > Select EX01 > Click Items Tab (or Features) > Click Example Tab > Expected: Example Details form in the context of the Example menus > Actual: New Example Form under Example Application menus > Problem path 2: > Example > click New Example > Enter a new example > Expected: Example Details form to add Items and Features to the New Example > Actual: Example page filtered on newly created example > (this is a problem for a new user who will not know how to clear the Example Id from the Search Options form. A better path would be to go to the edit forms where the user can add additional information on the example i.e. Items and Features) > Problem path 3: > Features > New Example Features > Enter a Description > Click Create > Click Examples > Expected: Examples to appear under the Examples menu. > Actual: New Example Feature opens under the Example Application menu. > Problem 3 Cont: > Enter a Type and Sequence Num > Click Add > Expected: Create a new Example Feature Appl > Actual: Error Problem 3: Error missing exampleFeatureId -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414426#comment-13414426 ] Jacques Le Roux commented on OFBIZ-4960: ---------------------------------------- Hi Tom, I don't reproduce the 2 1st issues in R10.04 but in trunk. When applying your patch they are solved. This, I guess, was due to the introduction by Sascha of the layered example creation form. Now for the 3rd case, I'm not quite sure if # Expected: Examples to appear under the Examples menu. is expected or not. For 2 reasons: ** the url in R10.04 is something clean like example/control/EditExampleFeatureExampleAppls?exampleFeatureId=10002 (seems intended) ** you can still get to the Examples menu using the Examples menu. Did you change anything for that? I like your fix for the Error Problem 3, this was already like that in R9.04 (you had to get back to feature menu then examples to see it). So I think it's a good fix. I did a cursorily review and did not test for side effects yet... > Example Application Issues > -------------------------- > > Key: OFBIZ-4960 > URL: https://issues.apache.org/jira/browse/OFBIZ-4960 > Project: OFBiz > Issue Type: Bug > Affects Versions: Release 10.04, SVN trunk > Environment: SVN Trunk > Reporter: Tom Burns > Priority: Minor > Attachments: OFBIZ-4960 Example.patch > > > There are several defects in the Example application under the Example and Feature menus. > Problem path 1: > Find Example > Find Example > Select EX01 > Click Items Tab (or Features) > Click Example Tab > Expected: Example Details form in the context of the Example menus > Actual: New Example Form under Example Application menus > Problem path 2: > Example > click New Example > Enter a new example > Expected: Example Details form to add Items and Features to the New Example > Actual: Example page filtered on newly created example > (this is a problem for a new user who will not know how to clear the Example Id from the Search Options form. A better path would be to go to the edit forms where the user can add additional information on the example i.e. Items and Features) > Problem path 3: > Features > New Example Features > Enter a Description > Click Create > Click Examples > Expected: Examples to appear under the Examples menu. > Actual: New Example Feature opens under the Example Application menu. > Problem 3 Cont: > Enter a Type and Sequence Num > Click Add > Expected: Create a new Example Feature Appl > Actual: Error Problem 3: Error missing exampleFeatureId -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414440#comment-13414440 ] Tom Burns commented on OFBIZ-4960: ---------------------------------- Jacques, I see your point on case 3. It would be fine the way it was. Thanks for the review. Tom > Example Application Issues > -------------------------- > > Key: OFBIZ-4960 > URL: https://issues.apache.org/jira/browse/OFBIZ-4960 > Project: OFBiz > Issue Type: Bug > Affects Versions: Release 10.04, SVN trunk > Environment: SVN Trunk > Reporter: Tom Burns > Priority: Minor > Attachments: OFBIZ-4960 Example.patch > > > There are several defects in the Example application under the Example and Feature menus. > Problem path 1: > Find Example > Find Example > Select EX01 > Click Items Tab (or Features) > Click Example Tab > Expected: Example Details form in the context of the Example menus > Actual: New Example Form under Example Application menus > Problem path 2: > Example > click New Example > Enter a new example > Expected: Example Details form to add Items and Features to the New Example > Actual: Example page filtered on newly created example > (this is a problem for a new user who will not know how to clear the Example Id from the Search Options form. A better path would be to go to the edit forms where the user can add additional information on the example i.e. Items and Features) > Problem path 3: > Features > New Example Features > Enter a Description > Click Create > Click Examples > Expected: Examples to appear under the Examples menu. > Actual: New Example Feature opens under the Example Application menu. > Problem 3 Cont: > Enter a Type and Sequence Num > Click Add > Expected: Create a new Example Feature Appl > Actual: Error Problem 3: Error missing exampleFeatureId -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414444#comment-13414444 ] Jacques Le Roux commented on OFBIZ-4960: ---------------------------------------- Tom, Are the changes in specialpurpose/example/widget/example/CommonScreens.xml really needed, related effects? > Example Application Issues > -------------------------- > > Key: OFBIZ-4960 > URL: https://issues.apache.org/jira/browse/OFBIZ-4960 > Project: OFBiz > Issue Type: Bug > Affects Versions: Release 10.04, SVN trunk > Environment: SVN Trunk > Reporter: Tom Burns > Priority: Minor > Attachments: OFBIZ-4960 Example.patch > > > There are several defects in the Example application under the Example and Feature menus. > Problem path 1: > Find Example > Find Example > Select EX01 > Click Items Tab (or Features) > Click Example Tab > Expected: Example Details form in the context of the Example menus > Actual: New Example Form under Example Application menus > Problem path 2: > Example > click New Example > Enter a new example > Expected: Example Details form to add Items and Features to the New Example > Actual: Example page filtered on newly created example > (this is a problem for a new user who will not know how to clear the Example Id from the Search Options form. A better path would be to go to the edit forms where the user can add additional information on the example i.e. Items and Features) > Problem path 3: > Features > New Example Features > Enter a Description > Click Create > Click Examples > Expected: Examples to appear under the Examples menu. > Actual: New Example Feature opens under the Example Application menu. > Problem 3 Cont: > Enter a Type and Sequence Num > Click Add > Expected: Create a new Example Feature Appl > Actual: Error Problem 3: Error missing exampleFeatureId -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414500#comment-13414500 ] Tom Burns commented on OFBIZ-4960: ---------------------------------- Good Question! All I can say, after the fact, is that I "THINK?" "<not><if-empty field="example"/></not>" was removed because I did not see a path in the code that reached the "CommonExampleDecorator" without sending the exampleID. Likely a misguided attempt at efficiency. It's called from Screens: EditExample EditExampleItems EditExampleFeatureAppls All of which pass an id. As for the reason for removing the fail: <fail-widgets> <container style="h1"><label>${uiLabelMap.ExampleNewExampleFeature}</label></container> </fail-widgets> Honestly do not remember. I do not think omitting these changes will have an impact on the functionality of the feature. I'll try to keep better notes in the future. Tom > Example Application Issues > -------------------------- > > Key: OFBIZ-4960 > URL: https://issues.apache.org/jira/browse/OFBIZ-4960 > Project: OFBiz > Issue Type: Bug > Affects Versions: Release 10.04, SVN trunk > Environment: SVN Trunk > Reporter: Tom Burns > Priority: Minor > Attachments: OFBIZ-4960 Example.patch > > > There are several defects in the Example application under the Example and Feature menus. > Problem path 1: > Find Example > Find Example > Select EX01 > Click Items Tab (or Features) > Click Example Tab > Expected: Example Details form in the context of the Example menus > Actual: New Example Form under Example Application menus > Problem path 2: > Example > click New Example > Enter a new example > Expected: Example Details form to add Items and Features to the New Example > Actual: Example page filtered on newly created example > (this is a problem for a new user who will not know how to clear the Example Id from the Search Options form. A better path would be to go to the edit forms where the user can add additional information on the example i.e. Items and Features) > Problem path 3: > Features > New Example Features > Enter a Description > Click Create > Click Examples > Expected: Examples to appear under the Examples menu. > Actual: New Example Feature opens under the Example Application menu. > Problem 3 Cont: > Enter a Type and Sequence Num > Click Add > Expected: Create a new Example Feature Appl > Actual: Error Problem 3: Error missing exampleFeatureId -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414590#comment-13414590 ] Jacques Le Roux commented on OFBIZ-4960: ---------------------------------------- Thanks for your answer Tom, I will check that. I just checked ExampleNewExampleFeature content and the fail-widgets in deed does not make sense. > Example Application Issues > -------------------------- > > Key: OFBIZ-4960 > URL: https://issues.apache.org/jira/browse/OFBIZ-4960 > Project: OFBiz > Issue Type: Bug > Affects Versions: Release 10.04, SVN trunk > Environment: SVN Trunk > Reporter: Tom Burns > Priority: Minor > Attachments: OFBIZ-4960 Example.patch > > > There are several defects in the Example application under the Example and Feature menus. > Problem path 1: > Find Example > Find Example > Select EX01 > Click Items Tab (or Features) > Click Example Tab > Expected: Example Details form in the context of the Example menus > Actual: New Example Form under Example Application menus > Problem path 2: > Example > click New Example > Enter a new example > Expected: Example Details form to add Items and Features to the New Example > Actual: Example page filtered on newly created example > (this is a problem for a new user who will not know how to clear the Example Id from the Search Options form. A better path would be to go to the edit forms where the user can add additional information on the example i.e. Items and Features) > Problem path 3: > Features > New Example Features > Enter a Description > Click Create > Click Examples > Expected: Examples to appear under the Examples menu. > Actual: New Example Feature opens under the Example Application menu. > Problem 3 Cont: > Enter a Type and Sequence Num > Click Add > Expected: Create a new Example Feature Appl > Actual: Error Problem 3: Error missing exampleFeatureId -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414590#comment-13414590 ] Jacques Le Roux edited comment on OFBIZ-4960 at 7/15/12 8:37 AM: ----------------------------------------------------------------- == TYPO == Thanks for your answer Tom, I will check that. I just checked ExampleNewExampleFeature content and the fail-widgets indeed does not make sense. was (Author: jacques.le.roux): Thanks for your answer Tom, I will check that. I just checked ExampleNewExampleFeature content and the fail-widgets in deed does not make sense. > Example Application Issues > -------------------------- > > Key: OFBIZ-4960 > URL: https://issues.apache.org/jira/browse/OFBIZ-4960 > Project: OFBiz > Issue Type: Bug > Affects Versions: Release 10.04, SVN trunk > Environment: SVN Trunk > Reporter: Tom Burns > Priority: Minor > Attachments: OFBIZ-4960 Example.patch > > > There are several defects in the Example application under the Example and Feature menus. > Problem path 1: > Find Example > Find Example > Select EX01 > Click Items Tab (or Features) > Click Example Tab > Expected: Example Details form in the context of the Example menus > Actual: New Example Form under Example Application menus > Problem path 2: > Example > click New Example > Enter a new example > Expected: Example Details form to add Items and Features to the New Example > Actual: Example page filtered on newly created example > (this is a problem for a new user who will not know how to clear the Example Id from the Search Options form. A better path would be to go to the edit forms where the user can add additional information on the example i.e. Items and Features) > Problem path 3: > Features > New Example Features > Enter a Description > Click Create > Click Examples > Expected: Examples to appear under the Examples menu. > Actual: New Example Feature opens under the Example Application menu. > Problem 3 Cont: > Enter a Type and Sequence Num > Click Add > Expected: Create a new Example Feature Appl > Actual: Error Problem 3: Error missing exampleFeatureId -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414591#comment-13414591 ] Jacques Le Roux commented on OFBIZ-4960: ---------------------------------------- Ha finally thinking of it: this is an example component, and even if they are not used those are examples of use. I will put comments to explain. > Example Application Issues > -------------------------- > > Key: OFBIZ-4960 > URL: https://issues.apache.org/jira/browse/OFBIZ-4960 > Project: OFBiz > Issue Type: Bug > Affects Versions: Release 10.04, SVN trunk > Environment: SVN Trunk > Reporter: Tom Burns > Priority: Minor > Attachments: OFBIZ-4960 Example.patch > > > There are several defects in the Example application under the Example and Feature menus. > Problem path 1: > Find Example > Find Example > Select EX01 > Click Items Tab (or Features) > Click Example Tab > Expected: Example Details form in the context of the Example menus > Actual: New Example Form under Example Application menus > Problem path 2: > Example > click New Example > Enter a new example > Expected: Example Details form to add Items and Features to the New Example > Actual: Example page filtered on newly created example > (this is a problem for a new user who will not know how to clear the Example Id from the Search Options form. A better path would be to go to the edit forms where the user can add additional information on the example i.e. Items and Features) > Problem path 3: > Features > New Example Features > Enter a Description > Click Create > Click Examples > Expected: Examples to appear under the Examples menu. > Actual: New Example Feature opens under the Example Application menu. > Problem 3 Cont: > Enter a Type and Sequence Num > Click Add > Expected: Create a new Example Feature Appl > Actual: Error Problem 3: Error missing exampleFeatureId -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414592#comment-13414592 ] Jacques Le Roux commented on OFBIZ-4960: ---------------------------------------- Mmm, no. If only seed data are loaded these checks make sense... > Example Application Issues > -------------------------- > > Key: OFBIZ-4960 > URL: https://issues.apache.org/jira/browse/OFBIZ-4960 > Project: OFBiz > Issue Type: Bug > Affects Versions: Release 10.04, SVN trunk > Environment: SVN Trunk > Reporter: Tom Burns > Priority: Minor > Attachments: OFBIZ-4960 Example.patch > > > There are several defects in the Example application under the Example and Feature menus. > Problem path 1: > Find Example > Find Example > Select EX01 > Click Items Tab (or Features) > Click Example Tab > Expected: Example Details form in the context of the Example menus > Actual: New Example Form under Example Application menus > Problem path 2: > Example > click New Example > Enter a new example > Expected: Example Details form to add Items and Features to the New Example > Actual: Example page filtered on newly created example > (this is a problem for a new user who will not know how to clear the Example Id from the Search Options form. A better path would be to go to the edit forms where the user can add additional information on the example i.e. Items and Features) > Problem path 3: > Features > New Example Features > Enter a Description > Click Create > Click Examples > Expected: Examples to appear under the Examples menu. > Actual: New Example Feature opens under the Example Application menu. > Problem 3 Cont: > Enter a Type and Sequence Num > Click Add > Expected: Create a new Example Feature Appl > Actual: Error Problem 3: Error missing exampleFeatureId -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux resolved OFBIZ-4960. ------------------------------------ Resolution: Fixed Fix Version/s: Release Branch 12.04 SVN trunk Assignee: Jacques Le Roux Thanks Tom, Your patch is in trunk r1361662 R12.04 r1361663 R11.04 would need handwork, I'm not inclined to... > Example Application Issues > -------------------------- > > Key: OFBIZ-4960 > URL: https://issues.apache.org/jira/browse/OFBIZ-4960 > Project: OFBiz > Issue Type: Bug > Affects Versions: Release 10.04, SVN trunk > Environment: SVN Trunk > Reporter: Tom Burns > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 12.04 > > Attachments: OFBIZ-4960 Example.patch > > > There are several defects in the Example application under the Example and Feature menus. > Problem path 1: > Find Example > Find Example > Select EX01 > Click Items Tab (or Features) > Click Example Tab > Expected: Example Details form in the context of the Example menus > Actual: New Example Form under Example Application menus > Problem path 2: > Example > click New Example > Enter a new example > Expected: Example Details form to add Items and Features to the New Example > Actual: Example page filtered on newly created example > (this is a problem for a new user who will not know how to clear the Example Id from the Search Options form. A better path would be to go to the edit forms where the user can add additional information on the example i.e. Items and Features) > Problem path 3: > Features > New Example Features > Enter a Description > Click Create > Click Examples > Expected: Examples to appear under the Examples menu. > Actual: New Example Feature opens under the Example Application menu. > Problem 3 Cont: > Enter a Type and Sequence Num > Click Add > Expected: Create a new Example Feature Appl > Actual: Error Problem 3: Error missing exampleFeatureId -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4960. ---------------------------------- > Example Application Issues > -------------------------- > > Key: OFBIZ-4960 > URL: https://issues.apache.org/jira/browse/OFBIZ-4960 > Project: OFBiz > Issue Type: Bug > Affects Versions: Release 10.04, SVN trunk > Environment: SVN Trunk > Reporter: Tom Burns > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk, Release Branch 12.04 > > Attachments: OFBIZ-4960 Example.patch > > > There are several defects in the Example application under the Example and Feature menus. > Problem path 1: > Find Example > Find Example > Select EX01 > Click Items Tab (or Features) > Click Example Tab > Expected: Example Details form in the context of the Example menus > Actual: New Example Form under Example Application menus > Problem path 2: > Example > click New Example > Enter a new example > Expected: Example Details form to add Items and Features to the New Example > Actual: Example page filtered on newly created example > (this is a problem for a new user who will not know how to clear the Example Id from the Search Options form. A better path would be to go to the edit forms where the user can add additional information on the example i.e. Items and Features) > Problem path 3: > Features > New Example Features > Enter a Description > Click Create > Click Examples > Expected: Examples to appear under the Examples menu. > Actual: New Example Feature opens under the Example Application menu. > Problem 3 Cont: > Enter a Type and Sequence Num > Click Add > Expected: Create a new Example Feature Appl > Actual: Error Problem 3: Error missing exampleFeatureId -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
| Free forum by Nabble | Edit this page |
