OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

26 messages Options

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=comments#action_12455100 ]

Tim Ruppert commented on OFBIZ-498:
-----------------------------------

All, can we close this issue and move on to refactoring #2?

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Attachments: anonymous_checkout3.patch, anonymous_checkout4.patch, anonymous_checkout5.patch, anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=comments#action_12455149 ]

Jacques Le Roux commented on OFBIZ-498:
---------------------------------------

For me closing this issue is OK.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=all ]

David E. Jones closed OFBIZ-498.
--------------------------------

Fix Version/s: SVN trunk
Resolution: Fixed

Yes, I think we have a good first pass in place and issues from here would be easier/better as separate issues.

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Fix For: SVN trunk
>
> Attachments: anonymous_checkout3.patch, anonymous_checkout4.patch, anonymous_checkout5.patch, anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=comments#action_12460572 ]

Rohit Sureka commented on OFBIZ-498:
------------------------------------

Hi,

The latest anonymous checkout seems to have few bugs. If the 'Show Checkout Gift Options' options in set to 'N' in Store congif page the checkout process throws this error just after selecting the shipping method options.

2006-12-22 06:08:50,921 (http-0.0.0.0-8443-Processor2) [ ScreenFactory.java:115:INFO ] Got 8 screens in 0.031s from: file:/E:/ofbiz_tmn/applications/ecommerce/widget/ContentScreens.xml
2006-12-22 06:08:51,906 (http-0.0.0.0-8443-Processor2) [ ControlServlet.java:245:DEBUG] [[[processShipOptions] Done rendering page, Servlet Finished- total:3.719,since last([processShipOptio...):3.719]]
2006-12-22 06:08:52,015 (http-0.0.0.0-8443-Processor4) [ ControlServlet.java:245:DEBUG] [[[setShipOptions] Done rendering page, Servlet Finished- total:3.812,since last([setShipOptions] ...):3.812]]
2006-12-22 06:08:55,562 (http-0.0.0.0-8443-Processor4) [ ControlServlet.java:85 :INFO ] The character encoding of the request is: [null]. The character encoding we will use for the request and response is: [UTF-8]
2006-12-22 06:08:55,562 (http-0.0.0.0-8443-Processor4) [ ControlServlet.java:121:DEBUG] [[[processShipOptions] Servlet Starting, doing setup- total:0.0,since last(Begin):0.0]]
2006-12-22 06:08:55,562 (http-0.0.0.0-8443-Processor4) [ ControlServlet.java:170:DEBUG] [[[processShipOptions] Setup done, doing Event(s) and View(s)- total:0.0,since last([processShipOptio...):0.0]]
2006-12-22 06:08:55,562 (http-0.0.0.0-8443-Processor4) [ RequestHandler.java:197:INFO ] [Processing Request]: processShipOptions
2006-12-22 06:08:55,578 (http-0.0.0.0-8443-Processor4) [ FieldObject.java:75 :INFO ] Field value not found with name isGift in Map with name , not getting Object value, returning null.
2006-12-22 06:08:55,671 (http-0.0.0.0-8443-Processor4) [ CallObjectMethod.java:163:ERROR]
---- runtime exception report --------------------------------------------------
Method in call method operation threw an exception
Exception: java.lang.NullPointerException
Message: null
---- stack trace ---------------------------------------------------------------
java.lang.NullPointerException
org.ofbiz.order.shoppingcart.ShoppingCart.setIsGift(ShoppingCart.java:2094)
org.ofbiz.order.shoppingcart.ShoppingCart.setIsGift(ShoppingCart.java:2098)
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
java.lang.reflect.Method.invoke(Method.java:324)
org.ofbiz.minilang.method.callops.CallObjectMethod.callMethod(CallObjectMethod.java:135)
org.ofbiz.minilang.method.callops.CallObjectMethod.exec(CallObjectMethod.java:102)
org.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:926)
org.ofbiz.minilang.method.ifops.IfNotEmpty.exec(IfNotEmpty.java:81)
org.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:926)
org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:565)
org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:102)
org.ofbiz.minilang.SimpleMethod.runSimpleEvent(SimpleMethod.java:63)
org.ofbiz.webapp.event.SimpleEventHandler.invoke(SimpleEventHandler.java:69)
org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:406)
org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:237)
org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:178)
org.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:74)
javax.servlet.http.HttpServlet.service(HttpServlet.java:615)
javax.servlet.http.HttpServlet.service(HttpServlet.java:688)
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:245)
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:541)
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869)
org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664)
org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527)
org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80)
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684)
java.lang.Thread.run(Thread.java:534)
--------------------------------------------------------------------------------

2006-12-22 06:08:55,671 (http-0.0.0.0-8443-Processor4) [ TransactionUtil.java:249:ERROR]
---- exception report ----------------------------------------------------------
[TransactionUtil.rollback]
Exception: java.lang.Exception
Message: Stack Trace
---- stack trace ---------------------------------------------------------------
java.lang.Exception: Stack Trace
org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:248)
org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:230)
org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:694)
org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:102)
org.ofbiz.minilang.SimpleMethod.runSimpleEvent(SimpleMethod.java:63)
org.ofbiz.webapp.event.SimpleEventHandler.invoke(SimpleEventHandler.java:69)
org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:406)
org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:237)
org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:178)
org.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:74)
javax.servlet.http.HttpServlet.service(HttpServlet.java:615)
javax.servlet.http.HttpServlet.service(HttpServlet.java:688)
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:245)
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:541)
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869)
org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664)
org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527)
org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80)
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684)
java.lang.Thread.run(Thread.java:534)
--------------------------------------------------------------------------------

2006-12-22 06:08:55,671 (http-0.0.0.0-8443-Processor4) [ TransactionUtil.java:259:INFO ] [TransactionUtil.rollback] transaction rolled back
2006-12-22 06:08:55,671 (http-0.0.0.0-8443-Processor4) [ RequestHandler.java:268:ERROR] Request processShipOptions caused an error with the following message: ERROR: Could not complete the Process Ship Options; to be called as a Request Event [file:/E:/ofbiz_tmn/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml#processShipOptions] process [Method to execute named setIsGift threw an exception: java.lang.NullPointerException]
2006-12-22 06:08:55,671 (http-0.0.0.0-8443-Processor4) [ RequestHandler.java:385:INFO ] [RequestHandler.doRequest]: Response is a view.
2006-12-22 06:08:55,671 (http-0.0.0.0-8443-Processor4) [ RequestHandler.java:537:INFO ] servletName=control, view=optionsetting

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Fix For: SVN trunk
>
> Attachments: anonymous_checkout3.patch, anonymous_checkout4.patch, anonymous_checkout5.patch, anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=comments#action_12460573 ]

Rohit Sureka commented on OFBIZ-498:
------------------------------------

Just another point, the new anonymous checkout does not support paypal as a payment option. I wonder if is accidental or by design.

Rohit

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Fix For: SVN trunk
>
> Attachments: anonymous_checkout3.patch, anonymous_checkout4.patch, anonymous_checkout5.patch, anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=comments#action_12460609 ]

Tim Ruppert commented on OFBIZ-498:
-----------------------------------

Rohit, this issue is closed - please file another one if you like. That being said, I went back a number of versions, before the refactored anonymous checkout was presented and the gift card did not work in that case either - AND paypal was not an option out of the box. Please let us know if you are still finding problems after checking an older - pre-November release.

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Fix For: SVN trunk
>
> Attachments: anonymous_checkout3.patch, anonymous_checkout4.patch, anonymous_checkout5.patch, anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.