OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

26 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

Anonymous Checkout Refactoring [ ecommerce ]
--------------------------------------------

Key: OFBIZ-498
URL: http://issues.apache.org/jira/browse/OFBIZ-498
Project: OFBiz (The Open for Business Project)
Issue Type: Improvement
Components: ecommerce
Affects Versions: SVN trunk
Reporter: Tim Ruppert
Attachments: anonymousCheckout.patch

All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.

Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=all ]

Tim Ruppert updated OFBIZ-498:
------------------------------

Attachment: anonymousCheckout.patch

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Attachments: anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=comments#action_12453652 ]

Tim Ruppert commented on OFBIZ-498:
-----------------------------------

We added code to fix the ShippingAddress as Billing address checkbox problem as well as updating the HTML in the payment option to work properly (the radio inputs were actually never closed :) ).

Here are the remaining questions:

1) This implementation does not implement support for EXT_OFFLINE payments. This is because functional requirements for this paymentMethodType were not clear to us.

2) Does OFBIz currently have a working gift card out of the box? It did not seem to work properly for us.

3) File paymentinformation.ftl has following statement at line #319
<#assign giftCard = giftCard?if_exists>
We know this is not best way to solve error - can someone point us to something more solid?

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=all ]

David E. Jones reassigned OFBIZ-498:
------------------------------------

Assignee: David E. Jones

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Attachments: anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=comments#action_12453787 ]

David E. Jones commented on OFBIZ-498:
--------------------------------------

This patch is a major improvement, and even with a few flaws the main stuff seems to be working just fine.

A few notes:

1. the finalizeOrder and finalizeOrderError request-map definitions should ideally be removed from the controller.xml file in the ecommerce webapp; this is referred to in just a couple of places, including the billsettings.ftl file for the payment method type of GC, and in the loadCartFromQuote request; both of these should be "modernized"

2. the processPaymentSettings.bsh file was under the src directory and in the ecommerce/misc package; all such scripts should go under the script directory, and I created a new package for it to be more consistent: ecommerce/order

3. the Shipping Address link appears to be enabled even when the initial customer info is not yet in place

4. the header items really should submit the form on each page in addition to going to the other step (customers tend to do this sort of thing thinking their changes will be saved; we did this in the normal checkout process if whoever works on this wants an example)

Anyway, there may be more stuff but for now this is in SVN rev 479879.

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Attachments: anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=comments#action_12454046 ]

Tim Ruppert commented on OFBIZ-498:
-----------------------------------

1. This will be something that can come with the next round of revisions if that's ok

2. Thanks for moving this - I should've noticed this beforehand

3. I am unable to reproduce this. This would mean that when you get to the setCustomer page that you'd be able to click ShippingAddress before you had put this in - and I do not see that happening. The algorithm that we use was that if you've already gotten to a page - you should be able to return to it.

4. The header items submitting is also something that we are working on, but in some ways I wonder if this is premature. Think about if they submit their Payment Options and go to the Payment Information Screen. Say they reconsider - with this auto submit in place they would have to fill out all the credit card information to go back and change their choice. Does that seem right?

Let us know so we can get this resolved.

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Attachments: anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=comments#action_12454072 ]

David E. Jones commented on OFBIZ-498:
--------------------------------------

3. On further testing it seems that this is only a problem if there is an autoUserLoginId cookie in place; I haven't looked at the code but if it is looking at the autoUserLogin another criteria might be better

4. I'm not sure what you mean by having to fill out information again - everything should be pre-filled based on what is in the DB and what is selected in the cart object; on the other hand, maybe I'm misunderstanding what you mean

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Attachments: anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=comments#action_12454082 ]

David E. Jones commented on OFBIZ-498:
--------------------------------------

On #4: I just to Tim and his concern was about going from a payment details page back to the payment option page after having done something like accidentally selecting a credit card after they really want a gift card or off-line or something and then if the auto-submit is done then things are validated, and the user would have to fill in CC details to go back; this is a good exception to the submit and so there should be a rule like this:

If the following are true, create a simple link and not a form submit link for the paymentoptions button:
1. on the paymentinformation screen
2. the ID on the page denoting a prefilled in form is null/empty (meaning a first entry to the screen)

... and I guess that's it. Just those two conditions.

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Attachments: anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=all ]

Ashish Vijaywargiya updated OFBIZ-498:
--------------------------------------

Attachment: anonymous_checkout2.patch

Hi David,Tim & Others interested,

David,I have resolved the two notes that you have included in your previous comments :
************************************************************
3. the Shipping Address link appears to be enabled even when the initial customer info is not yet in place

4. the header items really should submit the form on each page in addition to going to the other step (customers tend to do this sort of thing thinking their changes will be saved; we did this in the normal checkout process if whoever works on this wants an example)
************************************************************

I also removed the old code from the CustomerEvents.xml file and some code from the genericaddress.ftl.
Please give me your feedback on this.

Regards
Ashish Vijaywargiya

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Attachments: anonymous_checkout2.patch, anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=all ]

Ashish Vijaywargiya updated OFBIZ-498:
--------------------------------------

Attachment: anonymous_checkout3.patch

Hi,

I am extremly sorry.
The previous file that I have attached the wrong file.

The current file is correct patch file.
Please give me your feedback on this file.

Regards
Ashish Vijaywargiya

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Attachments: anonymous_checkout2.patch, anonymous_checkout3.patch, anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=all ]

Jacques Le Roux updated OFBIZ-498:
----------------------------------

Attachment: (was: anonymous_checkout2.patch)

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Attachments: anonymous_checkout3.patch, anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=comments#action_12454419 ]

Walter Vaughan commented on OFBIZ-498:
--------------------------------------

There is no graceful error message when you submit /ecommerce/control/setShipping with missing data. It spits out the typical ofBiz-BSOD equivalent with

The Following Errors Occurred:

* ERROR: Could not complete the Process Ship Settings; to be called as a Request Event [file:/ofbiz/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml#processShipSettings] process [problem invoking the [createPartyPostalAddress] service with the map named [addressContext] containing [{attnName=null, yearsWithContactMech=null, userLogin=[GenericEntity:UserLogin][createdStamp,2006-11-2913:29:25.0(java.sql.Timestamp)]

[...sniped thousands more characters...]

Rather than how /ecommerce/control/setCustomer when submitted gracefully errors with messages like

The Following Errors Occurred:

* Firstname is Missing
* Lastname is Missing

and allows the operator to make corrections to there entries.

The /ecommerce/control/setShipOptions page as well does allow you to *not* pick a shipping method, which *should* error out that you did not pick a radio button, or inform you that some default method was chosen...

The ecommerce/control/setPaymentOption does not seem to remember previous settings, at least the radio buttons do not maintain there settings when you return to that page unless you reach the "Review Order Page". It then seems to remember your choice. Also if an operator selects "Offline Payment", when the setPaymentInformation page is submitted, nothing happens. It doesn't got to review order, nor generates anything in the log files.

On ecommerce/control/setPaymentInformation?paymentMethodTypeId=CREDIT_CARD it suffers as well as unfriendly error messages for missing data like City or State

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Attachments: anonymous_checkout3.patch, anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=comments#action_12454480 ]

David E. Jones commented on OFBIZ-498:
--------------------------------------

Thanks Ashish. The anonymous_checkout3.patch is now in (SVN rev 480761).

I just briefly reviewed this and did a quick test, and everything looks fine. It would be good if a bunch of people to test this and offer more feedback.

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Attachments: anonymous_checkout3.patch, anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=all ]

Ashish Vijaywargiya updated OFBIZ-498:
--------------------------------------

Attachment: anonymous_checkout4.patch

Hi Everybody,

Thanks Walter for taking interest and testing the anonymous checkout process.
In this mini patch I have made the error message more user friendly for the processShipSettings method
(Although everything was handled properly I only added <check-errors/> tag :-) ).
Now it will show something like this if anything will be missing on the form :
The Following Errors Occurred:

* Address Line 1 is missing
* City is Missing
* Zip/Postal Code is missing
* State is missing, and is required for an address in the United States.

In the paymentInformation(Credit card & EFT) screen I have made the error message more user friendly in my previous patch.So can you please take the update of it.

--
Regards
Ashish Vijaywargiya

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Attachments: anonymous_checkout3.patch, anonymous_checkout4.patch, anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=comments#action_12454516 ]

David E. Jones commented on OFBIZ-498:
--------------------------------------

Thanks for looking into that Ashish. Your patch is in SVN rev 480806.

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Attachments: anonymous_checkout3.patch, anonymous_checkout4.patch, anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=comments#action_12454534 ]

Tim Ruppert commented on OFBIZ-498:
-----------------------------------

I have checked the patch as well and believe that Ashish fixed all the errors that I saw in David's original message and Walter's testing. Please everyone give it another look so we can close this issue and work on further optimizing the process!

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Attachments: anonymous_checkout3.patch, anonymous_checkout4.patch, anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=comments#action_12454582 ]

Jacques Le Roux commented on OFBIZ-498:
---------------------------------------

Hi,

I found a problem testing quick checkout with the last mods : parameters.formNameValue is not defined though this seems done in OrderScreens.xml.

I have no time to go futher here is the quick/dirty solution I used

<#if !parameters.formNameValue?exists>
<#assign parametersformNameValue = "orderreview">
<#else>
<#assign parametersformNameValue = parameters.formNameValue>
</#if>

and replaced parameters.formNameValue by parametersformNameValue in other parts of the code.

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Attachments: anonymous_checkout3.patch, anonymous_checkout4.patch, anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=comments#action_12454589 ]

Jacques Le Roux commented on OFBIZ-498:
---------------------------------------

Forgot to say that these changes were in checkoutreview.ftl (obvious if you try anyway)

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Attachments: anonymous_checkout3.patch, anonymous_checkout4.patch, anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=all ]

Ashish Vijaywargiya updated OFBIZ-498:
--------------------------------------

Attachment: anonymous_checkout5.patch

Hi,

Thanks Jacques for pointing it out and sorry for this mistake.

Actually there are two entries in the OrderScreens.xml file for the "OrderReview" .
The screen for the AnonymousCheckout is "orderreview" and for the registered user its "checkoutreview".

I set "parameters.formNameValue" for "orderreview" screen and forgot to keep it for "checkoutreview" screen.

Here is the mini patch that will resolve the problem that you have specified.

--
Regards
Ashish Vijaywargiya

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Attachments: anonymous_checkout3.patch, anonymous_checkout4.patch, anonymous_checkout5.patch, anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-498) Anonymous Checkout Refactoring [ ecommerce ]

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-498?page=comments#action_12454824 ]

Jacques Le Roux commented on OFBIZ-498:
---------------------------------------

Thanks Ashish, your patch is in OFBiz rev. 481179

> Anonymous Checkout Refactoring [ ecommerce ]
> --------------------------------------------
>
> Key: OFBIZ-498
> URL: http://issues.apache.org/jira/browse/OFBIZ-498
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: Tim Ruppert
> Assigned To: David E. Jones
> Attachments: anonymous_checkout3.patch, anonymous_checkout4.patch, anonymous_checkout5.patch, anonymousCheckout.patch
>
>
> All, this is the anonymous checkout refactoring that was started during the training in Ephraim. The team that contributed to this was David Jones, Amit Shinde, Anil Patel, Tim Ruppert, Walter Vaughn, Eric Schwartz & David Shere.
> Anil Patel, Ashish Vijaywargiya and I picked this up and finished it to the best of our ability.