[jira] Created: (OFBIZ-499) Implement ShoppingCartEvents and CheckoutEvents as simple-mehtods

[Nicolas Malin (Jira)]

Implement ShoppingCartEvents and CheckoutEvents as simple-mehtods
-----------------------------------------------------------------

                 Key: OFBIZ-499
                 URL: http://issues.apache.org/jira/browse/OFBIZ-499
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: order
            Reporter: Chris Howe
            Priority: Minor


Recreate  the ShoppingCartEvents and CheckoutEvents as simple methods so they will be easier to override/play with.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-499?page=comments#action_12453750 ]
           
Si Chen commented on OFBIZ-499:
-------------------------------

I do not like this idea.

> Implement ShoppingCartEvents and CheckoutEvents as simple-mehtods
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-499
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-499
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: order
>            Reporter: Chris Howe
>            Priority: Minor
>
> Recreate  the ShoppingCartEvents and CheckoutEvents as simple methods so they will be easier to override/play with.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-499?page=comments#action_12453757 ]
           
Alex D. Fleming commented on OFBIZ-499:
---------------------------------------

Chris,

I think we will keep the ShoppingCartEvents and CheckoutEvents code as it is in Java.
There is no need to convert this code into simple-methods.

+1 for Si's comment.

Cheer
Alex D. Fleming

> Implement ShoppingCartEvents and CheckoutEvents as simple-mehtods
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-499
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-499
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: order
>            Reporter: Chris Howe
>            Priority: Minor
>
> Recreate  the ShoppingCartEvents and CheckoutEvents as simple methods so they will be easier to override/play with.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-499?page=comments#action_12453759 ]
           
Chris Howe commented on OFBIZ-499:
----------------------------------

Hey Si,

Would you care to expand on your concerns?  The implementation that I plan will be for a hot-deploy application and if present will simply override ofbiz's logic.  If the implementation is preferred, then might replace ofbiz's implementation.

> Implement ShoppingCartEvents and CheckoutEvents as simple-mehtods
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-499
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-499
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: order
>            Reporter: Chris Howe
>            Priority: Minor
>
> Recreate  the ShoppingCartEvents and CheckoutEvents as simple methods so they will be easier to override/play with.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-499?page=comments#action_12455056 ]
           
Si Chen commented on OFBIZ-499:
-------------------------------

Chris,

Sorry, I think in my haste I may have misunderstood your intent.

If you want to implement another version in minilang and show us how it could be done, that's great.

I however would strongly prefer to keep the Java version of the cart methods rather than outright replace them with new ones written in minilang.

Si

> Implement ShoppingCartEvents and CheckoutEvents as simple-mehtods
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-499
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-499
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: order
>            Reporter: Chris Howe
>            Priority: Minor
>
> Recreate  the ShoppingCartEvents and CheckoutEvents as simple methods so they will be easier to override/play with.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira