[jira] Created: (OFBIZ-501) Allow orders with discontinued products to be modified...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-501) Allow orders with discontinued products to be modified...

Nicolas Malin (Jira)
Allow orders with discontinued products to be modified...
---------------------------------------------------------

                 Key: OFBIZ-501
                 URL: http://issues.apache.org/jira/browse/OFBIZ-501
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: order
    Affects Versions: SVN trunk
         Environment: N/A
            Reporter: Ray Barlow


Problem:
Customers are placing orders for product X but it's end of line and you run out so you discontinue the product in the catalogue manager. Unfortunately at this point you will no longer be able to edit existing orders containing product X for any reason as the load routine checks the discontinued date for all items and throws an exception.

Solution:
For this improvement I've added an extra boolean to allow the suppression of this test so you can cancel other line items and edit quantites etc as may be required by customers.

It does not allow, rightly so in my mind, the addition of a discontinued product into an existing order, or from quotes and shopping lists etc.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-501) Allow orders with discontinued products to be modified...

Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-501?page=comments#action_12454018 ]
           
Jacques Le Roux commented on OFBIZ-501:
---------------------------------------

Hi Ray,

Have you a patch ?

TIA

> Allow orders with discontinued products to be modified...
> ---------------------------------------------------------
>
>                 Key: OFBIZ-501
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-501
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: N/A
>            Reporter: Ray Barlow
>
> Problem:
> Customers are placing orders for product X but it's end of line and you run out so you discontinue the product in the catalogue manager. Unfortunately at this point you will no longer be able to edit existing orders containing product X for any reason as the load routine checks the discontinued date for all items and throws an exception.
> Solution:
> For this improvement I've added an extra boolean to allow the suppression of this test so you can cancel other line items and edit quantites etc as may be required by customers.
> It does not allow, rightly so in my mind, the addition of a discontinued product into an existing order, or from quotes and shopping lists etc.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-501) Allow orders with discontinued products to be modified...

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-501?page=all ]

Ray Barlow updated OFBIZ-501:
-----------------------------

    Attachment: order_edit_discontinued.patch

Dohh forgot the attachment, shame you can't do it on the first jira creation page.

> Allow orders with discontinued products to be modified...
> ---------------------------------------------------------
>
>                 Key: OFBIZ-501
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-501
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: N/A
>            Reporter: Ray Barlow
>         Attachments: order_edit_discontinued.patch
>
>
> Problem:
> Customers are placing orders for product X but it's end of line and you run out so you discontinue the product in the catalogue manager. Unfortunately at this point you will no longer be able to edit existing orders containing product X for any reason as the load routine checks the discontinued date for all items and throws an exception.
> Solution:
> For this improvement I've added an extra boolean to allow the suppression of this test so you can cancel other line items and edit quantites etc as may be required by customers.
> It does not allow, rightly so in my mind, the addition of a discontinued product into an existing order, or from quotes and shopping lists etc.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-501) Allow orders with discontinued products to be modified...

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-501?page=comments#action_12454111 ]
           
Jacques Le Roux commented on OFBIZ-501:
---------------------------------------

Create a Jira issue on Atlassian site ;o)

http://www.atlassian.com/support/jira/request.jsp

> Allow orders with discontinued products to be modified...
> ---------------------------------------------------------
>
>                 Key: OFBIZ-501
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-501
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: N/A
>            Reporter: Ray Barlow
>         Attachments: order_edit_discontinued.patch
>
>
> Problem:
> Customers are placing orders for product X but it's end of line and you run out so you discontinue the product in the catalogue manager. Unfortunately at this point you will no longer be able to edit existing orders containing product X for any reason as the load routine checks the discontinued date for all items and throws an exception.
> Solution:
> For this improvement I've added an extra boolean to allow the suppression of this test so you can cancel other line items and edit quantites etc as may be required by customers.
> It does not allow, rightly so in my mind, the addition of a discontinued product into an existing order, or from quotes and shopping lists etc.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-501) Allow orders with discontinued products to be modified...

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-501?page=comments#action_12455115 ]
           
Jacques Le Roux commented on OFBIZ-501:
---------------------------------------

Hi Ray,

I tried the patch but I'm not convinced. I always get :

<< *  Unable to cancel order line : bla / bla / bla.>>

Can you explain more your use case, please.

Thanks



> Allow orders with discontinued products to be modified...
> ---------------------------------------------------------
>
>                 Key: OFBIZ-501
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-501
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: N/A
>            Reporter: Ray Barlow
>         Attachments: order_edit_discontinued.patch
>
>
> Problem:
> Customers are placing orders for product X but it's end of line and you run out so you discontinue the product in the catalogue manager. Unfortunately at this point you will no longer be able to edit existing orders containing product X for any reason as the load routine checks the discontinued date for all items and throws an exception.
> Solution:
> For this improvement I've added an extra boolean to allow the suppression of this test so you can cancel other line items and edit quantites etc as may be required by customers.
> It does not allow, rightly so in my mind, the addition of a discontinued product into an existing order, or from quotes and shopping lists etc.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-501) Allow orders with discontinued products to be modified...

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-501?page=comments#action_12455142 ]
           
Ray Barlow commented on OFBIZ-501:
----------------------------------

The use case I thought was quite clear but I'll try again:
  1 - Create and approve a new order with two products GZ-1000 and GZ-1001.
  2 - Next set the sales discontinuation date, in the catalogue manager, for the GZ-1000 to "now" i.e. discontinue it.
  3 - In the order manager find the order and click on "Edit Items"
  4 - Then in the bottom section under "Add To Order" put "GZ-1004" and click add

Error message result is : Tried to add the Product Tiny Gizmo (productId: GZ-1000) to the cart. This product is no longer available for sale, so not adding.

I'm not trying to add a "GZ-1000" so it should not be complaining and stopping me from making my changes to the order. For testing and reproduction the change is not specific i.e. I could be trying to cancel another item or change a quantity, but the cart code will block it because one (or more) products already in the order have since been discontinued.

I would guess what you are seeing "Unable to cancel order line..." is related to the problems listed in OFBIZ-431 : https://issues.apache.org/jira/browse/OFBIZ-431    I must admit because of 431 I have disabled all the promotions so that I can test creating and editting orders with a reasonable number of products in without getting it mixed up with that bug.

The patch I've submitted for this issue (and I just double checked the one attached) only surpresses the test for discontinued products during the loadCartFromOrder execution and makes no changes to routines like cancel or any ECAs etc.

> Allow orders with discontinued products to be modified...
> ---------------------------------------------------------
>
>                 Key: OFBIZ-501
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-501
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: N/A
>            Reporter: Ray Barlow
>         Attachments: order_edit_discontinued.patch
>
>
> Problem:
> Customers are placing orders for product X but it's end of line and you run out so you discontinue the product in the catalogue manager. Unfortunately at this point you will no longer be able to edit existing orders containing product X for any reason as the load routine checks the discontinued date for all items and throws an exception.
> Solution:
> For this improvement I've added an extra boolean to allow the suppression of this test so you can cancel other line items and edit quantites etc as may be required by customers.
> It does not allow, rightly so in my mind, the addition of a discontinued product into an existing order, or from quotes and shopping lists etc.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-501) Allow orders with discontinued products to be modified...

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-501?page=comments#action_12455146 ]
           
Jacques Le Roux commented on OFBIZ-501:
---------------------------------------

Thanks for comment Ray,

I guess we may wait Scott's patch on OFBIZ-431 before going further on this.

> Allow orders with discontinued products to be modified...
> ---------------------------------------------------------
>
>                 Key: OFBIZ-501
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-501
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: N/A
>            Reporter: Ray Barlow
>         Attachments: order_edit_discontinued.patch
>
>
> Problem:
> Customers are placing orders for product X but it's end of line and you run out so you discontinue the product in the catalogue manager. Unfortunately at this point you will no longer be able to edit existing orders containing product X for any reason as the load routine checks the discontinued date for all items and throws an exception.
> Solution:
> For this improvement I've added an extra boolean to allow the suppression of this test so you can cancel other line items and edit quantites etc as may be required by customers.
> It does not allow, rightly so in my mind, the addition of a discontinued product into an existing order, or from quotes and shopping lists etc.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira