OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-504) PartyContactMechServices.xml some services have two default-messages

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

9 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-504) PartyContactMechServices.xml some services have two default-messages

PartyContactMechServices.xml some services have two default-messages
---------------------------------------------------------------------

Key: OFBIZ-504
URL: http://issues.apache.org/jira/browse/OFBIZ-504
Project: OFBiz (The Open for Business Project)
Issue Type: Improvement
Components: party
Affects Versions: SVN trunk
Reporter: Ismail Cansiz
Priority: Minor

There are small bugs in PartyContactMechServices.xml for default messages.
When services done successfully, displays "Contact Mechanism successfully created/updated". Because two default messages in many services such as createPostalAddress. First one "Postal Address successfully created." and second one "Contact Mechanism successfully created." So system displays last default-message.

My suggestion this situation, remove the second default-message. So, when a user created postal adress and system displays "Postal address successfully created.".

Any thoughts?

Regards,
Ismail

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-504) PartyContactMechServices.xml some services have two default-messages

[ http://issues.apache.org/jira/browse/OFBIZ-504?page=comments#action_12454272 ]

Jacques Le Roux commented on OFBIZ-504:
---------------------------------------

Hi Ismail,

Yes this seems a rather good idea. Are you sure that this will not have an impact on other stuffes ?

You may suggest a patch to review, insuch case plz be sure to read this before http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices

Thanks

> PartyContactMechServices.xml some services have two default-messages
> ---------------------------------------------------------------------
>
> Key: OFBIZ-504
> URL: http://issues.apache.org/jira/browse/OFBIZ-504
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: party
> Affects Versions: SVN trunk
> Reporter: Ismail Cansiz
> Priority: Minor
>
> There are small bugs in PartyContactMechServices.xml for default messages.
> When services done successfully, displays "Contact Mechanism successfully created/updated". Because two default messages in many services such as createPostalAddress. First one "Postal Address successfully created." and second one "Contact Mechanism successfully created." So system displays last default-message.
> My suggestion this situation, remove the second default-message. So, when a user created postal adress and system displays "Postal address successfully created.".
> Any thoughts?
> Regards,
> Ismail

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-504) PartyContactMechServices.xml some services have two default-messages

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-504?page=all ]

Ismail Cansiz updated OFBIZ-504:
--------------------------------

Attachment: i18n_party.patch

I tried to remove second default-message from updatePostalAddress service. But displays "The action was performed successfully.".
The correct solution may be last defult-message in a service same as first default-message.

I attached a patch file includes my solution and some additional i18n changes in ContactMechServices.xml and PartySimpleEvents.xml.

> PartyContactMechServices.xml some services have two default-messages
> ---------------------------------------------------------------------
>
> Key: OFBIZ-504
> URL: http://issues.apache.org/jira/browse/OFBIZ-504
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: party
> Affects Versions: SVN trunk
> Reporter: Ismail Cansiz
> Priority: Minor
> Attachments: i18n_party.patch
>
>
> There are small bugs in PartyContactMechServices.xml for default messages.
> When services done successfully, displays "Contact Mechanism successfully created/updated". Because two default messages in many services such as createPostalAddress. First one "Postal Address successfully created." and second one "Contact Mechanism successfully created." So system displays last default-message.
> My suggestion this situation, remove the second default-message. So, when a user created postal adress and system displays "Postal address successfully created.".
> Any thoughts?
> Regards,
> Ismail

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-504) PartyContactMechServices.xml some services have two default-messages

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-504?page=comments#action_12455101 ]

Jacques Le Roux commented on OFBIZ-504:
---------------------------------------

Thanks Ismail,

You patch is in OFBiz revision: 481569
I did not close the issue yet. Tell me if you want to do more about it please...

> PartyContactMechServices.xml some services have two default-messages
> ---------------------------------------------------------------------
>
> Key: OFBIZ-504
> URL: http://issues.apache.org/jira/browse/OFBIZ-504
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: party
> Affects Versions: SVN trunk
> Reporter: Ismail Cansiz
> Priority: Minor
> Attachments: i18n_party.patch
>
>
> There are small bugs in PartyContactMechServices.xml for default messages.
> When services done successfully, displays "Contact Mechanism successfully created/updated". Because two default messages in many services such as createPostalAddress. First one "Postal Address successfully created." and second one "Contact Mechanism successfully created." So system displays last default-message.
> My suggestion this situation, remove the second default-message. So, when a user created postal adress and system displays "Postal address successfully created.".
> Any thoughts?
> Regards,
> Ismail

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-504) PartyContactMechServices.xml some services have two default-messages

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-504?page=comments#action_12455104 ]

Ismail Cansiz commented on OFBIZ-504:
-------------------------------------

Hi Jacques,

Thanks for submitting the patch.

This patch does properly POSTAL_ADDRESS, TELECOM_NUMER. But it does'nt enough for EMAIL_ADDRESS, WEB_ADDRESS, IP_ADDRESS, ELECTRONIC_ADDRESS and DOMAIN_NAME. Because all of theese contact mech types linked to same service which named updateContactMech in ContactMechServices.xml. I have another patch file for this situation.

I have created another issue (OFBIZ-509) wich related this.

Thanks,
Ismail

> PartyContactMechServices.xml some services have two default-messages
> ---------------------------------------------------------------------
>
> Key: OFBIZ-504
> URL: http://issues.apache.org/jira/browse/OFBIZ-504
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: party
> Affects Versions: SVN trunk
> Reporter: Ismail Cansiz
> Priority: Minor
> Attachments: i18n_party.patch, i18n_party2.patch
>
>
> There are small bugs in PartyContactMechServices.xml for default messages.
> When services done successfully, displays "Contact Mechanism successfully created/updated". Because two default messages in many services such as createPostalAddress. First one "Postal Address successfully created." and second one "Contact Mechanism successfully created." So system displays last default-message.
> My suggestion this situation, remove the second default-message. So, when a user created postal adress and system displays "Postal address successfully created.".
> Any thoughts?
> Regards,
> Ismail

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-504) PartyContactMechServices.xml some services have two default-messages

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-504?page=all ]

Ismail Cansiz updated OFBIZ-504:
--------------------------------

Attachment: i18n_party2.patch

> PartyContactMechServices.xml some services have two default-messages
> ---------------------------------------------------------------------
>
> Key: OFBIZ-504
> URL: http://issues.apache.org/jira/browse/OFBIZ-504
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: party
> Affects Versions: SVN trunk
> Reporter: Ismail Cansiz
> Priority: Minor
> Attachments: i18n_party.patch, i18n_party2.patch
>
>
> There are small bugs in PartyContactMechServices.xml for default messages.
> When services done successfully, displays "Contact Mechanism successfully created/updated". Because two default messages in many services such as createPostalAddress. First one "Postal Address successfully created." and second one "Contact Mechanism successfully created." So system displays last default-message.
> My suggestion this situation, remove the second default-message. So, when a user created postal adress and system displays "Postal address successfully created.".
> Any thoughts?
> Regards,
> Ismail

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-504) PartyContactMechServices.xml some services have two default-messages

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-504?page=all ]

Ismail Cansiz updated OFBIZ-504:
--------------------------------

Attachment: party3.patch

I'm sory. i18n_party2.patch is wrong file.
i18n_party3.patch is ok.

> PartyContactMechServices.xml some services have two default-messages
> ---------------------------------------------------------------------
>
> Key: OFBIZ-504
> URL: http://issues.apache.org/jira/browse/OFBIZ-504
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: party
> Affects Versions: SVN trunk
> Reporter: Ismail Cansiz
> Priority: Minor
> Attachments: i18n_party.patch, i18n_party2.patch, party3.patch
>
>
> There are small bugs in PartyContactMechServices.xml for default messages.
> When services done successfully, displays "Contact Mechanism successfully created/updated". Because two default messages in many services such as createPostalAddress. First one "Postal Address successfully created." and second one "Contact Mechanism successfully created." So system displays last default-message.
> My suggestion this situation, remove the second default-message. So, when a user created postal adress and system displays "Postal address successfully created.".
> Any thoughts?
> Regards,
> Ismail

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-504) PartyContactMechServices.xml some services have two default-messages

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-504?page=all ]

Jacques Le Roux updated OFBIZ-504:
----------------------------------

Attachment: (was: i18n_party2.patch)

> PartyContactMechServices.xml some services have two default-messages
> ---------------------------------------------------------------------
>
> Key: OFBIZ-504
> URL: http://issues.apache.org/jira/browse/OFBIZ-504
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: party
> Affects Versions: SVN trunk
> Reporter: Ismail Cansiz
> Priority: Minor
> Attachments: i18n_party.patch, party3.patch
>
>
> There are small bugs in PartyContactMechServices.xml for default messages.
> When services done successfully, displays "Contact Mechanism successfully created/updated". Because two default messages in many services such as createPostalAddress. First one "Postal Address successfully created." and second one "Contact Mechanism successfully created." So system displays last default-message.
> My suggestion this situation, remove the second default-message. So, when a user created postal adress and system displays "Postal address successfully created.".
> Any thoughts?
> Regards,
> Ismail

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-504) PartyContactMechServices.xml some services have two default-messages

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-504?page=all ]

Jacques Le Roux closed OFBIZ-504.
---------------------------------

Fix Version/s: SVN trunk
Resolution: Fixed
Assignee: Jacques Le Roux

Thanks Ismail,

You patch is in OFBiz revision: 481728

> PartyContactMechServices.xml some services have two default-messages
> ---------------------------------------------------------------------
>
> Key: OFBIZ-504
> URL: http://issues.apache.org/jira/browse/OFBIZ-504
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: party
> Affects Versions: SVN trunk
> Reporter: Ismail Cansiz
> Assigned To: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: i18n_party.patch, party3.patch
>
>
> There are small bugs in PartyContactMechServices.xml for default messages.
> When services done successfully, displays "Contact Mechanism successfully created/updated". Because two default messages in many services such as createPostalAddress. First one "Postal Address successfully created." and second one "Contact Mechanism successfully created." So system displays last default-message.
> My suggestion this situation, remove the second default-message. So, when a user created postal adress and system displays "Postal address successfully created.".
> Any thoughts?
> Regards,
> Ismail