[jira] Created: (OFBIZ-525) Remove unused variables

[Nicolas Malin (Jira)]

Remove unused variables
-----------------------

                 Key: OFBIZ-525
                 URL: http://issues.apache.org/jira/browse/OFBIZ-525
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
    Affects Versions: SVN trunk
            Reporter: Stefan Huehner
            Priority: Trivial


Attached patch removes variables which are only assigned but never read.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-525?page=all ]

Stefan Huehner updated OFBIZ-525:
---------------------------------

    Attachment: ofbiz_unused_vars.diff

> Remove unused variables
> -----------------------
>
>                 Key: OFBIZ-525
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-525
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>            Priority: Trivial
>         Attachments: ofbiz_unused_vars.diff
>
>
> Attached patch removes variables which are only assigned but never read.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-525?page=all ]

Jacques Le Roux reassigned OFBIZ-525:
-------------------------------------

    Assignee: Jacques Le Roux

> Remove unused variables
> -----------------------
>
>                 Key: OFBIZ-525
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-525
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>         Attachments: ofbiz_unused_vars.diff
>
>
> Attached patch removes variables which are only assigned but never read.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-525?page=comments#action_12455885 ]
           
Jacques Le Roux commented on OFBIZ-525:
---------------------------------------

Hi Stefan,

I began to verified, there are even much more than that, at least in  :
applications/product/src/org/ofbiz/product/product/ProductServices.java .
applications/product/src/org/ofbiz/product/feature/ProductFeatureServices.java

Now I wonder if we really need to do this, do you agree folks ?

> Remove unused variables
> -----------------------
>
>                 Key: OFBIZ-525
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-525
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>         Attachments: ofbiz_unused_vars.diff
>
>
> Attached patch removes variables which are only assigned but never read.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-525?page=comments#action_12455987 ]
           
Stefan Huehner commented on OFBIZ-525:
--------------------------------------

Hi Jacques,

yes this patch addresses only part of the files containing unused variables. Just wanted to get the first bunch out. In addition i tried to leave some obvious/standard variables like 'delegator' in place.

The whole patch (series) is of course optional. I personally find i better to remove these vars, but one could equally say to leave them in case of future need.

Please if this is applicable. I'll put further work of this issue on hold until then.

> Remove unused variables
> -----------------------
>
>                 Key: OFBIZ-525
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-525
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>         Attachments: ofbiz_unused_vars.diff
>
>
> Attached patch removes variables which are only assigned but never read.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-525?page=comments#action_12456002 ]
           
Jacques Le Roux commented on OFBIZ-525:
---------------------------------------

Stefan,

I agree with you and will be happy to commit your work (here and future).
It's just that I would prefer that a least one core developper says what he thing about it.
If nobody involves I will begin commit next week (this his harmless).

> Remove unused variables
> -----------------------
>
>                 Key: OFBIZ-525
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-525
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>         Attachments: ofbiz_unused_vars.diff
>
>
> Attached patch removes variables which are only assigned but never read.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-525?page=comments#action_12456035 ]
           
Jacques Le Roux commented on OFBIZ-525:
---------------------------------------

Sorry for typos, I'm a bit tired

> Remove unused variables
> -----------------------
>
>                 Key: OFBIZ-525
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-525
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>         Attachments: ofbiz_unused_vars.diff
>
>
> Attached patch removes variables which are only assigned but never read.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-525?page=comments#action_12456197 ]
           
Jacopo Cappellato commented on OFBIZ-525:
-----------------------------------------

I think it's nice to clean up a bit of code... +1

> Remove unused variables
> -----------------------
>
>                 Key: OFBIZ-525
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-525
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>         Attachments: ofbiz_unused_vars.diff
>
>
> Attached patch removes variables which are only assigned but never read.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-525?page=comments#action_12456215 ]
           
Jacques Le Roux commented on OFBIZ-525:
---------------------------------------

Thanks Stefan,

Your 1st patch is in OFBiz revision: 483235, waiting for more I did not close this issue.

> Remove unused variables
> -----------------------
>
>                 Key: OFBIZ-525
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-525
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>         Attachments: ofbiz_unused_vars.diff
>
>
> Attached patch removes variables which are only assigned but never read.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-525?page=all ]

Stefan Huehner updated OFBIZ-525:
---------------------------------

    Attachment: ofbiz_unused_vars2.diff

Second part of the 'unused var' removal. I've completed the easy part with this one. For the rest (about 290 issues to be inspected) there is imho more investigation needed. As the unused vars seem to be there for future reference or are used in code with is currently commented out.

> Remove unused variables
> -----------------------
>
>                 Key: OFBIZ-525
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-525
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>         Attachments: ofbiz_unused_vars.diff, ofbiz_unused_vars2.diff
>
>
> Attached patch removes variables which are only assigned but never read.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-525?page=comments#action_12456265 ]
           
Stefan Huehner commented on OFBIZ-525:
--------------------------------------

We could leave this case open further for attaching smaller follow-up work but this could take some time. Then we would avoid spamming the jira with lots of (similar) issues.

> Remove unused variables
> -----------------------
>
>                 Key: OFBIZ-525
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-525
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>         Attachments: ofbiz_unused_vars.diff, ofbiz_unused_vars2.diff
>
>
> Attached patch removes variables which are only assigned but never read.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-525?page=comments#action_12456332 ]
           
Jacques Le Roux commented on OFBIZ-525:
---------------------------------------

Yes, that sounds good to me.

> Remove unused variables
> -----------------------
>
>                 Key: OFBIZ-525
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-525
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>         Attachments: ofbiz_unused_vars.diff, ofbiz_unused_vars2.diff
>
>
> Attached patch removes variables which are only assigned but never read.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-525?page=comments#action_12457074 ]
           
Jacques Le Roux commented on OFBIZ-525:
---------------------------------------

I forgot to say that the 2d patch was commited in rev. 483405

> Remove unused variables
> -----------------------
>
>                 Key: OFBIZ-525
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-525
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Stefan Huehner
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>         Attachments: ofbiz_unused_vars.diff, ofbiz_unused_vars2.diff
>
>
> Attached patch removes variables which are only assigned but never read.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira