[jira] Created: (OFBIZ-685) Move hard-coded UI layout code from header.ftl to the global decorator

[Nicolas Malin (Jira)]

Move hard-coded UI layout code from header.ftl to the global decorator
----------------------------------------------------------------------

                 Key: OFBIZ-685
                 URL: https://issues.apache.org/jira/browse/OFBIZ-685
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
            Reporter: Adrian Crum
            Priority: Minor
         Attachments: layoutsettings.patch, layoutsettings.patch

This patch improves upon the (old) Jira 174 issue of having a single file to control UI layout. Layout properties in framework/common/webcommon/includes/header.ftl have been moved to framework/common/widget/CommonScreens.xml.

Advantages:

1. A new user wanting to modify the UI layout needs to change only one file (the Global Decorator in CommonScreens.xml).
2. Components can now take their java scripts out of template (ftl) files and put them into separate files that are loaded via the component decorator and the layoutSettings map.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-685:
------------------------------

    Attachment: layoutsettings.patch

> Move hard-coded UI layout code from header.ftl to the global decorator
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-685
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-685
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: layoutsettings.patch, layoutsettings.patch
>
>
> This patch improves upon the (old) Jira 174 issue of having a single file to control UI layout. Layout properties in framework/common/webcommon/includes/header.ftl have been moved to framework/common/widget/CommonScreens.xml.
> Advantages:
> 1. A new user wanting to modify the UI layout needs to change only one file (the Global Decorator in CommonScreens.xml).
> 2. Components can now take their java scripts out of template (ftl) files and put them into separate files that are loaded via the component decorator and the layoutSettings map.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-685:
------------------------------

    Attachment: layoutsettings.patch

> Move hard-coded UI layout code from header.ftl to the global decorator
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-685
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-685
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: layoutsettings.patch, layoutsettings.patch
>
>
> This patch improves upon the (old) Jira 174 issue of having a single file to control UI layout. Layout properties in framework/common/webcommon/includes/header.ftl have been moved to framework/common/widget/CommonScreens.xml.
> Advantages:
> 1. A new user wanting to modify the UI layout needs to change only one file (the Global Decorator in CommonScreens.xml).
> 2. Components can now take their java scripts out of template (ftl) files and put them into separate files that are loaded via the component decorator and the layoutSettings map.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470146 ]

Chris Howe commented on OFBIZ-685:
----------------------------------

+1

> Move hard-coded UI layout code from header.ftl to the global decorator
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-685
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-685
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: layoutsettings.patch, layoutsettings.patch
>
>
> This patch improves upon the (old) Jira 174 issue of having a single file to control UI layout. Layout properties in framework/common/webcommon/includes/header.ftl have been moved to framework/common/widget/CommonScreens.xml.
> Advantages:
> 1. A new user wanting to modify the UI layout needs to change only one file (the Global Decorator in CommonScreens.xml).
> 2. Components can now take their java scripts out of template (ftl) files and put them into separate files that are loaded via the component decorator and the layoutSettings map.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470153 ]

Jacques Le Roux commented on OFBIZ-685:
---------------------------------------

Yes this seems rather a good idea : +1

> Move hard-coded UI layout code from header.ftl to the global decorator
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-685
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-685
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: layoutsettings.patch, layoutsettings.patch
>
>
> This patch improves upon the (old) Jira 174 issue of having a single file to control UI layout. Layout properties in framework/common/webcommon/includes/header.ftl have been moved to framework/common/widget/CommonScreens.xml.
> Advantages:
> 1. A new user wanting to modify the UI layout needs to change only one file (the Global Decorator in CommonScreens.xml).
> 2. Components can now take their java scripts out of template (ftl) files and put them into separate files that are loaded via the component decorator and the layoutSettings map.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470169 ]

Adrian Crum commented on OFBIZ-685:
-----------------------------------

I have been trying to define the line between widgets/bsh scripts and template(ftl) files to help explain this mod. The closest thing I can describe is: URLs within templates should always be variables. Those variables can be declared in bsh scripts, or widgets, or whatever. The templates then evaluate the variables to output the correct markup.

In other words, templates = HTML markup less content.

This patch removes content from templates.

> Move hard-coded UI layout code from header.ftl to the global decorator
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-685
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-685
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: layoutsettings.patch, layoutsettings.patch
>
>
> This patch improves upon the (old) Jira 174 issue of having a single file to control UI layout. Layout properties in framework/common/webcommon/includes/header.ftl have been moved to framework/common/widget/CommonScreens.xml.
> Advantages:
> 1. A new user wanting to modify the UI layout needs to change only one file (the Global Decorator in CommonScreens.xml).
> 2. Components can now take their java scripts out of template (ftl) files and put them into separate files that are loaded via the component decorator and the layoutSettings map.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473978 ]

Adrian Crum commented on OFBIZ-685:
-----------------------------------

A demonstration of this feature can be found in the experimental_6.patch file in OFBIZ-633.

> Move hard-coded UI layout code from header.ftl to the global decorator
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-685
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-685
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: layoutsettings.patch, layoutsettings.patch
>
>
> This patch improves upon the (old) Jira 174 issue of having a single file to control UI layout. Layout properties in framework/common/webcommon/includes/header.ftl have been moved to framework/common/widget/CommonScreens.xml.
> Advantages:
> 1. A new user wanting to modify the UI layout needs to change only one file (the Global Decorator in CommonScreens.xml).
> 2. Components can now take their java scripts out of template (ftl) files and put them into separate files that are loaded via the component decorator and the layoutSettings map.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-685:
---------------------------------------

    Assignee: Jacopo Cappellato

> Move hard-coded UI layout code from header.ftl to the global decorator
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-685
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-685
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Adrian Crum
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: layoutsettings.patch, layoutsettings.patch
>
>
> This patch improves upon the (old) Jira 174 issue of having a single file to control UI layout. Layout properties in framework/common/webcommon/includes/header.ftl have been moved to framework/common/widget/CommonScreens.xml.
> Advantages:
> 1. A new user wanting to modify the UI layout needs to change only one file (the Global Decorator in CommonScreens.xml).
> 2. Components can now take their java scripts out of template (ftl) files and put them into separate files that are loaded via the component decorator and the layoutSettings map.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-685.
-----------------------------------

    Resolution: Fixed

Adrian,

thanks. Your patch is in rev. 509270

> Move hard-coded UI layout code from header.ftl to the global decorator
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-685
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-685
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Adrian Crum
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: layoutsettings.patch, layoutsettings.patch
>
>
> This patch improves upon the (old) Jira 174 issue of having a single file to control UI layout. Layout properties in framework/common/webcommon/includes/header.ftl have been moved to framework/common/widget/CommonScreens.xml.
> Advantages:
> 1. A new user wanting to modify the UI layout needs to change only one file (the Global Decorator in CommonScreens.xml).
> 2. Components can now take their java scripts out of template (ftl) files and put them into separate files that are loaded via the component decorator and the layoutSettings map.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.