[jira] Created: (OFBIZ-669) Display bug in findParty.ftl

[Nicolas Malin (Jira)]

Display bug in findParty.ftl
----------------------------

                 Key: OFBIZ-669
                 URL: https://issues.apache.org/jira/browse/OFBIZ-669
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: party
            Reporter: Adrian Crum
            Priority: Minor
         Attachments: findParty.patch



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-669:
------------------------------

    Attachment: findParty.patch

On or around line 273 of findParty.ftl, there is some complicated if-else logic to display a party name in the Name column of the Parties Found table. The logic tests for partyRow.lastName and partyRow.groupName. Problem is, the GenericValue being used doesn't contain those fields, so the program flow always falls through to the line:

${Static["org.ofbiz.party.party.PartyHelper"].getPartyName(partyRow, true)}

resulting in blank entries for parties with no names. I believe the intention was to display "(No Name Found)" in those cases.

On top of that, one of the labels specified in this piece of code - uiLabelMap.PartyNoNameFound - doesn't exist in the properties file.

The attached patch fixes this bug.

> Display bug in findParty.ftl
> ----------------------------
>
>                 Key: OFBIZ-669
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-669
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: party
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: findParty.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray closed OFBIZ-669.
----------------------------

    Resolution: Fixed

Hi Adrian

I've committed a modified version of your patch in rev. 505761.  I kept the has_content conditions for lastName and groupName as the fields are actually added to the GenericValues via a DynamicViewEntity if the user searches by those fields in the view form, it saves us having to go back to the database unless necessary.

There was also a small bug in the findParty service which meant that the groupName wasn't being added to the dynamic view when a user searches by that field.

Thanks for your work
Scott

> Display bug in findParty.ftl
> ----------------------------
>
>                 Key: OFBIZ-669
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-669
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: party
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: findParty.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474239 ]

Adrian Crum commented on OFBIZ-669:
-----------------------------------

Scott,

Thank you very much for taking the time to look into this further and make the corrections. I should have spent more time looking into the real cause of the problem instead of just chopping out ftl code.

-Adrian

> Display bug in findParty.ftl
> ----------------------------
>
>                 Key: OFBIZ-669
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-669
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: party
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: findParty.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.