[jira] Created: (OFBIZ-807) Layout bug in order entry

[Nicolas Malin (Jira)]

Layout bug in order entry
-------------------------

                 Key: OFBIZ-807
                 URL: https://issues.apache.org/jira/browse/OFBIZ-807
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: order
            Reporter: Jacopo Cappellato


Adrian, all,

after the recent changes to layout styles the main order entry screen (show cart) of the Order component has now a huge blue bar (over the form to add new product to the cart).


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479934 ]

Adrian Crum commented on OFBIZ-807:
-----------------------------------

Jacopo,

I tried to find the screen you referred to, but couldn't. Could you give me a URL please?

Perhaps this was something introduced by the order entry checkout process refactor.

> Layout bug in order entry
> -------------------------
>
>                 Key: OFBIZ-807
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-807
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Jacopo Cappellato
>
> Adrian, all,
> after the recent changes to layout styles the main order entry screen (show cart) of the Order component has now a huge blue bar (over the form to add new product to the cart).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479938 ]

Jacopo Cappellato commented on OFBIZ-807:
-----------------------------------------

Adrian,

go to order, then select "order entry", then in the form in the top part of the screen, enter in the "party id" field a customer (for example "DemoCustomer"), and click "continue" (the link is in the right); submit the form in the next screen and you'll reach the page I was referring to.


 

> Layout bug in order entry
> -------------------------
>
>                 Key: OFBIZ-807
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-807
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Jacopo Cappellato
>
> Adrian, all,
> after the recent changes to layout styles the main order entry screen (show cart) of the Order component has now a huge blue bar (over the form to add new product to the cart).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479943 ]

Adrian Crum commented on OFBIZ-807:
-----------------------------------

Jacopo,

I found the screen. That blue bar is intentional and it is part of a screenlet. It has nothing to do with the stylesheet changes or widget refactor. Perhaps someone working on the order entry process added the screenlet recently.

> Layout bug in order entry
> -------------------------
>
>                 Key: OFBIZ-807
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-807
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Jacopo Cappellato
>
> Adrian, all,
> after the recent changes to layout styles the main order entry screen (show cart) of the Order component has now a huge blue bar (over the form to add new product to the cart).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480017 ]

Jacopo Cappellato commented on OFBIZ-807:
-----------------------------------------

Thanks for looking at it Adrian.
I did some tests and the issue seems related to the presence of the divs in the left columns: in fact the big blue box is rendered to be approximately of the same height of the left column... but here my poor knowledge of css can't help more, sorry.

Jacopo

> Layout bug in order entry
> -------------------------
>
>                 Key: OFBIZ-807
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-807
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Jacopo Cappellato
>
> Adrian, all,
> after the recent changes to layout styles the main order entry screen (show cart) of the Order component has now a huge blue bar (over the form to add new product to the cart).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480048 ]

Jacopo Cappellato commented on OFBIZ-807:
-----------------------------------------

The problematic instruction is at line 56 of the file order/webapp/ordermgr/entry/OrderEntryTabBar.ftl:

<div class="boxhead-fill">&nbsp;</div>

> Layout bug in order entry
> -------------------------
>
>                 Key: OFBIZ-807
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-807
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Jacopo Cappellato
>
> Adrian, all,
> after the recent changes to layout styles the main order entry screen (show cart) of the Order component has now a huge blue bar (over the form to add new product to the cart).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480206 ]

Adrian Crum commented on OFBIZ-807:
-----------------------------------

Jacopo,

It sounds like we are not seeing the same thing. That line renders a typical screenlet title bar on my browser and it doesn't look unusual. Maybe you could try a new checkout and see if the problem is still there.

> Layout bug in order entry
> -------------------------
>
>                 Key: OFBIZ-807
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-807
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Jacopo Cappellato
>
> Adrian, all,
> after the recent changes to layout styles the main order entry screen (show cart) of the Order component has now a huge blue bar (over the form to add new product to the cart).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480211 ]

Jacopo Cappellato commented on OFBIZ-807:
-----------------------------------------

Adrian,

sorry but I've just checked in the demo server too nad the issue is still there (see the attached image).

> Layout bug in order entry
> -------------------------
>
>                 Key: OFBIZ-807
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-807
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Jacopo Cappellato
>
> Adrian, all,
> after the recent changes to layout styles the main order entry screen (show cart) of the Order component has now a huge blue bar (over the form to add new product to the cart).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato updated OFBIZ-807:
------------------------------------

    Attachment: layout-bug.jpg

> Layout bug in order entry
> -------------------------
>
>                 Key: OFBIZ-807
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-807
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Jacopo Cappellato
>         Attachments: layout-bug.jpg
>
>
> Adrian, all,
> after the recent changes to layout styles the main order entry screen (show cart) of the Order component has now a huge blue bar (over the form to add new product to the cart).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480214 ]

Chris Howe commented on OFBIZ-807:
----------------------------------

lol....must not be seeing the same thing.  That looks like you have a float left playing with you some where

> Layout bug in order entry
> -------------------------
>
>                 Key: OFBIZ-807
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-807
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Jacopo Cappellato
>         Attachments: layout-bug.jpg
>
>
> Adrian, all,
> after the recent changes to layout styles the main order entry screen (show cart) of the Order component has now a huge blue bar (over the form to add new product to the cart).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480217 ]

Adrian Crum commented on OFBIZ-807:
-----------------------------------

Jacopo,

We're not seeing the same thing. That page looks normal on my local copy and the hotwax copy. I'm checking into it further...

> Layout bug in order entry
> -------------------------
>
>                 Key: OFBIZ-807
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-807
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Jacopo Cappellato
>         Attachments: layout-bug.jpg
>
>
> Adrian, all,
> after the recent changes to layout styles the main order entry screen (show cart) of the Order component has now a huge blue bar (over the form to add new product to the cart).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-807:
------------------------------

    Attachment: orderentry.patch

Jacopo,

See if the attached patch helps. It's hard for me to solve a problem that doesn't exist in my system, so this patch is a shot in the dark.

> Layout bug in order entry
> -------------------------
>
>                 Key: OFBIZ-807
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-807
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Jacopo Cappellato
>         Attachments: layout-bug.jpg, orderentry.patch
>
>
> Adrian, all,
> after the recent changes to layout styles the main order entry screen (show cart) of the Order component has now a huge blue bar (over the form to add new product to the cart).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480287 ]

Jacopo Cappellato commented on OFBIZ-807:
-----------------------------------------

Adrian,

it is not perfect but it looks much better (see attached patch)! Thanks.
I don't know why I am the only one to see this issue... maybe I need some rest... however I'm using Firefox and I tested it both in WinXP and in Ubuntu.

PS: I'd like to clarify that, when I report these layout issues, I don't pretend that you should fix them; of course your help is much appreciated, but you already did a lot of work in this area, and I appreciate it.

> Layout bug in order entry
> -------------------------
>
>                 Key: OFBIZ-807
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-807
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Jacopo Cappellato
>         Attachments: layout-bug.jpg, orderentry.patch
>
>
> Adrian, all,
> after the recent changes to layout styles the main order entry screen (show cart) of the Order component has now a huge blue bar (over the form to add new product to the cart).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato updated OFBIZ-807:
------------------------------------

    Attachment: new-layout.jpg

> Layout bug in order entry
> -------------------------
>
>                 Key: OFBIZ-807
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-807
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Jacopo Cappellato
>         Attachments: layout-bug.jpg, new-layout.jpg, orderentry.patch
>
>
> Adrian, all,
> after the recent changes to layout styles the main order entry screen (show cart) of the Order component has now a huge blue bar (over the form to add new product to the cart).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato updated OFBIZ-807:
------------------------------------

    Attachment: layout-temp.patch

What do you think of this patch? It is based on Adrian's one... still the layout is not very good, but it is not so bad.

> Layout bug in order entry
> -------------------------
>
>                 Key: OFBIZ-807
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-807
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Jacopo Cappellato
>         Attachments: layout-bug.jpg, layout-temp.patch, new-layout.jpg, orderentry.patch
>
>
> Adrian, all,
> after the recent changes to layout styles the main order entry screen (show cart) of the Order component has now a huge blue bar (over the form to add new product to the cart).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480330 ]

Christian Geisert commented on OFBIZ-807:
-----------------------------------------

Jacopo, you're not alone - I'm seeing the same problem ;-)

And I think the reason why everybody isn't seeing it is that it depends on the screen resolution. It happens only at 1280x1024 (85 dpi) with Firefox 2.0 at fullscreen for me. If I'm making the Firefox window smaller the blue area is disapearing. Konqueror doesn't show the Problem at all.

> Layout bug in order entry
> -------------------------
>
>                 Key: OFBIZ-807
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-807
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Jacopo Cappellato
>         Attachments: layout-bug.jpg, layout-temp.patch, new-layout.jpg, orderentry.patch
>
>
> Adrian, all,
> after the recent changes to layout styles the main order entry screen (show cart) of the Order component has now a huge blue bar (over the form to add new product to the cart).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-807:
------------------------------

    Attachment: maincss.patch

Jacopo,

Try this patch. Use the original, unmodified OrderEntryTabBar.ftl file.

> Layout bug in order entry
> -------------------------
>
>                 Key: OFBIZ-807
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-807
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>            Reporter: Jacopo Cappellato
>         Attachments: layout-bug.jpg, layout-temp.patch, maincss.patch, new-layout.jpg, orderentry.patch
>
>
> Adrian, all,
> after the recent changes to layout styles the main order entry screen (show cart) of the Order component has now a huge blue bar (over the form to add new product to the cart).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikrant Rathore updated OFBIZ-807:
----------------------------------

    Affects Version/s: SVN trunk

This issue has been resolved in the recent SVN version I just tried it.

> Layout bug in order entry
> -------------------------
>
>                 Key: OFBIZ-807
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-807
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Jacopo Cappellato
>         Attachments: layout-bug.jpg, layout-temp.patch, maincss.patch, new-layout.jpg, orderentry.patch
>
>
> Adrian, all,
> after the recent changes to layout styles the main order entry screen (show cart) of the Order component has now a huge blue bar (over the form to add new product to the cart).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikrant Rathore updated OFBIZ-807:
----------------------------------

    Attachment: createorder.JPG

Order entry issue resolved in SVN version.

> Layout bug in order entry
> -------------------------
>
>                 Key: OFBIZ-807
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-807
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Jacopo Cappellato
>         Attachments: createorder.JPG, layout-bug.jpg, layout-temp.patch, maincss.patch, new-layout.jpg, orderentry.patch
>
>
> Adrian, all,
> after the recent changes to layout styles the main order entry screen (show cart) of the Order component has now a huge blue bar (over the form to add new product to the cart).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480754 ]

Jacopo Cappellato commented on OFBIZ-807:
-----------------------------------------

Vikrant,

I'm sorry but the issue is already there but, as explained by Christian, it happens only with Firefox and 1280x1024 (85 dpi).
Adrian's last patch actually resolve the problem but makes the left label in the bar disappear... for this reason I've still not committed the patch even if it is a great improvement for 1280x1024 screens.

> Layout bug in order entry
> -------------------------
>
>                 Key: OFBIZ-807
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-807
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Jacopo Cappellato
>         Attachments: createorder.JPG, layout-bug.jpg, layout-temp.patch, maincss.patch, new-layout.jpg, orderentry.patch
>
>
> Adrian, all,
> after the recent changes to layout styles the main order entry screen (show cart) of the Order component has now a huge blue bar (over the form to add new product to the cart).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.