[jira] Created: (OFBIZ-818) performFind not behaving as expected with empty fields

[Nicolas Malin (Jira)]

performFind not behaving as expected with empty fields
------------------------------------------------------

                 Key: OFBIZ-818
                 URL: https://issues.apache.org/jira/browse/OFBIZ-818
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
            Reporter: Leon Torres


If a field such as facilityId is left empty, then the performFind should be ignoring that field in its lookup.  That is, it should lookup values regardless of what facilityId is.

However I found a case where leaving the facilityId field empty causes the lookup to behave as if it had a facilityId == NULL condition.  Thus if you leave it empty, then it will only match those values where facilityId is NULL.

What's perplexing is the same lookup where this bug occurs has a productId field that behaves correctly if left blank.  This means the performFind service is behaving differently where its behavior should be uniform.

The lookup can be seen in the following URL:

https://localhost:8443/ordermgr/control/ApprovedProductRequirements

And the bsh that invokes performFind is here,

order/webapp/ordermgr/WEB-INF/actions/requirement/ApprovedProductRequirements.bsh

The entity being looked up is Requirement.  

I think there could be an issue with the performFind service, but I am not familiar with how that service works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481115 ]

Jacopo Cappellato commented on OFBIZ-818:
-----------------------------------------

Chris,

I'm sorry I had not time to go into the details but maybe I designed that screen in this way intentionally (but I could be wrong).
I mean that if you select a "Bill To Customer Party Id" + "Supplier id" then the bottom form is changed into a multi form with the rows ready to be transformed into shopping cart items. However, we cannot create a purchase order with an empty facility id, so the screen filters the requirement by ONE facility.
In fact if you leave the "supplier id" empty, you can then search by facility (also empty) as usual.
See the example:
https://demo.hotwaxmedia.com/ordermgr/control/ApprovedProductRequirements

> performFind not behaving as expected with empty fields
> ------------------------------------------------------
>
>                 Key: OFBIZ-818
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-818
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>            Reporter: Leon Torres
>
> If a field such as facilityId is left empty, then the performFind should be ignoring that field in its lookup.  That is, it should lookup values regardless of what facilityId is.
> However I found a case where leaving the facilityId field empty causes the lookup to behave as if it had a facilityId == NULL condition.  Thus if you leave it empty, then it will only match those values where facilityId is NULL.
> What's perplexing is the same lookup where this bug occurs has a productId field that behaves correctly if left blank.  This means the performFind service is behaving differently where its behavior should be uniform.
> The lookup can be seen in the following URL:
> https://localhost:8443/ordermgr/control/ApprovedProductRequirements
> And the bsh that invokes performFind is here,
> order/webapp/ordermgr/WEB-INF/actions/requirement/ApprovedProductRequirements.bsh
> The entity being looked up is Requirement.  
> I think there could be an issue with the performFind service, but I am not familiar with how that service works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481116 ]

Jacopo Cappellato commented on OFBIZ-818:
-----------------------------------------

Sorry,

Leon, not Chris!!!

> performFind not behaving as expected with empty fields
> ------------------------------------------------------
>
>                 Key: OFBIZ-818
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-818
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>            Reporter: Leon Torres
>
> If a field such as facilityId is left empty, then the performFind should be ignoring that field in its lookup.  That is, it should lookup values regardless of what facilityId is.
> However I found a case where leaving the facilityId field empty causes the lookup to behave as if it had a facilityId == NULL condition.  Thus if you leave it empty, then it will only match those values where facilityId is NULL.
> What's perplexing is the same lookup where this bug occurs has a productId field that behaves correctly if left blank.  This means the performFind service is behaving differently where its behavior should be uniform.
> The lookup can be seen in the following URL:
> https://localhost:8443/ordermgr/control/ApprovedProductRequirements
> And the bsh that invokes performFind is here,
> order/webapp/ordermgr/WEB-INF/actions/requirement/ApprovedProductRequirements.bsh
> The entity being looked up is Requirement.  
> I think there could be an issue with the performFind service, but I am not familiar with how that service works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Si Chen closed OFBIZ-818.
-------------------------

    Resolution: Fixed

> performFind not behaving as expected with empty fields
> ------------------------------------------------------
>
>                 Key: OFBIZ-818
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-818
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>            Reporter: Leon Torres
>
> If a field such as facilityId is left empty, then the performFind should be ignoring that field in its lookup.  That is, it should lookup values regardless of what facilityId is.
> However I found a case where leaving the facilityId field empty causes the lookup to behave as if it had a facilityId == NULL condition.  Thus if you leave it empty, then it will only match those values where facilityId is NULL.
> What's perplexing is the same lookup where this bug occurs has a productId field that behaves correctly if left blank.  This means the performFind service is behaving differently where its behavior should be uniform.
> The lookup can be seen in the following URL:
> https://localhost:8443/ordermgr/control/ApprovedProductRequirements
> And the bsh that invokes performFind is here,
> order/webapp/ordermgr/WEB-INF/actions/requirement/ApprovedProductRequirements.bsh
> The entity being looked up is Requirement.  
> I think there could be an issue with the performFind service, but I am not familiar with how that service works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481214 ]

Leon Torres commented on OFBIZ-818:
-----------------------------------

Oh ok, that makes sense.  Thanks for the clarificatoin, Jacopo.

I suppose there's a UI issue here rather than a problem with performFind.

We can close this issue.

> performFind not behaving as expected with empty fields
> ------------------------------------------------------
>
>                 Key: OFBIZ-818
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-818
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>            Reporter: Leon Torres
>
> If a field such as facilityId is left empty, then the performFind should be ignoring that field in its lookup.  That is, it should lookup values regardless of what facilityId is.
> However I found a case where leaving the facilityId field empty causes the lookup to behave as if it had a facilityId == NULL condition.  Thus if you leave it empty, then it will only match those values where facilityId is NULL.
> What's perplexing is the same lookup where this bug occurs has a productId field that behaves correctly if left blank.  This means the performFind service is behaving differently where its behavior should be uniform.
> The lookup can be seen in the following URL:
> https://localhost:8443/ordermgr/control/ApprovedProductRequirements
> And the bsh that invokes performFind is here,
> order/webapp/ordermgr/WEB-INF/actions/requirement/ApprovedProductRequirements.bsh
> The entity being looked up is Requirement.  
> I think there could be an issue with the performFind service, but I am not familiar with how that service works.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.