[jira] Created: (OFBIZ-822) Re-Organize Navigation in Accounting component.

[Nicolas Malin (Jira)]

Re-Organize Navigation in Accounting component.
------------------------------------------------

                 Key: OFBIZ-822
                 URL: https://issues.apache.org/jira/browse/OFBIZ-822
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: accounting
            Reporter: Anil K Patel


Re-Organize navigation in Accounting component. Dojo Widgets to make application more easy to use.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel updated OFBIZ-822:
-------------------------------

    Attachment: RefacAccountingMenu.patch

Implements demo Menu using Dojo Menu Widgets. Feedback from community is will help.

> Re-Organize Navigation in Accounting component.
> ------------------------------------------------
>
>                 Key: OFBIZ-822
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-822
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: RefacAccountingMenu.patch
>
>
> Re-Organize navigation in Accounting component. Dojo Widgets to make application more easy to use.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Howe updated OFBIZ-822:
-----------------------------

    Attachment: hotAcctDojo.patch

hotAcctDojo.patch

Hey Anil, all

I'm not that familiar with the accounting app so I wanted to compare what you're proposing with what exists.  I quickly redid Anil's patch as a hot-deploy differences app so that the two can run side by side and the requests of interest can be pointed out easily.    I'm fairly certain that I've mapped everything correctly.  Let me know if I missed something.  This is my preferred way of adding/ changing things in OFBiz for a number of reasons that can be discussed on the ML if interested.

> Re-Organize Navigation in Accounting component.
> ------------------------------------------------
>
>                 Key: OFBIZ-822
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-822
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: hotAcctDojo.patch, RefacAccountingMenu.patch
>
>
> Re-Organize navigation in Accounting component. Dojo Widgets to make application more easy to use.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481518 ]

Tim Ruppert commented on OFBIZ-822:
-----------------------------------

Chris, this is actually an interesting, helpful was of being able to have these things run side by side if you've only got one instance running on your machine.  Thanks for that.

Now, whenever we decide whether or not this should go in to the project, my vote would be that this replaces the existing accounting menu structure since it's already enough tabs / apps for the user to deal with.  Just my two cents.

Anil, I'll try and take a peek at this this weekend.

> Re-Organize Navigation in Accounting component.
> ------------------------------------------------
>
>                 Key: OFBIZ-822
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-822
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: hotAcctDojo.patch, RefacAccountingMenu.patch
>
>
> Re-Organize navigation in Accounting component. Dojo Widgets to make application more easy to use.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel updated OFBIZ-822:
-------------------------------

    Attachment: RefacAccountingMenu.patch

Added few more menu options. Soon I'll connect menu to screens. This patch gives Idea about where I am going with this.

> Re-Organize Navigation in Accounting component.
> ------------------------------------------------
>
>                 Key: OFBIZ-822
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-822
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: hotAcctDojo.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch
>
>
> Re-Organize navigation in Accounting component. Dojo Widgets to make application more easy to use.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481625 ]

Chris Howe commented on OFBIZ-822:
----------------------------------

Tim,
I have only briefly looked at the few changes from the first patch, but on first glance it appears to have a different goal than the core OFBiz apps.  The goal Anil's patch appears to have is that it actually be used in production :) while the core apps' goal (at least up until now) is to demonstrate the services, possible features and various POCs that have been incorporated over the years (that is not necessarily a goal towards usability). I would love to see (and work on) specialized applications that take on a usability focus instead of a feature demonstration focus that do so by only playing with the widgets, like Anil's approach appears to be doing.  

At the same time there needs to be applications who's focus is based on the plethora of feature demonstrations as that's the focus that is best suited in getting the OFBiz consultant's work and the consultant's work is what drives most of the needs/improvements for the project.  The two focuses at times diverge, so keeping them in the same box (component) is often difficult.

> Re-Organize Navigation in Accounting component.
> ------------------------------------------------
>
>                 Key: OFBIZ-822
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-822
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: hotAcctDojo.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch
>
>
> Re-Organize navigation in Accounting component. Dojo Widgets to make application more easy to use.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481636 ]

Adrian Crum commented on OFBIZ-822:
-----------------------------------

Anil,

The Dojo menus look cool. Just fyi, what they do is not magic - we can do the same thing with our own style sheet and a little javascript.

One disadvantage to using Dojo - the visual elements are not scalable. Try changing your browser's default font and see what happens.

The menu widget could be refactored to produce the same style of menus. I'm not against using Dojo, I'm just suggesting that we already have the ability to do the same thing. I guess the question is, do we want to do the work ourselves or just rely on Dojo?

Chris - I like the idea of making the back office apps as attractive and user-friendly as possible. Two things that will accomplish - broader adoption and a best practices demonstration for custom built extensions.

> Re-Organize Navigation in Accounting component.
> ------------------------------------------------
>
>                 Key: OFBIZ-822
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-822
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: hotAcctDojo.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch
>
>
> Re-Organize navigation in Accounting component. Dojo Widgets to make application more easy to use.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481647 ]

Anil K Patel commented on OFBIZ-822:
------------------------------------

Thanks everybody for feedback.

Adrian, This is good to know that we can easily extend menu widgets to deliver desktop type menu. My knowledge of CSS and JavaScript is very limited. Will you be able to help me in this process. We can manage Permission's to Actions more easily if we used Menu widgets and also we don't have to learn and maintain another set of tools.

Chris, I think we should have discussion on what your are saying, I agree with you in a way, The apps in Ofbiz kind of act like Kitchen sink at times. I don't mind adding a component in specialized apps folder. I'll like to see more intuitive accounting application in Ofbiz. In current state it seems like unmaintained component.
Till we come to some conclusion I'll keep working on enhancements in Accounting component, Later if we decide to add Role based component then can move code out into new component.

> Re-Organize Navigation in Accounting component.
> ------------------------------------------------
>
>                 Key: OFBIZ-822
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-822
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: hotAcctDojo.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch
>
>
> Re-Organize navigation in Accounting component. Dojo Widgets to make application more easy to use.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481668 ]

Adrian Crum commented on OFBIZ-822:
-----------------------------------

Anil,

I like the idea of using <ul> HTML elements for menus. To see a demonstration, go here -

http://www.cssplay.co.uk/menus/final_drop.html

The menu widget could be refactored to support nested lists, and the corresponding style added to the style sheet.

> Re-Organize Navigation in Accounting component.
> ------------------------------------------------
>
>                 Key: OFBIZ-822
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-822
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: hotAcctDojo.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch
>
>
> Re-Organize navigation in Accounting component. Dojo Widgets to make application more easy to use.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481670 ]

Jonathon Wong commented on OFBIZ-822:
-------------------------------------

Adrian,

> The Dojo menus look cool. Just fyi, what they do is not magic - we can do the same thing with
> our own style sheet and a little javascript.
> One disadvantage to using Dojo - the visual elements are not scalable.

Agreed. I only ever use Dojo for AJAX. Actually, I'm intending to cut my deployed Dojo down to only the AJAX components; original Dojo size is around 300-400KB, too large.

> Re-Organize Navigation in Accounting component.
> ------------------------------------------------
>
>                 Key: OFBIZ-822
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-822
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: hotAcctDojo.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch
>
>
> Re-Organize navigation in Accounting component. Dojo Widgets to make application more easy to use.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel updated OFBIZ-822:
-------------------------------

    Attachment: RefacAccountingMenu.patch

Connected few menu items from AR menu to screens. Still long way to go.

> Re-Organize Navigation in Accounting component.
> ------------------------------------------------
>
>                 Key: OFBIZ-822
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-822
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: hotAcctDojo.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch
>
>
> Re-Organize navigation in Accounting component. Dojo Widgets to make application more easy to use.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel updated OFBIZ-822:
-------------------------------

    Attachment: RefacAccountingMenu.patch

Few interesting things in this patch,
Add Transaction form uses JSON for response.
Javascript specific to form is loaded at run time.

Above things may seen un necessary, But they are good POC.

This also acts as example for calling service from a Javascript.

> Re-Organize Navigation in Accounting component.
> ------------------------------------------------
>
>                 Key: OFBIZ-822
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-822
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: hotAcctDojo.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch
>
>
> Re-Organize navigation in Accounting component. Dojo Widgets to make application more easy to use.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482753 ]

Jacques Le Roux commented on OFBIZ-822:
---------------------------------------

Hi all,

Just tried, nice but sorry... yes not scalable. CSS (Adrian link) are doing better here... Seems like we are on the way of selecting the better tools for each task, do you agree ?

> Re-Organize Navigation in Accounting component.
> ------------------------------------------------
>
>                 Key: OFBIZ-822
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-822
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: hotAcctDojo.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch
>
>
> Re-Organize navigation in Accounting component. Dojo Widgets to make application more easy to use.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482782 ]

Anil K Patel commented on OFBIZ-822:
------------------------------------

This is for sure, I am Experimenting with Dojo Toolset to come up with something that makes users life easier.  When you say "Not Scalable", What do you mean? May be I am doing something wrong here and your comments may help.
Regards
Anil

> Re-Organize Navigation in Accounting component.
> ------------------------------------------------
>
>                 Key: OFBIZ-822
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-822
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: hotAcctDojo.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch
>
>
> Re-Organize navigation in Accounting component. Dojo Widgets to make application more easy to use.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482789 ]

Jacques Le Roux commented on OFBIZ-822:
---------------------------------------

Anil,

Like Adrian said "One disadvantage to using Dojo - the visual elements are not scalable. Try changing your browser's default font and see what happens. "

For instance, If you open a menu its submenu hide it. With CSS it's clean. From Adrian's comment I don't think you can do anything for this. I must also acknowledge that I don't know much about Dojo.

> Re-Organize Navigation in Accounting component.
> ------------------------------------------------
>
>                 Key: OFBIZ-822
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-822
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: hotAcctDojo.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch
>
>
> Re-Organize navigation in Accounting component. Dojo Widgets to make application more easy to use.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482790 ]

Adrian Crum commented on OFBIZ-822:
-----------------------------------

Anil,

To test the scalability of your modifications, change the default font size in your browser and see what happens.

A few comments on your patches:

Take an objective look at all of the nested divs plus java script in CompanyAccountsMenuBar.ftl - does that really seem like less work? Look at the page source of the link I posted - notice how it uses simple unordered lists with no java script.

GlAccountForms.js.ftl contains only java script, so why use a template? Just put this code in a .js file and load it via layoutSettings.javaScripts[] in the component's main decorator. Use the Party Manager as an example of how to set up component-specific java script files.

> Re-Organize Navigation in Accounting component.
> ------------------------------------------------
>
>                 Key: OFBIZ-822
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-822
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: hotAcctDojo.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch
>
>
> Re-Organize navigation in Accounting component. Dojo Widgets to make application more easy to use.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482806 ]

Jacques Le Roux commented on OFBIZ-822:
---------------------------------------

I must say that I agree with Adrian here. And in a more general manner I'd prefer to use CSS everywhere it proves its efficiency in place of Ajax or such (like Flash or avatars). Of course there are some fields where Ajax is welcome...

> Re-Organize Navigation in Accounting component.
> ------------------------------------------------
>
>                 Key: OFBIZ-822
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-822
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: hotAcctDojo.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch
>
>
> Re-Organize navigation in Accounting component. Dojo Widgets to make application more easy to use.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel updated OFBIZ-822:
-------------------------------

    Attachment: screenshot-1.jpg

I thought we can move Agreements, BillingAccounts, Financial Accounts, transactions etc as tabs on Party Accounts Screen.

Its this is ok, I'll clean  up the navigation and put up the patch.

Regards
Anil

> Re-Organize Navigation in Accounting component.
> ------------------------------------------------
>
>                 Key: OFBIZ-822
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-822
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: hotAcctDojo.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, screenshot-1.jpg, screenshot-1.jpg
>
>
> Re-Organize navigation in Accounting component. Dojo Widgets to make application more easy to use.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel updated OFBIZ-822:
-------------------------------

    Attachment: screenshot-1.jpg

I thought we can move Agreements, BillingAccounts, Financial Accounts, transactions etc as tabs on Party Accounts Screen.

Its this is ok, I'll clean  up the navigation and put up the patch.

Regards
Anil

> Re-Organize Navigation in Accounting component.
> ------------------------------------------------
>
>                 Key: OFBIZ-822
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-822
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: hotAcctDojo.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, screenshot-1.jpg, screenshot-1.jpg
>
>
> Re-Organize navigation in Accounting component. Dojo Widgets to make application more easy to use.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel updated OFBIZ-822:
-------------------------------

    Attachment: screenshot-2.jpg

Added Tab bar menu for tabs that have direct relation to Company we are doing Accounts for.
If this approch looks good then I'll move forward and complete task.

Please give feedback, Its important to complete first cut of improvements to this component.

> Re-Organize Navigation in Accounting component.
> ------------------------------------------------
>
>                 Key: OFBIZ-822
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-822
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: hotAcctDojo.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, RefacAccountingMenu.patch, screenshot-1.jpg, screenshot-1.jpg, screenshot-2.jpg
>
>
> Re-Organize navigation in Accounting component. Dojo Widgets to make application more easy to use.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.