[jira] Created: (OFBIZ-132) Changed the paymentMethodTypeId field optional="true" in createPayment service

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-132) Changed the paymentMethodTypeId field optional="true" in createPayment service

Nicolas Malin (Jira)
Changed the paymentMethodTypeId field optional="true" in createPayment service
------------------------------------------------------------------------------

                 Key: OFBIZ-132
                 URL: http://issues.apache.org/jira/browse/OFBIZ-132
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Ashish Vijaywargiya
            Priority: Minor


Hi,

I changed the input parameter value for paymentMethodTypeId field as optional="true" for createPayment service.
And changed some code in createPayment  service to check the null value of paymentMethodTypeId field.
If no one has issue with this please apply my patch.
Please give me your feedback on this.

Regards
Ashish Vijaywargiya

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-132) Changed the paymentMethodTypeId field optional="true" in createPayment service

Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-132?page=all ]

Ashish Vijaywargiya updated OFBIZ-132:
--------------------------------------

    Attachment: Aug_03_Accounting.patch

> Changed the paymentMethodTypeId field optional="true" in createPayment service
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-132
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-132
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: Aug_03_Accounting.patch
>
>
> Hi,
> I changed the input parameter value for paymentMethodTypeId field as optional="true" for createPayment service.
> And changed some code in createPayment  service to check the null value of paymentMethodTypeId field.
> If no one has issue with this please apply my patch.
> Please give me your feedback on this.
> Regards
> Ashish Vijaywargiya

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-132) Changed the paymentMethodTypeId field optional="true" in createPayment service

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-132?page=all ]

Si Chen closed OFBIZ-132.
-------------------------

    Resolution: Fixed

Committed SVN r 428529.  I added some comments into services xml about the sequence of things.  Also, you didn't need paymentMethodTypeId in the services xml any more--it is already defined as optional="true" since it is a nonpk field by the <auto-attribute>

> Changed the paymentMethodTypeId field optional="true" in createPayment service
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-132
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-132
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: Aug_03_Accounting.patch
>
>
> Hi,
> I changed the input parameter value for paymentMethodTypeId field as optional="true" for createPayment service.
> And changed some code in createPayment  service to check the null value of paymentMethodTypeId field.
> If no one has issue with this please apply my patch.
> Please give me your feedback on this.
> Regards
> Ashish Vijaywargiya

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira