[jira] Created: (OFBIZ-1946) Sandbox: Improve the Recurrence Rules

[Nicolas Malin (Jira)]

Sandbox: Improve the Recurrence Rules
-------------------------------------

                 Key: OFBIZ-1946
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1946
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Adrian Crum
            Priority: Minor


Improve the recurrence rules to support locales and time zones. Details in comments.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum reassigned OFBIZ-1946:
----------------------------------

    Assignee: Adrian Crum

> Sandbox: Improve the Recurrence Rules
> -------------------------------------
>
>                 Key: OFBIZ-1946
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1946
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>
> Improve the recurrence rules to support locales and time zones. Details in comments.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1946:
-------------------------------

    Attachment: RecurrenceRule.patch

RecurrenceRule.patch is a re-write of RecurrenceRule.java and RecurrenceInfo.java, plus some minor changes to calling classes.

As was discussed on the dev mailing list, there are a number of limitations and problems with the existing code. I tried to just fix the problems and limitations, but I ran into a number of places where the code just didn't work. So, this ended up being a major change instead of a minor one.

Existing recurrences should still work the same with this patch. I have confirmed that the job scheduling still works the same.

I need help with testing promotions - if anyone has promotions set up on their local copy, it would be great if they could test them against this patch.

This patch is a "first pass" through the code. Once it is tested and committed, there will be some additional work done to improve the recurrence rules.

> Sandbox: Improve the Recurrence Rules
> -------------------------------------
>
>                 Key: OFBIZ-1946
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1946
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: RecurrenceRule.patch
>
>
> Improve the recurrence rules to support locales and time zones. Details in comments.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1946:
-------------------------------

    Attachment:     (was: RecurrenceRule.patch)

> Sandbox: Improve the Recurrence Rules
> -------------------------------------
>
>                 Key: OFBIZ-1946
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1946
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: RecurrenceRule.patch
>
>
> Improve the recurrence rules to support locales and time zones. Details in comments.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1946:
-------------------------------

    Attachment: RecurrenceRule.patch

> Sandbox: Improve the Recurrence Rules
> -------------------------------------
>
>                 Key: OFBIZ-1946
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1946
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: RecurrenceRule.patch
>
>
> Improve the recurrence rules to support locales and time zones. Details in comments.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628281#action_12628281 ]

Bilgin Ibryam commented on OFBIZ-1946:
--------------------------------------

Adrian, I will test it this weekend.

> Sandbox: Improve the Recurrence Rules
> -------------------------------------
>
>                 Key: OFBIZ-1946
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1946
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: RecurrenceRule.patch
>
>
> Improve the recurrence rules to support locales and time zones. Details in comments.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628671#action_12628671 ]

Adrian Crum commented on OFBIZ-1946:
------------------------------------

I just found a serious problem with the Recurrence entities while trying to run the recurrence rules through some tests.

RecurrenceInfo has two fields - recurrenceRuleId and exceptionRuleId. In the RecurrenceInfo.java code, these two fields are used to look up RecurrenceRule records. The code builds one list for recurrence rules, and one list for exception rules. The problem is, in the RecurrrenceRule entity recurrenceId is a primary key - so you can't have more than one rule with the same ID. Bottom line - there is no way to create lists of rules.

Maybe we could add a sequenceId field (id-ne) to the RecurrenceRule entity and add it to the primary key.

> Sandbox: Improve the Recurrence Rules
> -------------------------------------
>
>                 Key: OFBIZ-1946
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1946
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: RecurrenceRule.patch
>
>
> Improve the recurrence rules to support locales and time zones. Details in comments.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1946:
-------------------------------

    Attachment: RecurrenceRule.patch

Updated patch has my proposed changes to the recurrence entities.

> Sandbox: Improve the Recurrence Rules
> -------------------------------------
>
>                 Key: OFBIZ-1946
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1946
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: RecurrenceRule.patch, RecurrenceRule.patch
>
>
> Improve the recurrence rules to support locales and time zones. Details in comments.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628883#action_12628883 ]

Adrian Crum commented on OFBIZ-1946:
------------------------------------

I know this is going to sound melodramatic, but it is exactly how I feel...

I give up.

I have spent more than a week trying to fix problems with this code and expand it to support locales and time zones while keeping it backwards compatible - and I have come to the conclusion that it is a lost cause. Even if I had the time and energy to complete it, it would be a mess of hacks and kludges.

I'd rather implement a new set of entities and classes and encourage others to migrate over to them.

I'm putting this on hold for a while.

> Sandbox: Improve the Recurrence Rules
> -------------------------------------
>
>                 Key: OFBIZ-1946
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1946
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: RecurrenceRule.patch, RecurrenceRule.patch
>
>
> Improve the recurrence rules to support locales and time zones. Details in comments.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-1946.
------------------------------

    Resolution: Won't Fix

Improved recurring events can be found here - https://issues.apache.org/jira/browse/OFBIZ-1956.

> Sandbox: Improve the Recurrence Rules
> -------------------------------------
>
>                 Key: OFBIZ-1946
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1946
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: RecurrenceRule.patch, RecurrenceRule.patch
>
>
> Improve the recurrence rules to support locales and time zones. Details in comments.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.