[jira] Created: (OFBIZ-2360) Route Segment does not show the shipments ready for shipping.

[Nicolas Malin (Jira)]

Route Segment does not show the shipments ready for shipping.
-------------------------------------------------------------

                 Key: OFBIZ-2360
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2360
             Project: OFBiz
          Issue Type: Bug
          Components: product
    Affects Versions: SVN trunk
         Environment: Red hat
            Reporter: Rohit Sureka


Hi,

The shipment route segment at the below URL does not show the packages, processed for shipment.

Rohit


https://demo.ofbiz.org/facility/control/EditShipmentRouteSegments?shipmentId=10002

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705555#action_12705555 ]

Deyan commented on OFBIZ-2360:
------------------------------

Suggested fix:

/applications/product/webapp/facility/WEB-INF/actions/shipment/EditShipmentRouteSegments.groovy:
1) ` add import import org.ofbiz.entity.condition.*
2) remove the "not" exclamation mark in the IF condition

if (shipmentId) {
    shipment = delegator.findOne("Shipment", [shipmentId : shipmentId], false);
}

-----------------------------------------------------------------------------------------------------

import org.ofbiz.base.util.*
import org.ofbiz.entity.condition.*


shipmentId = request.getParameter("shipmentId");
if (!shipmentId) {
    shipmentId = context.shipmentId;
}

shipment = null;
if (shipmentId) {
    shipment = delegator.findOne("Shipment", [shipmentId : shipmentId], false);
}

-------------------------------------------------------------------
I'm sorry,  I don't have dev access to the svn repository but i'm working on that :)

> Route Segment does not show the shipments ready for shipping.
> -------------------------------------------------------------
>
>                 Key: OFBIZ-2360
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2360
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Red hat
>            Reporter: Rohit Sureka
>
> Hi,
> The shipment route segment at the below URL does not show the packages, processed for shipment.
> Rohit
> https://demo.ofbiz.org/facility/control/EditShipmentRouteSegments?shipmentId=10002

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deyan updated OFBIZ-2360:
-------------------------

    Attachment: EditShipmentRouteSegments.groovy.patch

> Route Segment does not show the shipments ready for shipping.
> -------------------------------------------------------------
>
>                 Key: OFBIZ-2360
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2360
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Red hat
>            Reporter: Rohit Sureka
>         Attachments: EditShipmentRouteSegments.groovy.patch
>
>
> Hi,
> The shipment route segment at the below URL does not show the packages, processed for shipment.
> Rohit
> https://demo.ofbiz.org/facility/control/EditShipmentRouteSegments?shipmentId=10002

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705555#action_12705555 ]

Deyan edited comment on OFBIZ-2360 at 5/6/09 3:30 AM:
------------------------------------------------------

Fix suggested in the patch file attached.

      was (Author: deyan):
    Suggested fix:

/applications/product/webapp/facility/WEB-INF/actions/shipment/EditShipmentRouteSegments.groovy:
1) ` add import import org.ofbiz.entity.condition.*
2) remove the "not" exclamation mark in the IF condition

if (shipmentId) {
    shipment = delegator.findOne("Shipment", [shipmentId : shipmentId], false);
}

-----------------------------------------------------------------------------------------------------

import org.ofbiz.base.util.*
import org.ofbiz.entity.condition.*


shipmentId = request.getParameter("shipmentId");
if (!shipmentId) {
    shipmentId = context.shipmentId;
}

shipment = null;
if (shipmentId) {
    shipment = delegator.findOne("Shipment", [shipmentId : shipmentId], false);
}

-------------------------------------------------------------------
I'm sorry,  I don't have dev access to the svn repository but i'm working on that :)
 

> Route Segment does not show the shipments ready for shipping.
> -------------------------------------------------------------
>
>                 Key: OFBIZ-2360
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2360
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Red hat
>            Reporter: Rohit Sureka
>         Attachments: EditShipmentRouteSegments.groovy.patch
>
>
> Hi,
> The shipment route segment at the below URL does not show the packages, processed for shipment.
> Rohit
> https://demo.ofbiz.org/facility/control/EditShipmentRouteSegments?shipmentId=10002

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.