OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-3442) Replace popup lookups by layer lookups

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

75 messages Options

1234

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-3442) Replace popup lookups by layer lookups

Replace popup lookups by layer lookups
--------------------------------------

Key: OFBIZ-3442
URL: https://issues.apache.org/jira/browse/OFBIZ-3442
Project: OFBiz
Issue Type: Improvement
Components: ALL COMPONENTS
Reporter: Jacques Le Roux
Priority: Minor

Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.

For that please find a patch attached. In this patch I followed a simple S/R tactic:
* I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
* I replaced all occurences of <lookup by <lookup presentation="layer" position="center"

It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.

I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.

The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.

Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3442) Replace popup lookups by layer lookups

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830046#action_12830046 ]

Sascha Rodekamp commented on OFBIZ-3442:
----------------------------------------

ui quiet a big one :-D.

I will have a look.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-3442:
--------------------------------------

Assignee: Jacques Le Roux

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3442:
-----------------------------------

Attachment: OFBIZ-3442 replace popup lookups by layered lookups.patch

Previous patch version wa removing the std LookupDecorator. We still need it of course.
Notably because for now we can't call a layered lookup from a layered lookup.

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3442:
-----------------------------------

Attachment: OFBIZ-3442 replace popup lookups by layered lookups.patch

New patch
* includes flt files. For syntactic reasons these lokups will not be centered by default but at "normal" position
* remove previously layerer lookups which are actually lists (locales, timezones and themes) I have commited a change for that at r907310 (renamed them List instead of Lookup to avoid confusion)

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830594#action_12830594 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

More to come, crossed many small bugs, any from the layering lookup effort so far... I think I will commit soon...

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830696#action_12830696 ]

Sascha Rodekamp commented on OFBIZ-3442:
----------------------------------------

hi Jacques,
i had a look to your patch.
The Accounting Module works fine with the new lookups.
But by replacing the decorator screens in the common modul, some other (old) lookups looks quite ugly now :-) (They uses the new decorator which didn't load the nessary css files for the (old) lookups). You can see this i.e. in the catalog manager. [https://localhost:8443/catalog/control/main].

It's not a big deal, i think, because it's only for the interim period.

Have a nice day (WE)

Sascha

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830701#action_12830701 ]

Sascha Rodekamp commented on OFBIZ-3442:
----------------------------------------

The same issue occurs if you try to change your visual theme or language.

The Screen "ListVisualThemes" loads the LookupLayerPopupDecorator, but should load the LookupDecorator.

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830711#action_12830711 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

Hi Sascha,

Did you try with a fresh checkout (without prior layer related changes) using the last patch? Because, as you read in my comment above I did take care of the ListVisualThemes like issues (and it works well on my machine, though I did not find how to test the time zones case).

What do you mean exactly by looking ugly, with which themes did you try? I used mostly Dropping Crumb for my tests and appart issues with LookupTreeContent and LookupDetailContentTree, all seems to work correctly here.

So it's almost done now and I will commit as soon as I wil have resolved the 2 issues above (I'm struggling with them from a moment and just go round in circles for now)

Thanks for your help.

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830712#action_12830712 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

Forgot to say that I tested almost all screens...Only Sales app has to be reviewed, I will do soon...

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830727#action_12830727 ]

Sascha Rodekamp commented on OFBIZ-3442:
----------------------------------------

hm jep jacques i performed an update before i tested your patch.
I looked in the common LookupScreens and the visualTheme Screen calls the LookupLayerPopupDecorator.
The line 5104 in your last patch you cahnage the Decorator :-).

I looked in Theme BizzTime and BlueLight

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830731#action_12830731 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

SFA looks good but some not related bugs I found, also in Party.
I think a week more is needed to clarify all that...

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Issue Comment Edited: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830731#action_12830731 ]

Jacques Le Roux edited comment on OFBIZ-3442 at 2/7/10 5:21 PM:
----------------------------------------------------------------

SFA looks good but some not related bugs I found, also in Party an Project.

I think a week more is needed to clarify all that...

was (Author: jacques.le.roux):
SFA looks good but some not related bugs I found, also in Party.
I think a week more is needed to clarify all that...

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830737#action_12830737 ]

Bilgin Ibryam commented on OFBIZ-3442:
--------------------------------------

Hi Jacques and Sascha, this a great addition, thanks a lot for working on it.

I did some quick tests. Here is what I found.

Before few weeks I added autocompleter support to lookup fields. (If you didn't see it, just type one/two letters in a lookup field and you can select an entry w/o using the lookup button). It was missing in LookupLayerPopupDecorator and I added it in r907456. Now autocompleter and layered lookups work together fine :)

I didn't follow all the development process of the layered lookups, but why not change the default values in the schema of presentation and position elements to layer and center respectively. Then we don't need to add these attributes in all the forms.

Also I found a bug caused when user session is destroyed: Log into an application (accounting for example) and select a form - layered lookups work correct. In another tab log into another application and then log out. Then on the first tab (accounting) try to use a lookup. In the lookup screen you will get the login screen (that's OK) but once you enter your username and password you get a blank screen.

Bilgin

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830753#action_12830753 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

Hi Bilgin,

Thanks for your help on autocomplete, it's great to see a community in action :)

We need to keep the LookupDecorator, but yes not sure it should be the default now (after a deep testing session this weekend). We need to discuss that on dev ML though, to be sure that a large consensus is reached and we don't miss something before making layer the default presentation.

Maybe having center as default position is also a good idea, for instance it's where dialog boxes (Windows) and such open on most OS. I think we need to discuss this as well on dev ML...

I already opened an issue (sub-task acutally OFBIZ-3450)for the case you detailled, I will put your details, thanks!

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3442:
-----------------------------------

Attachment: OFBIZ-3442 replace popup lookups by layered lookups.patch

Hi Jacques,

i have a small update for your patch. Fixed the layout problem with the choose visual theme and choose language lookups.

Best regards
Sascha

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839686#action_12839686 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

Hi Sascha,

Yes I had fixed that already. As I use the layered lookups in a custom application I had to fix it there. I fixed also the ListTimezones but at this time I did not create a patch as I thought I would commit all the changes. Actually it's ready to be commited for almost a month now and I think I will really commit pretty soon. I think I will let apart the lookups which are not working (with or without layering) to not let think we introduced bugs with the layering... Except if Iget enough time to fix them...

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

1234