[jira] Created: (OFBIZ-3442) Replace popup lookups by layer lookups

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858537#action_12858537 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

I tried to revert, and, after some necessary changes here and there, I believe we should better handle the new situation...

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858545#action_12858545 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

I have no time right now but ASAP I will update the patch because It's not good anymore (because of changes in htmlFormMacroLibrary.ftl)

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3442:
-----------------------------------

    Attachment: OFBIZ-3442 replace popup lookups by layered lookups.patch

New patch, finally was not a big deal

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3442:
-----------------------------------

    Attachment: OFBIZ-3442 replace popup lookups by layered lookups.patch

Keep things simple

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3442:
-----------------------------------

    Attachment:     (was: OFBIZ-3442 replace popup lookups by layered lookups.patch)

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3442:
-----------------------------------

    Attachment: LayoutFixes.patch

Layout Fix for the issue you posted above.

The min/max button was shown incorrect and the lookup image in a lookup wasen't displayed.

So long

Sascha

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: LayoutFixes.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858878#action_12858878 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

Hi Sascha,

Yes I agree, I figured out yesterday that the min/max button was not needed at all, though I was not quite sure at this time. Unfortunately I was not able to apply your patch because it's oudated (Tomahawk theme only), could you please update and create a new patch?

TIA

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: LayoutFixes.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3442:
-----------------------------------

    Attachment: LayoutFixes.patch

OK Jacques here we go :-) LayoutFix.patch update against the latest trunk

So long

Sascha

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: LayoutFixes.patch, LayoutFixes.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858985#action_12858985 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

Thanks Sascha,

Your patch is in trunk at r936008. However the main reason(min/max button)  is still not fixed in the case of lookups rendered from FTL files. I guess it's because it's not the same rendering mechanism.

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: LayoutFixes.patch, LayoutFixes.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859275#action_12859275 ]

Sascha Rodekamp commented on OFBIZ-3442:
----------------------------------------

Hi Jacques, jep i had the same issue in my project, when calling the lookups directly. I will have a look this night and try to fix it :)

So long Sascha

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: LayoutFixes.patch, LayoutFixes.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3442:
-----------------------------------

    Attachment: LayoutFixMinMaxTomah.patch

Hi Jacques,

this little patch should fix the layout bugs when the lookup is called directly from a n ftl file.
(It fixes the problems in Tomahawk with the min/max button). If you find more layout bugs relating this issue, cann you make a screenshot for me ??

Have a nice day

Sascha

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: LayoutFixes.patch, LayoutFixes.patch, LayoutFixMinMaxTomah.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3442:
-----------------------------------

    Attachment: Min-max issue from FTL.jpg

Hi Sascha,

Which the layout bugs (when the lookup is called directly from FTL) should this patch resolves? Because as you can see in the "Min-max issue from FTL" there is still the error after having applied it. Note that it does not depend of the theme. BTW this should be better addressed in the issue I specially created for this problem: OFBIZ-3692.

Also it supposes that you have applied the patch above (OFBIZ-3442 replace popup lookups by layered lookups.patch) on a clean trunk checkout

Thanks

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: LayoutFixes.patch, LayoutFixes.patch, LayoutFixMinMaxTomah.patch, Min-max issue from FTL.jpg, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860168#action_12860168 ]

Sascha Rodekamp commented on OFBIZ-3442:
----------------------------------------

Ah ok, i tohught you mean the missplacing of the min/max button in Tomahawk theme, and the text 'Advanced Search' had a line break because of a to small div. This is what the patch fixes :-) Just two simple layout issues ;)

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: LayoutFixes.patch, LayoutFixes.patch, LayoutFixMinMaxTomah.patch, Min-max issue from FTL.jpg, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860185#action_12860185 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

Thanks for clarification Sascha,

Your patch is in trunk at r937191  

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: LayoutFixes.patch, LayoutFixes.patch, LayoutFixMinMaxTomah.patch, Min-max issue from FTL.jpg, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3442.
----------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed

Completed: At revision: 937852  

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: LayoutFixes.patch, LayoutFixes.patch, LayoutFixMinMaxTomah.patch, Min-max issue from FTL.jpg, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.