[jira] Created: (OFBIZ-3442) Replace popup lookups by layer lookups

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3442:
-----------------------------------

    Attachment: OFBIZ-3442 replace popup lookups by layered lookups.patch

This is the last patch with the minium modifications needed to replace all popup lookups by layered lookup. I have already identified some cases where we want not to use layered lookups. LookupTimeDuration is one there are maybe others but I wonder at this stage if I will get enough support from this issue or I will not rather commit as is and wait returns to fix issues as it's realy easy to fix since a simple <<presentation="window">> attribute does the trick

As I said there are still some issues though, notably with

# the last lookup (at bottom) of ttps://localhost:8443/workeffort/control/EditWorkEffort?workEffortTypeId=TASK&currentStatusId=CAL_NEEDS_ACTION : look for ProductId inside. This is something specific to layer in layer and we have already OFBIZ-3446 opened for that
# same with https://localhost:8443/content/control/FindSurvey (acroform)
# also https://localhost:8443/assetmaint/control/LookupWorkEffort (recursive issue: look for parent) we have already OFBIZ-3693 opened for that
# The minimize/enlarge buttons (+ -) blocks the layer see OFBIZ-3692
# I saw still some problems in themes other than Tomahawk

According to Ankit Jain (see OFBIZ-3446), it seems that when you use the attribute <<presentation="layer">> attribute some of these issues does not exist. I have also noticed some differences but at this stage I'm not quite sure. I will revisit this ASAP but maybe not today.

I'd really appreciate more testing, thanks for you help

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857234#action_12857234 ]

Jacques Le Roux edited comment on OFBIZ-3442 at 4/15/10 4:36 AM:
-----------------------------------------------------------------

This is the last patch with the minium modifications needed to replace all popup lookups by layered lookup. I have already identified some cases where we want not to use layered lookups. LookupTimeDuration is one there are maybe others but I wonder at this stage if I will get enough support from this issue or I will not rather commit as is and wait returns to fix issues as it's realy easy to fix since a simple <<presentation="window">> attribute does the trick

As I said there are still some issues though, notably with

# the last lookup (at bottom) of https://localhost:8443/workeffort/control/EditWorkEffort?workEffortTypeId=TASK&currentStatusId=CAL_NEEDS_ACTION : look for ProductId inside. This is something specific to layer in layer and we have already OFBIZ-3446 opened for that
# same with https://localhost:8443/content/control/FindSurvey (acroform)
# also https://localhost:8443/assetmaint/control/LookupWorkEffort (recursive issue: look for parent) we have already OFBIZ-3693 opened for that
# The minimize/enlarge buttons (+ -) blocks the layer see OFBIZ-3692
# I saw still some problems in themes other than Tomahawk

According to Ankit Jain (see OFBIZ-3446), it seems that when you use the attribute <<presentation="layer">> attribute some of these issues does not exist. I have also noticed some differences but at this stage I'm not quite sure. I will revisit this ASAP but maybe not today.

I'd really appreciate more testing, thanks for you help

      was (Author: jacques.le.roux):
    This is the last patch with the minium modifications needed to replace all popup lookups by layered lookup. I have already identified some cases where we want not to use layered lookups. LookupTimeDuration is one there are maybe others but I wonder at this stage if I will get enough support from this issue or I will not rather commit as is and wait returns to fix issues as it's realy easy to fix since a simple <<presentation="window">> attribute does the trick

As I said there are still some issues though, notably with

# the last lookup (at bottom) of ttps://localhost:8443/workeffort/control/EditWorkEffort?workEffortTypeId=TASK&currentStatusId=CAL_NEEDS_ACTION : look for ProductId inside. This is something specific to layer in layer and we have already OFBIZ-3446 opened for that
# same with https://localhost:8443/content/control/FindSurvey (acroform)
# also https://localhost:8443/assetmaint/control/LookupWorkEffort (recursive issue: look for parent) we have already OFBIZ-3693 opened for that
# The minimize/enlarge buttons (+ -) blocks the layer see OFBIZ-3692
# I saw still some problems in themes other than Tomahawk

According to Ankit Jain (see OFBIZ-3446), it seems that when you use the attribute <<presentation="layer">> attribute some of these issues does not exist. I have also noticed some differences but at this stage I'm not quite sure. I will revisit this ASAP but maybe not today.

I'd really appreciate more testing, thanks for you help
 

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857688#action_12857688 ]

Sascha Rodekamp commented on OFBIZ-3442:
----------------------------------------

Hi Jacques,

sry for mmy late response. Good idea with the min. modifications. I tested your patch and i see one issue. You changed the call method but not the lookups itself. Remember we set an extra decorator for the new lookups because of the different behavior (LookupLayerPopupDecorator). That causes some issus when i try to open a layer form a layer (tested in Workeffort). I think the easiest way to fix this is to make the new decorator default (rename in "LookupLayerDecorator" and the old LookupLayerDecorator in "LookupLayerWindowDecorator") then you have to do only a few changes in the decorators you want to open in the classic way.

What do you think about it??

Have a nice day

Sascha

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3442:
-----------------------------------

    Attachment: lookup.htm

Hi Sascha,

Yes I wondered about that, but as I got the same kind of issues (as you layer in layer, findsurvery and workeffort as well) with or without them I took this way for testing (I should have look into code but did not have time at this moment). I have attached a kind of diff file (lookup.html) and apart collapsible="true" ws "false" I'm not quite sure there are much needs to change... Are the snippets you removed issues in the layer (notably including ftl templates)?

Ha, also I thought that we would like to expose both cases in example (layer and window) but this is easy, just use <<presentation="window">>

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: lookup.htm, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857790#action_12857790 ]

Sascha Rodekamp commented on OFBIZ-3442:
----------------------------------------

The Main part to remove in the new decorator was the header and footer including, they are not needed in the new lookup.
Also shouldn't be the lookup.ftl loaded in the layer lookup because it causes some site effects with the set value function.

:)

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: lookup.htm, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857832#action_12857832 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

I see, If we could pass a parameter like it's done for parameters.ajaxLookup then we could handle that locally with fail-widget. I'd prefer to have only one decorator as they are almost the same. For instance a block was recentlu added by Erwan at r897843 and miss in the new layer decorator.

BTW I believe there is still an issue with ajaxLookup when the lookup is called from an FTL file. We could fix the 2 in a single shoot...

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: lookup.htm, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857885#action_12857885 ]

Sascha Rodekamp commented on OFBIZ-3442:
----------------------------------------

jap Jacques good point. We should do it!

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: lookup.htm, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857901#action_12857901 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

Bilgin,

Could you have a look at the parameters.ajaxLookup thing when you get a chance? I'm maybe wrong or missing something, but it looks to me like it's not working from FTL files. Then when we will have this mechanism from both side (FTL and forms) we will use it as I suggested above to differentiate lookups types (layer vs window) and we should be done (but some minor issues still crawling around)

TIA

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: lookup.htm, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858117#action_12858117 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

Hi Bilgin,

Forget what I said, I saw the ajaxLookup working in an FTL field (Customer field in the 1st Order Entry screen in Order Manager). It's weird in Firefox 3.6.3 because some time it works some time not (but with my 58 plugins ;o). It's ok in Opera. I don't remember if I have not opened a Jira issue for that (I don't this so), maybe I simply wrote something about that in another place.

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: lookup.htm, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3442:
-----------------------------------

    Attachment: OFBIZ-3442_OnlyOneLookupFix.patch

Hi Jacques,

i removed the second Decorator. Now your previous patch should work with the default lookupDecorator.

Cheers

Sascha

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: lookup.htm, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442_OnlyOneLookupFix.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858491#action_12858491 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

Thanks Sascha,

Your slightly modified patch is in trunk at r935578 but the the FormWidgetExampleForms.xml change: I want to keep an old style lookup to allow the comparaison after the change

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3442:
-----------------------------------

    Attachment:     (was: OFBIZ-3442_OnlyOneLookupFix.patch)

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3442:
-----------------------------------

    Attachment:     (was: lookup.htm)

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858493#action_12858493 ]

Sascha Rodekamp commented on OFBIZ-3442:
----------------------------------------

Hi Jacques,

jep thanks. OK i was wondering, why the first lookup up is an old style lookup :-D, thats why i changed it... So no problem

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858497#action_12858497 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

I tested with Flat Grey and Tomahawk

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858498#action_12858498 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

BTW from the change in your patch I wonder if it's not another commit which has changed things. Fortunately I have another instance to test, right now...

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858500#action_12858500 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

Confirmation, another commit (related to Blas's patches ?) has broken the inside buttons...

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858502#action_12858502 ]

Sascha Rodekamp commented on OFBIZ-3442:
----------------------------------------

Jep i noticed this issue, the pagination buttons are broken too. Hm i don't know what happened.

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858521#action_12858521 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

Maybe r935312...

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858533#action_12858533 ]

Sascha Rodekamp commented on OFBIZ-3442:
----------------------------------------

Jep that might be the problem, i will have look tomorrow morning. And try to figure out what happened.

> Replace popup lookups by layer lookups
> --------------------------------------
>
>                 Key: OFBIZ-3442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3442
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups  OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> *  I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.