OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-3442) Replace popup lookups by layer lookups

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

75 messages Options

1234

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839691#action_12839691 ]

Sascha Rodekamp commented on OFBIZ-3442:
----------------------------------------

Hi Jacques,
that sounds great... so if there anythink where i can help you... let me know! I think we can handle this :)

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839773#action_12839773 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

Also, though I agree with Bilgin on the defaults to use, I think I will commit as is for now. For this 2 reasons:
# It's easy to change later with a S/R and small changes in XSD
# I'm not quite sure we should use these defaults without exchanging before with the community. However so far, we are few to be really interested (or simply aware), but I guess after it will be commited a lot of discussion will occurs and maybe new ideas, etc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3442:
-----------------------------------

Attachment: OFBIZ-3442 replace popup lookups by layered lookups.patch

Last patch and last chance to test before commit

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841605#action_12841605 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

Please don't use the patches here they are buggy and I should hopefuly post another tomorrow which should fix some issues I found (not due to layered lookup feature itself but its limitations, for instance you can't call a lookup from a lookup yet: OFBIZ-3446)

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3442:
-----------------------------------

Component/s: (was: ALL COMPONENTS)
ALL APPLICATIONS
Description:
Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.

For that please find a patch attached. In this patch I followed a simple S/R tactic:
* I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
* I replaced all occurences of <lookup by <lookup presentation="layer" position="center"

It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.

I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.

The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.

Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

There are issues to be fixed prior to a commit, see OFBIZ-3446.

was:
Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.

For that please find a patch attached. In this patch I followed a simple S/R tactic:
* I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
* I replaced all occurences of <lookup by <lookup presentation="layer" position="center"

It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.

I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.

The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.

Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841982#action_12841982 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

To bypass the lookup in lookup issue, in a 1s time I will use the bad way (easier for now). Then I will create the extends+extends-resource mechanims for lookup, will use it and remove then the unneeded entries in controllers. Another better way would be to "fix" the lookup in lookup. But I prefer to do that later...

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3442:
-----------------------------------

Attachment: OFBIZ-3442 replace popup lookups by layered lookups.patch

A patch without the ftl changes and without the lookups calling a lookup inside. We still need to make the changes in FTL file and test OFBIZ-3446 thoroughly and the layered lookups will be done (but 2 not blocking small issues, see the umbrella task)

Note that the effort for lookup in ftl files is a part of OFBIZ-3541 and is well explained [here|https://issues.apache.org/jira/browse/OFBIZ-3530?focusedCommentId=12840569&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12840569
]

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Issue Comment Edited: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847960#action_12847960 ]

Jacques Le Roux edited comment on OFBIZ-3442 at 3/21/10 6:52 PM:
-----------------------------------------------------------------

A patch without the ftl changes and without the lookups calling a lookup inside. We still need to make the changes in FTL file and test OFBIZ-3446 thoroughly and the layered lookups will be done (but 2 not blocking small issues, see the umbrella task)

Note that the effort for lookup in ftl files is a part of OFBIZ-3541 and is well explained [here|https://issues.apache.org/jira/browse/OFBIZ-3530?focusedCommentId=12840569&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12840569]

was (Author: jacques.le.roux):
A patch without the ftl changes and without the lookups calling a lookup inside. We still need to make the changes in FTL file and test OFBIZ-3446 thoroughly and the layered lookups will be done (but 2 not blocking small issues, see the umbrella task)

Note that the effort for lookup in ftl files is a part of OFBIZ-3541 and is well explained [here|https://issues.apache.org/jira/browse/OFBIZ-3530?focusedCommentId=12840569&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12840569
]

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Issue Comment Edited: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850592#action_12850592 ]

Jacques Le Roux edited comment on OFBIZ-3442 at 3/27/10 10:28 PM:
------------------------------------------------------------------

There is now an incomplete patch for flt files at OFBIZ-3541

I wonder if I will not create a branch for this.

was (Author: jacques.le.roux):
There is now an incomplete patch for flt files at OFBIZ-3441

I wonder if I will not create a branch for this.

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850984#action_12850984 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

Sascha, Bilgin,

I thought a bit more about the default position. Actually Sascha followed how the calendar was working and created the "normal" postion as default. We talked about making center the default, but I think we should keep the position used previously but the lookups: topleft. Not much because it was there before, but rather because it's the better position when you need to enlarge the lookup. There is only one thing to do: drag the right bottom corner. It's easier than in any other position. So will finally make it the default. I will also rename "normal" to "near".

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851051#action_12851051 ]

Sascha Rodekamp commented on OFBIZ-3442:
----------------------------------------

Jep Jacques, thats a good point and shouldn't be a problem to change.

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851381#action_12851381 ]

Bilgin Ibryam commented on OFBIZ-3442:
--------------------------------------

Jacques,

what I tried to say is that the default position (it doesn't matter for me if it is center , normal or something else) should be set only in xsd file, but not in all the forms and fields. This way, changing the default position will require only a change in xsd file instead of all the form fields.

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851387#action_12851387 ]

Jacques Le Roux commented on OFBIZ-3442:
----------------------------------------

Yes sure Bilgin,

I totally agree, that's what I will do, as I said ;) For the moment I did not change in the patch because I was not sure of the default position. But, like you suggested, it will be at end without layer= and position=

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch
>
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3442) Replace popup lookups by layer lookups

In reply to this post by Nicolas Malin (Jira)

> Replace popup lookups by layer lookups
> --------------------------------------
>
> Key: OFBIZ-3442
> URL: https://issues.apache.org/jira/browse/OFBIZ-3442
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
>
> Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.
> For that please find a patch attached. In this patch I followed a simple S/R tactic:
> * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
> * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"
> It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.
> I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.
> The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.
> Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
> There are issues to be fixed prior to a commit, see OFBIZ-3446.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

1234